Message ID | 5070ac45-2f91-c9d7-de7c-31d38750015e@axentia.se |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2125132vqo; Tue, 23 May 2023 06:05:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6aMgz7zhXI5bRb3p/vayYpdVeRrNqh6+e1gPY/zA5IauOPRwPGLMLKdxQERNzmXLibRyyW X-Received: by 2002:a17:902:e547:b0:1a6:bb04:a020 with SMTP id n7-20020a170902e54700b001a6bb04a020mr16783906plf.46.1684847124569; Tue, 23 May 2023 06:05:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684847124; cv=pass; d=google.com; s=arc-20160816; b=kO/86VSRQRq7/gW8vqgyfWUMuTgPz8iQ4vt8DgPD1Hwwhz7Sw3/nHbPI/BLg+SlGfp LiWcWI4IQmkjsyrIK8L/V86szp+0MjopPHP3LjASN04z0vrs+/olfbhQY0ABi4luDEub N4Q1clPbx5MeBZGqQricOHnIIzVIQseZgSqkve8p1r6JFs67KA87/V/G8w7wCIVRmxT3 hL1uR7vazPARmngpe07cD1w6rahTv/7D7MNrTwXU6SO+MbGrS+VXkfAaeZfYLTpPnyq1 wzIWqXKGaPuv3qPr03m7gTYBIYm568BeF/72OvUd+sdlupr3clOZJwyxWB9zj3HiJDXe Z1wQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding:subject :from:cc:to:references:in-reply-to:content-language:user-agent:date :message-id:dkim-signature; bh=XXMoADEGlM5mjtizpPzBqbTJlAXv5uAhIfOFZaVODkI=; b=qUpAd8M0EUwoBZBCEQPrUiPD1C2vb7XQScLydC4ynNbobSAd90FZPzIUuuGMdRDIQo TGWQnLBGLwO/UZBC8wXyBRX7tCP9BpdBjJ5xYP0CIkj2r2TN0Cecsaqwj5t4doQ9MpHU dSGpNwzw4M9vtfbi7ZrPee1rb1VnAKQanQgIclObJxPqvltsvzucrHKgNGsl11fKg/CN rrudKJP+nTfta/XG4TA7DMta/FSNtDvddqcfLDIFgdINn6EdOhaIz59m5GpDTHYmVZ8L 5qxONzaYBexqF8rA0IGvd/Lzs5EUBk5qkGvUei8yiw5YU4DbpryWDddJ2xIJAUBlntT0 UN1A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@axentia.se header.s=selector2 header.b=goGawR5K; arc=pass (i=1 spf=pass spfdomain=axentia.se dkim=pass dkdomain=axentia.se dmarc=pass fromdomain=axentia.se); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b19-20020a170902b61300b001ac34fed041si1590059pls.475.2023.05.23.06.05.10; Tue, 23 May 2023 06:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@axentia.se header.s=selector2 header.b=goGawR5K; arc=pass (i=1 spf=pass spfdomain=axentia.se dkim=pass dkdomain=axentia.se dmarc=pass fromdomain=axentia.se); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236959AbjEWMnF (ORCPT <rfc822;ahmedalshaiji.dev@gmail.com> + 99 others); Tue, 23 May 2023 08:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236962AbjEWMnB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 23 May 2023 08:43:01 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2109.outbound.protection.outlook.com [40.107.6.109]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CF4C109; Tue, 23 May 2023 05:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFFd2aXStZnojCwIxoSEoIU5wtAw9lvlwlfusUbxM3+5S+uzbLISmSozKXoNWLnxcstXj44kT5zXSObKETY9P9W9MOCrO3RSmU14EbHB4fWVVgUS0kyR2tOFeQbRfMMutHz+eq2EfvIhio1UhAFWuynEItCFpNicNNzlc8vawoD35pagg7+FTGUKbV7lrlZBn7IIthginMH68nMykPDEGLkwts87FNpjtnGOWrB3OG5fA9xuR63F/S3FB0nusGy5lWjY9wGd4GKqKsViDGw1RHlIgqNWRpgJTZKj5PXPHioViXctOLEv4EwR70Q6BRUkiEKsSH98YA/6iXpKivSugA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XXMoADEGlM5mjtizpPzBqbTJlAXv5uAhIfOFZaVODkI=; b=laGTkVN4eRXTD8HdQrEpjmnUpGNMZI/eEKcQAh00VmVy6n3kjoADt9cvylbzQZK/nQ4vr2Etn7qFoqHoA3Op72HnXHTUO7/rIaofjWiQlree+SBX38RPh2Oa9zo9MGkC3e4BrrnhfV97FUZBO6z8TCZfwnzHPTMG/Vl1HH7Xa01ZX5zpSJgLVw3XKASJmYWmQF/PHZQu8SgQ+DpOZhAekhDnoN6g3PnDeuruU8CywWiL92D5WaIGppEB8d+aXlCJhorSIQXhQPvheAU2rXK3oTX1mxV219hH/qX7DWJ83jBmNv0ni1CaM7oKIQMmbzbbsclL9YIWJBMn8W8VXINdAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXMoADEGlM5mjtizpPzBqbTJlAXv5uAhIfOFZaVODkI=; b=goGawR5KTqKWXTvQ66BkIWYu/lNY+1BwfFmFwWM6YGgIQLJ0y4v1m8zFtUtq28dtCnvKx1Wm7+slmq/3+vPHq06sV/Kfb2RfKfP+JaygyVzMVFDZosZR8RucVCrK4cDFTN2OF8iifYqaCDbCt+MaAis+exxcarl7hpuAnFV6gcQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=axentia.se; Received: from VI1PR02MB4445.eurprd02.prod.outlook.com (2603:10a6:803:ab::28) by AM7PR02MB6145.eurprd02.prod.outlook.com (2603:10a6:20b:1a2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 12:42:58 +0000 Received: from VI1PR02MB4445.eurprd02.prod.outlook.com ([fe80::b703:24c6:975a:bf84]) by VI1PR02MB4445.eurprd02.prod.outlook.com ([fe80::b703:24c6:975a:bf84%4]) with mapi id 15.20.6411.028; Tue, 23 May 2023 12:42:58 +0000 Message-ID: <5070ac45-2f91-c9d7-de7c-31d38750015e@axentia.se> Date: Tue, 23 May 2023 14:42:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: sv-SE In-Reply-To: <dc4834cb-fadf-17a5-fbc7-cf500db88f20@axentia.se> References: <dc4834cb-fadf-17a5-fbc7-cf500db88f20@axentia.se> To: LKML <linux-kernel@vger.kernel.org> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>, Tudor Ambarus <tudor.ambarus@linaro.org>, Vinod Koul <vkoul@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org From: Peter Rosin <peda@axentia.se> Subject: [PATCH 2/2] dmaengine: at_hdmac: Remove unused field values that do not fit Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MM0P280CA0069.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:8::6) To VI1PR02MB4445.eurprd02.prod.outlook.com (2603:10a6:803:ab::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR02MB4445:EE_|AM7PR02MB6145:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d1d93b6-c021-42c1-b9e2-08db5b8b3cc6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A3zTRBXd3fthozqvhiXQy/DK3mZPIu/p4jEryZhaFgjm+dQoUqvrWwOrN6BhAaaxaB3QFZ8x9Hdg3kn1b2yKWIpfCGWCLPMBF9VNwp7K5KZUYm0ZThrI9UpuYIzDebfm3IbMQh14mTx7obBaTFDq2y7+pW04uIWfeg9QLPLMHPweSvQwTeNzyMEveNZ/ujAiFeI8Ef6mVoZB73DHvRixAel/boc0LNAuvFahuLF83x9cGRiKlzQevjedwZNwizotMRLf63cvATXUzlTMQbWBjsi6iHkhMTH37Sd18yjyBzFZaPaBqC4K3gySCFgQcyIun4dciVjDfXOen73RaTycKXFn9Z2f3jm4kBwBipleY4aNm9czVnnQe5lY813/1bwNCkasMNBiCZrdSRVP961oPIJRWY/fpG/SeZN9a0ai0d640NnWYrqwg8EBkISuGjOIpxcHsDJkMqHmfgunBA84YdHTmey8y50BmGTUC6A1prAcrLHWRvyszClpEEJYl9/dku3Fj0cbhWn56NsTzT492jaEoOaM2ELnCDQHTXwDp5SbYHzSwsnFwCFZk885rpvIUF0NARs1+Flp+l7Qyb/BgZgEW1+dW4j/D63sBFot/k3LoLwsEf3ljVDg6h1oZflNAIBBOdv6RLRjMKK8vy8mNw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR02MB4445.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39830400003)(376002)(366004)(346002)(396003)(136003)(451199021)(54906003)(86362001)(41300700001)(6486002)(31696002)(31686004)(478600001)(316002)(4326008)(6916009)(66476007)(6666004)(66556008)(66946007)(5660300002)(8936002)(8676002)(38100700002)(6512007)(26005)(186003)(6506007)(83380400001)(2906002)(2616005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4c+N+WhJloKvLXIuQS07e6RNGuB1?= =?utf-8?q?hKEHEKZxN7PqVpW7G2TPLHd75PzoaXDO/bEm9iIUCJqnnqaNief+TpYcASU/cmdxG?= =?utf-8?q?3AfKvUurbj/zCcCDvmTni88hEB+a75gmFqGXwXKJh+KJ44cpFNlBu1YF8/Due3g+t?= =?utf-8?q?XRbSWvzMprkdo+XQZ1hNI5F5JYlaUvuP2wCEdAyqxR7wfjszavmnHdaHH3QfUqa+x?= =?utf-8?q?eMmVOnjZCV0YXEkmtBSHet5Fl+wXd+9qOgfwh9cGRWJX+caWTSgUN6yL3mmfqvGE+?= =?utf-8?q?by1O7ncIuEQxm7KS57iPdB4PjoI4qG62j2ZJ5aYkUnTi9Q2ksiVb3B9QFcse1EcYA?= =?utf-8?q?97xLSXMlJglQwV7+j/oiZ0X5ygIwkTtyq9LAeEsy8ECPVVRYHDpEeig6Qv2tJV+M1?= =?utf-8?q?PGdUUPDlqA80bfUgXrCHDJbGzuJ9w9/QB9tHWCIheWFI6lCIrCxe+u1t5mPw8SWfx?= =?utf-8?q?0Ny8AAO8ZNzm5dRO2HBwjonI5Jrla2obrnZalfsBpYplkguSPnz+Pg2B8DlOcpiX0?= =?utf-8?q?orE2YYxW1bzbtUwd5GSUxPkYjA+vspSMAlcoaePP44QNkAwgC7U9QYlk3QaWz1jHl?= =?utf-8?q?l3kEbeh0mL1D3xSD44oX6+H3DMmWgjykVYIzcfSVXkxQjcgID3u/BNkmp6UABV2AB?= =?utf-8?q?KMmHeV6xMRb7jqM9is+dEnBr1q2AMbUpWlNGYXHWs6ljc2+TICDf1pUV+YhkegP11?= =?utf-8?q?2Qvhl7QGjPUJBYuNP2J8KYQna2RhvtgfN56kmR8KBqtrmjGy0PHVX5hnnhYM5s5Ie?= =?utf-8?q?wmzlaoP2lggHLrFLN8rtbmosPae1VAqHA/r8DZ1OUh/7mECBvNtIuaEUWjSJGkG1L?= =?utf-8?q?9hCkJjbb9DdzwRPS72OqopcvojK3lCDiTFNVM3uH+fEjZbbAbludSsmmTUYwayj2W?= =?utf-8?q?RGVeS3pMkQUK6Iqn3kKnwgHAIN/c3M0dT4mpq2ETkwh7gbhtu2AQ5DNYExXQE95Lp?= =?utf-8?q?fAA5frpa8snxJ461CfCCaTwLcsJIeQPvpcFFdGsuuA4ApFb5dRL25Z4vZ3O31CYtR?= =?utf-8?q?4U7eW9ffp2HqCGxLri/ux5jLPbeZVTE5+q/3owu/oKyk794nfzwuKltK5rZKcg2uO?= =?utf-8?q?Bs4g3yydsqTdk0wY217h/xgfsItkX2prfNXmHhFSyGq8lMdfSKcY57GlZFH7RF4go?= =?utf-8?q?VbGLXU3NX0sihi5PsylF4k6F1akSYPBgbGbEk0IkxXUIQf+fQ9m5ras3s2vAYvbA0?= =?utf-8?q?Fucqyrg8vU2tkFrvwEWJxCmMISEwFvPBolE0zVffU92kOJHNDU99ZRFPernf/ALKi?= =?utf-8?q?IvkTCkcEDuRltWwEfO2j2p1UHHgZ15FSm7VYTHu4k/YTwOk+jQ0sgWG7T8j1MlT7a?= =?utf-8?q?MW0eaGQEbpVk9MfOXVD5UZBsMja6jwjyGSnSwTY0UXsREcSXojGJ2OLngtr8MjmKz?= =?utf-8?q?l6iodW80iQQP8lmD6uKAU0TVcNzxoGBySNo7UHjFXTUVaU5KSYEd29yQ0HHAC4yVV?= =?utf-8?q?TqQnS+/in4TxOEiIGO55ay9vgZOudl9lylwPy0uKGXcIricPTIjCfhkenyqf8eZlr?= =?utf-8?q?CUcm9Vj4Y4mh?= X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 8d1d93b6-c021-42c1-b9e2-08db5b8b3cc6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB4445.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 12:42:58.2418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rrEOhzMP57cKUcNboxYpqUI3YwCE4XN6DgvIo3vBfRJtdHhfKjVL8PjsdIdtv8Nq X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR02MB6145 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766690258653492847?= X-GMAIL-MSGID: =?utf-8?q?1766690258653492847?= |
Series |
dmaengine: at_hdmac: Regression fix and cleanup
|
|
Commit Message
Peter Rosin
May 23, 2023, 12:42 p.m. UTC
The values are not used, and they do not fit in the intended
register field (ATC_FC, 2 bits wide). Kill 'em all.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
drivers/dma/at_hdmac.c | 4 ----
1 file changed, 4 deletions(-)
Comments
Hi, Peter, On 5/23/23 13:42, Peter Rosin wrote: > The values are not used, and they do not fit in the intended > register field (ATC_FC, 2 bits wide). Kill 'em all. > Actually ATC_FC should be set to GENMASK(23, 21) and keep the other definitions, see: http://ww1.microchip.com/downloads/en/devicedoc/Atmel-6438-32-bit-ARM926-Embedded-Microprocessor-SAM9G45_Datasheet.pdf After you update the patch you should also add: Fixes: d8840a7edcf0 ("dmaengine: at_hdmac: Use bitfield access macros") Cc: stable@vger.kernel.org so that it gets backported to Linux-stable. Feel free to add my R-b tag after addressing the comments: Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > drivers/dma/at_hdmac.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 6f352160bc3b..51d0a0c7aaf7 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -137,10 +137,6 @@ > #define ATC_FC_MEM2PER 0x1 /* Mem-to-Periph (DMA) */ > #define ATC_FC_PER2MEM 0x2 /* Periph-to-Mem (DMA) */ > #define ATC_FC_PER2PER 0x3 /* Periph-to-Periph (DMA) */ > -#define ATC_FC_PER2MEM_PER 0x4 /* Periph-to-Mem (Peripheral) */ > -#define ATC_FC_MEM2PER_PER 0x5 /* Mem-to-Periph (Peripheral) */ > -#define ATC_FC_PER2PER_SRCPER 0x6 /* Periph-to-Periph (Src Peripheral) */ > -#define ATC_FC_PER2PER_DSTPER 0x7 /* Periph-to-Periph (Dst Peripheral) */ > #define ATC_SRC_ADDR_MODE GENMASK(25, 24) > #define ATC_SRC_ADDR_MODE_INCR 0x0 /* Incrementing Mode */ > #define ATC_SRC_ADDR_MODE_DECR 0x1 /* Decrementing Mode */
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 6f352160bc3b..51d0a0c7aaf7 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -137,10 +137,6 @@ #define ATC_FC_MEM2PER 0x1 /* Mem-to-Periph (DMA) */ #define ATC_FC_PER2MEM 0x2 /* Periph-to-Mem (DMA) */ #define ATC_FC_PER2PER 0x3 /* Periph-to-Periph (DMA) */ -#define ATC_FC_PER2MEM_PER 0x4 /* Periph-to-Mem (Peripheral) */ -#define ATC_FC_MEM2PER_PER 0x5 /* Mem-to-Periph (Peripheral) */ -#define ATC_FC_PER2PER_SRCPER 0x6 /* Periph-to-Periph (Src Peripheral) */ -#define ATC_FC_PER2PER_DSTPER 0x7 /* Periph-to-Periph (Dst Peripheral) */ #define ATC_SRC_ADDR_MODE GENMASK(25, 24) #define ATC_SRC_ADDR_MODE_INCR 0x0 /* Incrementing Mode */ #define ATC_SRC_ADDR_MODE_DECR 0x1 /* Decrementing Mode */