From patchwork Mon Jul 17 08:03:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandor Yu X-Patchwork-Id: 121127 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp980750vqt; Mon, 17 Jul 2023 01:37:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdl8z3CC5CUO81NfFoxBY72l3nhAH5QiUWdmBoWxl7UWlcs2Uts9OnVWwDTRHtX0+pxG7h X-Received: by 2002:a05:6a20:72a6:b0:133:7ad8:712b with SMTP id o38-20020a056a2072a600b001337ad8712bmr12118340pzk.52.1689583069788; Mon, 17 Jul 2023 01:37:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689583069; cv=pass; d=google.com; s=arc-20160816; b=dxBJlnskDnXVc1nmK8pQagJ/8WJpdqLL9btTvkgra1IMvLChhaczhxGUIIl6hnUx2O Oq1G2+qpfBGaHpl4ROLt/GL/OdYr2qX4+2q+e4QVRR3uTfaaHzYt8W/74VhNtK786RNW g0Wb4WyNbfhn+WVHkcLQLnD1G9lDhRgGdswyJdUU5gXHru6mB9qv3xJRbWUwg6eL2EMF snJ9PcWVgE+2ZQ2us/dKXfsO36wbdNiHBKDFg9XwuQ4xr1tO5VivDJAItGy37pq/M2Nt ApMk64k4zynUHMJXm7OvD2ZOoqsV1LqiH9obdMLQnLUlboQl68c8gxnXI+h/hysaS1Zn C1WQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; fh=PUBVPucWc8lRluY+e+5uvxRpT/FpFBsE6bTTCuvGxf8=; b=mfzZO1VPZrdkBMfXo1bqiNXTmNe2Sw9ToHl8rYFJd23L6MqKMobkTmYXcqMYdwwEQM XsrMzvNiofIptb3tD7WzSBc2fZ9BxKLm1NftHFS9DZsseAISuAlOK8Y1cfW9wfBdfo3V /l4x/Q8hffSA4vJWxQNZYscKzdRKg3ipMF4S+r08iUh5jlPFN9A7JL9jedmylIky3cZM 9EpXLVaTmevCTKWcq6mAYYaM3YwdDvkfsSK+tNLq1O7dKSJkYCVai1zMLlwNTOsh4uDl uKouPHpiOKRVK49cdfFEYl8+io8M1iH2hOOU4qGEXtU9CpclCPLS5+O8ehKE8dtxu5tv 67kQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=GBG3jdfF; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e1-20020a636901000000b0055baed7e7e6si11117655pgc.251.2023.07.17.01.37.37; Mon, 17 Jul 2023 01:37:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=GBG3jdfF; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbjGQIFG (ORCPT + 99 others); Mon, 17 Jul 2023 04:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjGQIFD (ORCPT ); Mon, 17 Jul 2023 04:05:03 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2083.outbound.protection.outlook.com [40.107.6.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D007E199; Mon, 17 Jul 2023 01:04:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOMJaQZS7o8/GTZYbUBkmMf1Bx/9qV2mT3OTmv4mE33B9DIdzCxGXcj+HxWd/bZNNeRj8a1ACbOCmFUsWzVJO3q19LrbLWLN5ds48XYy1MizDQkzIspVnEvfj2ukoDAGX5C5FYh37n2KSM91vPu0O+Y7ytjCPvQ2bLJlLPkYsWJ3zfqsULMXG8jHEQbvLQWfH+Xk7DVzc75B6z0tvquAI7Y2xRAcs94+q89CuzptYx+YKsOhk1uR79UB4NuFfKjkmpbjmYQxxzmx07U+VZl7za6wq3OqWAkcddhci0x5hbULolAksXHv486lYXBbXGfaBArrRpd2U1gvwSbx3KI/pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; b=Mzw84+42LNjtHvzoqZipvHOv15Myhl8btjMRCNUVmw8s7sCN+SkoYOYfUW6aceJtDgSZzIOt6wt6RwS9yepdpLNG28MRRb8UaoCu4vcrUxFFfI4MFnqoLtZ3OZkYN0GSdDZBbjjx1HusFXjb8zRgZvdbx6KX0GFBted3+tv4ZsWrJtgokntq/knQ9EPEc/2csYY/XVD4ow1AKY1h14V3Bs0UTY6MNptaoSz13rMuZr/YQhQ2Oq9hsxoNGIayw1di/VWCwqvvUk9sDMmXREogGdNcVymBUrLLQIQ47wLlHyQxz3nVjRriElf2cmwt4+AeD+ebHSrs6EzgMMqwzE+jAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ijwdeyLNa08NSnsUKg5AfgNvRzY4Cu80iQJCRRRMXtk=; b=GBG3jdfFY/BlCKGuYMqdJyD7s/96J8xdgzHCislxMQ9/bWiBkFEzmy6YhLlreWIdYsY5gBXjybGsggl2WbxwpVeyBTdrVZDMkQAJ6+f3IxwYwXYQxNn5RTJp3I7Jick8TOt7RhJ3GDaQM9eodvvoPnrr0/az+MWHToHf8g13VKc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) by AM9PR04MB8291.eurprd04.prod.outlook.com (2603:10a6:20b:3e5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Mon, 17 Jul 2023 08:04:46 +0000 Received: from PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::3505:c499:96d4:1429]) by PAXPR04MB9448.eurprd04.prod.outlook.com ([fe80::3505:c499:96d4:1429%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 08:04:46 +0000 From: Sandor Yu To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Cc: kernel@pengutronix.de, linux-imx@nxp.com, Sandor.yu@nxp.com, oliver.brown@nxp.com, alexander.stein@ew.tq-group.com, sam@ravnborg.org Subject: [PATCH v7 1/7] drm: bridge: Cadence: convert mailbox functions to macro functions Date: Mon, 17 Jul 2023 16:03:47 +0800 Message-Id: <4dbf70119fa74dd0061cc65703f4c4e06874d250.1689580812.git.Sandor.yu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-ClientProxiedBy: SI2P153CA0030.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::15) To PAXPR04MB9448.eurprd04.prod.outlook.com (2603:10a6:102:2b1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9448:EE_|AM9PR04MB8291:EE_ X-MS-Office365-Filtering-Correlation-Id: 917830fc-6473-4eb9-d43e-08db869c7c4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KexzPv2vsBz+tG8hymgdGHdPMHqVRC42XD14ADi4DWpRGSmScVjCxlPQ729ZCMP6a1jEgx/7nDfUtAl53uATCvdork+XTsqfLNPWBApP9QikW8s1CbksUKtBocDtn/+p4sL/ciVbs7KnDQPe5GeyxKzu+MwchS1/dlucaEerTNcKe+HKAAmx0BKuSWed+W3/4q9vplVeVArxPURZ93BiZ+frMXb2Inn9ILkGtYisKWZzK6ishGaVwj/F7L83CW1dCYbr9LAXvZyCByE7wHO0nRWimJ4Or9GVbPzcKCqXr0C5txbxkCXxYfeYU6BVx9UVpPW8hDHps+cOTBAT17SI27IzUzLW/EeEn9ayAqzR/tE0Juqb5jn50y4OK78aO5YgW6LEZo4pIZu8xlBLLURopG5jZxszUszIkSJNUGRrQIwJYG/WvrAmpvJsDiNMPW2sYdwu1GxatM2A9q/qceAOBsquC5QCK3kPpz5y/i5+ddiHZSbQZM3+IG2WZXxZuqjcfS9B+1XiTO8aEBUbNmL/yP2EN+LnomZq3W8RXX7gf5U27n2S1jmKZ55CArHYa2oITztlD+SnXxbhivWSE++nGVLsvEbap3mVpQ5WIkE3CHzAWfiG8Xg9M96dzcofzg2K X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9448.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199021)(478600001)(52116002)(6486002)(186003)(6506007)(26005)(6512007)(2906002)(15650500001)(30864003)(41300700001)(316002)(4326008)(66476007)(66946007)(66556008)(5660300002)(36756003)(7416002)(8936002)(8676002)(38350700002)(38100700002)(921005)(86362001)(2616005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TcuXDTgZXdgM3e/qGH8fICPzcHZNEYKalHo3628T/J2dRNqZnS3vtVCVvJq8ziBFQZiSGp+zqhCbPsovBY57mm1Jd9/KqYs0LtU9yu+n4i65RQCw3OYfqNZPTpo0L6gDGvOdzH7CIu5T0qkFD93wEs4u1i3AMaoQV9G121ssOvFlC3CZ1k/DbaBZgFLemhWPkCal2hHgNIq+u3es0K5q3lvRi88eIi16Oh3FhbWw1srEnHoxckN7OF3tREq+5hwMIHncdKtxaBjpolvcAXdDYOAg63oKSlA1wYVFGLaW0QCdqXCOGmuufDrMResqt34rDIF1tRuSoGyg0iHGtadAL1yE/xtLmiFx5E8GyYLjIZXNRqyh/Px44GaNlmeJob3ZVdysW9W1bsOzFKNgq6r4ooBItezxAEzZjqN9X6pOMP6ShAKEPudveS9uWT+92UdEJOmefkQ9Sg/0AqMa4a2A8OvjEYlFQ+kBp+fyvYtIkxwAIUPNnaRcPtW+6Xhq7Gp/m6NlMzAWXNFqXPEzdpbT8gLYUsWfxK42qq2292n4IYrD0IYLwvnEpFB8cZeqEEeZ7aYuS9y0gOMJVGU+2NeivGdSU97Jm1e/6Wxyb+stplBhE2vWQ/KfBLf/Mtp9QoFV8zeOhuCXF5VQW/voq/bcm52hxppHO9rVNwUYnroVbyuKYoqfs36fq7VdL3IV/8xhWgQ/DLyTk2FhD+BJxO5OlwLJNu1t8CHXLvexi6mPYW1ltkKWLZbdoVY7uDxlVIm8nbHd95rEObGCqvQ689DmCKpINbC48L1GqrB9V3yKj2FIYz0s0N4a1VBeDuc05V/DipexspTt0xYb1Q+9q7uyEDEhHVahWk0WWxl6wvJqRQ2a7b/UjU0KDJeQxdG10g5Tt5jjO//wc6NBkLKhS35gGifEN9kMYg4sowneCt69vzdq8XbwM9J1qQsq7VwpzXmAeqvLkga1wuWNQ3oQp6H6JMZa3qet0o2iM5yRbEoLlmgnd+2C3rlXyLqA7VbQv0YyfTgDq55QVPKnAMESaE3jsrbdGxkkzIxLo5zSOi74aqRziowws1rFTYzBiEJ8atCt8zNlquEKLLNaxFnUgRKfyuEMnDjrGJQUkQ1Iem8YPguK8BGjw3KvzG1mGJidATJIvQPZsw4v12+6Ajyb27bPWJeTtv2cJKA0IW2Sg89CbHUy0d8wBY2Wf+0FXCEUspNTGj1uYxzjJ+KF9rOGA5kpxUiN9/9lZQvH2PXwkzKJmF67UVnf8IeY1jtJVihtb1XTEFukmEYoJeoAAkeG0qz/YygzxTY8Lmk6LIDmTdqpw2WtAZ91Si17xwu7IV/mzOKXPs1I42cCvOcgxNg3k8ssmwWr2sUtX17M1vq/KmfPoTRFAEH5CHQ3srQa89pXjwjb7adIkZDUYe3e2ZCmcFwadhBMTsjKkq/3nrVy3nbBL7mWGccsuv+UihdJTL7pOafDf7q56uqnMNPQpAm+Mz9UoP7m8Wq3uKD3s1AHQHlowgbi2ybIaoCGGXSfoqhEesqRA2pjTGB7ylaQK0Y3pb+crcMYz93zABljrB/HyGLsfalbdHl9JCWISpBI7oX+8jzN X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 917830fc-6473-4eb9-d43e-08db869c7c4d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9448.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 08:04:46.4023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1grhWpf25d0Ef/1IVsL+mP0mSjdy+mi5BJZ1E8iCE1qBLarvnIA8jnp77BAyM7fjaodi5bDv1TBK7bh7tT7Thg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8291 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771656256940553141 X-GMAIL-MSGID: 1771656256940553141 MHDP8546 mailbox access functions will be share to other mhdp driver and Cadence HDP-TX HDMI/DP PHY drivers. Move those functions to head file include/drm/bridge/cdns-mhdp-mailbox.h and convert them to macro functions. Signed-off-by: Sandor Yu --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 195 +------------- .../drm/bridge/cadence/cdns-mhdp8546-core.h | 1 - include/drm/bridge/cdns-mhdp-mailbox.h | 240 ++++++++++++++++++ 3 files changed, 241 insertions(+), 195 deletions(-) create mode 100644 include/drm/bridge/cdns-mhdp-mailbox.h diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index f6822dfa3805..ddd3c633c7bf 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -36,6 +36,7 @@ #include #include +#include #include #include #include @@ -54,200 +55,6 @@ #include "cdns-mhdp8546-hdcp.h" #include "cdns-mhdp8546-j721e.h" -static int cdns_mhdp_mailbox_read(struct cdns_mhdp_device *mhdp) -{ - int ret, empty; - - WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); - - ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_EMPTY, - empty, !empty, MAILBOX_RETRY_US, - MAILBOX_TIMEOUT_US); - if (ret < 0) - return ret; - - return readl(mhdp->regs + CDNS_MAILBOX_RX_DATA) & 0xff; -} - -static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) -{ - int ret, full; - - WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); - - ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_FULL, - full, !full, MAILBOX_RETRY_US, - MAILBOX_TIMEOUT_US); - if (ret < 0) - return ret; - - writel(val, mhdp->regs + CDNS_MAILBOX_TX_DATA); - - return 0; -} - -static int cdns_mhdp_mailbox_recv_header(struct cdns_mhdp_device *mhdp, - u8 module_id, u8 opcode, - u16 req_size) -{ - u32 mbox_size, i; - u8 header[4]; - int ret; - - /* read the header of the message */ - for (i = 0; i < sizeof(header); i++) { - ret = cdns_mhdp_mailbox_read(mhdp); - if (ret < 0) - return ret; - - header[i] = ret; - } - - mbox_size = get_unaligned_be16(header + 2); - - if (opcode != header[0] || module_id != header[1] || - req_size != mbox_size) { - /* - * If the message in mailbox is not what we want, we need to - * clear the mailbox by reading its contents. - */ - for (i = 0; i < mbox_size; i++) - if (cdns_mhdp_mailbox_read(mhdp) < 0) - break; - - return -EINVAL; - } - - return 0; -} - -static int cdns_mhdp_mailbox_recv_data(struct cdns_mhdp_device *mhdp, - u8 *buff, u16 buff_size) -{ - u32 i; - int ret; - - for (i = 0; i < buff_size; i++) { - ret = cdns_mhdp_mailbox_read(mhdp); - if (ret < 0) - return ret; - - buff[i] = ret; - } - - return 0; -} - -static int cdns_mhdp_mailbox_send(struct cdns_mhdp_device *mhdp, u8 module_id, - u8 opcode, u16 size, u8 *message) -{ - u8 header[4]; - int ret, i; - - header[0] = opcode; - header[1] = module_id; - put_unaligned_be16(size, header + 2); - - for (i = 0; i < sizeof(header); i++) { - ret = cdns_mhdp_mailbox_write(mhdp, header[i]); - if (ret) - return ret; - } - - for (i = 0; i < size; i++) { - ret = cdns_mhdp_mailbox_write(mhdp, message[i]); - if (ret) - return ret; - } - - return 0; -} - -static -int cdns_mhdp_reg_read(struct cdns_mhdp_device *mhdp, u32 addr, u32 *value) -{ - u8 msg[4], resp[8]; - int ret; - - put_unaligned_be32(addr, msg); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_GENERAL, - GENERAL_REGISTER_READ, - sizeof(msg), msg); - if (ret) - goto out; - - ret = cdns_mhdp_mailbox_recv_header(mhdp, MB_MODULE_ID_GENERAL, - GENERAL_REGISTER_READ, - sizeof(resp)); - if (ret) - goto out; - - ret = cdns_mhdp_mailbox_recv_data(mhdp, resp, sizeof(resp)); - if (ret) - goto out; - - /* Returned address value should be the same as requested */ - if (memcmp(msg, resp, sizeof(msg))) { - ret = -EINVAL; - goto out; - } - - *value = get_unaligned_be32(resp + 4); - -out: - mutex_unlock(&mhdp->mbox_mutex); - if (ret) { - dev_err(mhdp->dev, "Failed to read register\n"); - *value = 0; - } - - return ret; -} - -static -int cdns_mhdp_reg_write(struct cdns_mhdp_device *mhdp, u16 addr, u32 val) -{ - u8 msg[6]; - int ret; - - put_unaligned_be16(addr, msg); - put_unaligned_be32(val, msg + 2); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_DP_TX, - DPTX_WRITE_REGISTER, sizeof(msg), msg); - - mutex_unlock(&mhdp->mbox_mutex); - - return ret; -} - -static -int cdns_mhdp_reg_write_bit(struct cdns_mhdp_device *mhdp, u16 addr, - u8 start_bit, u8 bits_no, u32 val) -{ - u8 field[8]; - int ret; - - put_unaligned_be16(addr, field); - field[2] = start_bit; - field[3] = bits_no; - put_unaligned_be32(val, field + 4); - - mutex_lock(&mhdp->mbox_mutex); - - ret = cdns_mhdp_mailbox_send(mhdp, MB_MODULE_ID_DP_TX, - DPTX_WRITE_FIELD, sizeof(field), field); - - mutex_unlock(&mhdp->mbox_mutex); - - return ret; -} - static int cdns_mhdp_dpcd_read(struct cdns_mhdp_device *mhdp, u32 addr, u8 *data, u16 len) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h index bedddd510d17..10c878bf0e63 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h @@ -212,7 +212,6 @@ struct phy; #define MB_MODULE_ID_HDCP_TX 0x07 #define MB_MODULE_ID_HDCP_RX 0x08 #define MB_MODULE_ID_HDCP_GENERAL 0x09 -#define MB_MODULE_ID_GENERAL 0x0a /* firmware and opcodes */ #define FW_NAME "cadence/mhdp8546.bin" diff --git a/include/drm/bridge/cdns-mhdp-mailbox.h b/include/drm/bridge/cdns-mhdp-mailbox.h new file mode 100644 index 000000000000..9f551bf956a1 --- /dev/null +++ b/include/drm/bridge/cdns-mhdp-mailbox.h @@ -0,0 +1,240 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Cadence MHDP Firmware Access API function by Malibox. + * + * Copyright (C) 2022 NXP Semiconductor, Inc. + * + */ +#ifndef CDNS_MHDP_MAILBOX_H +#define CDNS_MHDP_MAILBOX_H + +#include +#include + +/* mailbox regs offset */ +#define CDNS_MAILBOX_FULL 0x00008 +#define CDNS_MAILBOX_EMPTY 0x0000c +#define CDNS_MAILBOX_TX_DATA 0x00010 +#define CDNS_MAILBOX_RX_DATA 0x00014 + +#define MAILBOX_RETRY_US 1000 +#define MAILBOX_TIMEOUT_US 2000000 + +/* Module ID Code */ +#define MB_MODULE_ID_GENERAL 0x0A +#define MB_MODULE_ID_DP_TX 0x01 + +/* General Commands */ +#define GENERAL_REGISTER_WRITE 0x05 +#define GENERAL_REGISTER_READ 0x07 + +/* DP TX Command */ +#define DPTX_WRITE_FIELD 0x08 + +/* MHDP Firmware access functions by Mailbox */ +#define cdns_mhdp_mailbox_read(_mhdp) \ +({ \ + int ret, empty, val; \ +\ + WARN_ON(!mutex_is_locked(&(_mhdp)->mbox_mutex)); \ +\ + do { \ + ret = readx_poll_timeout(readl, (_mhdp)->regs + CDNS_MAILBOX_EMPTY, \ + empty, !empty, MAILBOX_RETRY_US, \ + MAILBOX_TIMEOUT_US); \ + if (ret < 0) \ + break; \ +\ + val = readl((_mhdp)->regs + CDNS_MAILBOX_RX_DATA) & 0xff; \ + } while (0); \ +\ + (ret < 0) ? ret : val; \ +}) + +#define cdns_mhdp_mailbox_write(_mhdp, _val) \ +({ \ + int ret, full; \ +\ + WARN_ON(!mutex_is_locked(&(_mhdp)->mbox_mutex)); \ +\ + do { \ + ret = readx_poll_timeout(readl, (_mhdp)->regs + CDNS_MAILBOX_FULL, \ + full, !full, MAILBOX_RETRY_US, \ + MAILBOX_TIMEOUT_US); \ + if (ret < 0) \ + break; \ +\ + writel((_val), (_mhdp)->regs + CDNS_MAILBOX_TX_DATA); \ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_recv_header(_mhdp, _module_id, _opcode, _req_size) \ +({ \ + u32 mbox_size, i; \ + u8 header[4]; \ + int ret; \ +\ + do { \ + /* read the header of the message */ \ + for (i = 0; i < sizeof(header); i++) { \ + ret = cdns_mhdp_mailbox_read(_mhdp); \ + if (ret < 0) \ + break; \ +\ + header[i] = ret; \ + } \ +\ + mbox_size = get_unaligned_be16(header + 2); \ +\ + if ((_opcode) != header[0] || (_module_id) != header[1] || \ + (_req_size) != mbox_size) { \ + /* If the message in mailbox is not what we want, we need to + * clear the mailbox by reading its contents. */ \ + for (i = 0; i < mbox_size; i++) \ + if (cdns_mhdp_mailbox_read(_mhdp) < 0) \ + break; \ +\ + ret = -EINVAL; \ + } \ +\ + ret = 0; \ +\ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_recv_data(_mhdp, _buff, _buff_size) \ +({ \ + u32 i; \ + int ret; \ +\ + do { \ + for (i = 0; i < (_buff_size); i++) { \ + ret = cdns_mhdp_mailbox_read(_mhdp); \ + if (ret < 0) \ + break; \ +\ + ((u8 *)_buff)[i] = ret; \ + } \ +\ + ret = 0; \ +\ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_mailbox_send(_mhdp, _module_id, _opcode, _size, _message) \ +({ \ + u8 header[4]; \ + int ret, i; \ +\ + header[0] = _opcode; \ + header[1] = _module_id; \ + put_unaligned_be16(_size, header + 2); \ +\ + do { \ + for (i = 0; i < sizeof(header); i++) { \ + ret = cdns_mhdp_mailbox_write(_mhdp, header[i]); \ + if (ret < 0) \ + break; \ + } \ +\ + for (i = 0; i < _size; i++) { \ + ret = cdns_mhdp_mailbox_write(_mhdp, ((u8 *)_message)[i]); \ + if (ret < 0) \ + break;; \ + } \ + ret = 0; \ + } while (0); \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_read(_mhdp, _addr, _value) \ +({ \ + u8 msg[4], resp[8]; \ + int ret; \ +\ + put_unaligned_be32(_addr, msg); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + do { \ + ret = cdns_mhdp_mailbox_send(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_READ, \ + sizeof(msg), msg); \ + if (ret < 0) \ + break; \ +\ + ret = cdns_mhdp_mailbox_recv_header(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_READ, \ + sizeof(resp)); \ + if (ret < 0) \ + break; \ +\ + ret = cdns_mhdp_mailbox_recv_data(_mhdp, resp, sizeof(resp)); \ + if (ret < 0) \ + break; \ +\ + /* Returned address value should be the same as requested */ \ + if (memcmp(msg, resp, sizeof(msg))) { \ + ret = -EINVAL; \ + break; \ + } \ +\ + *((u32 *)_value) = get_unaligned_be32(resp + 4); \ + ret = 0; \ + } while (0); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ + if (ret < 0) { \ + dev_err((_mhdp)->dev, "Failed to read register\n"); \ + *((u32 *)_value) = 0; \ + } \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_write(_mhdp, _addr, _val) \ +({ \ + u8 msg[8]; \ + int ret; \ +\ + put_unaligned_be32(_addr, msg); \ + put_unaligned_be32(_val, msg + 4); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + ret = cdns_mhdp_mailbox_send(_mhdp, MB_MODULE_ID_GENERAL, \ + GENERAL_REGISTER_WRITE, sizeof(msg), msg); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ +\ + ret; \ +}) + +#define cdns_mhdp_reg_write_bit(_mhdp, _addr, _start_bit, _bits_no, _val) \ +({ \ + u8 field[8]; \ + int ret; \ +\ + put_unaligned_be16(_addr, field); \ + field[2] = _start_bit; \ + field[3] = _bits_no; \ + put_unaligned_be32(_val, field + 4); \ +\ + mutex_lock(&(_mhdp)->mbox_mutex); \ +\ + ret = cdns_mhdp_mailbox_send((_mhdp), MB_MODULE_ID_DP_TX, \ + DPTX_WRITE_FIELD, sizeof(field), field); \ +\ + mutex_unlock(&(_mhdp)->mbox_mutex); \ +\ + ret; \ +}) + +#endif