From patchwork Fri Dec 22 22:50:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182793 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371274dyi; Fri, 22 Dec 2023 14:52:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1ajhhBmdfymNLevDkOm87NJY/x6pXTuR4YuADlY+SKms0sWJb7zIzbIIXcP7Ueq6/K+NN X-Received: by 2002:a05:622a:190c:b0:425:4043:8d50 with SMTP id w12-20020a05622a190c00b0042540438d50mr2608564qtc.107.1703285551986; Fri, 22 Dec 2023 14:52:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285551; cv=none; d=google.com; s=arc-20160816; b=CWooXpS+VSzPnpAfBJbarZXWg9rnrRaNm5SrN9/DKTIog4TjQcCCxJFIPGlXT/0cYm W+HA1Wjup87q4cBNhErri7QeiaIXBKD5oGDrmiQs9ojX5wO1vZzqitnK4hQARNpbJV52 R8X2phB1LqfVXyF8I0g9Em2v6AfKB06g70m9RUvBTUxZMiAk+SWyNsLHnIZeKyGMnIP7 QHNfkeQrkPTmhDZEGKj0+g1Ydf+h6obKkCe9QNZHVmvG4ACY6ZpdwJ9ES1yJVwATCAZq I81x53d6l57LlkDVKrWtS4upfLCIfwE8ZCrPXJU0N+91VUkdCFIwlH53ahhbPDFzVJ6e La6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=IRfgm6czYth1rKzdGje9RSuqEU2aVnXjXmQeqBvoKEo=; fh=pRhPfQLlVYfHlKr8jnvugZHZivgJvP42cwXk4G+Q8Nc=; b=SdGEr41PA+ahh0GPAy0SXSqanI4IK0iOkseoxCHWweJIOwpi3wIIjGSvADjqElHxvm sKz/bE3A9NMa1qO3MArczeFpo7XwDjVvaDlb2igKtRXILzCp/EVd2N0rOMGRtTod8Jek pdIcGqCUaR0WbD5jBF/06IBMVZObd95x0H+KX4NlYUALOnHHVINSz4qSVro0SwthNAml IurnJhu/PGzGr3wmjAmAWHBrLdrSQcKFSiN698VhLqIHKmTuAzoCk2lmICbXVUaUdS4g MdaHJkn0sE+NcD6EB+qVnIdsnddK9RUCkItoTnZd0/gZD7gK3aa+VqCpEUtcsq1hNtYZ ixmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10095-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10095-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id fg21-20020a05622a581500b004239e77fc70si5606457qtb.796.2023.12.22.14.52.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:52:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10095-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10095-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10095-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C5E291C22ABC for ; Fri, 22 Dec 2023 22:52:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4D643308C; Fri, 22 Dec 2023 22:51:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E812EAFD for ; Fri, 22 Dec 2023 22:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoML-0005aA-FC; Fri, 22 Dec 2023 23:51:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMJ-000qv5-VE; Fri, 22 Dec 2023 23:51:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMK-000FfG-39; Fri, 22 Dec 2023 23:51:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 04/13] irqchip/keystone: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:35 +0100 Message-ID: <4c852a3359aa06bedcf3a10f3fd8c1e008cc5a3a.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1968; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=+EDCUP6ePG/o+3slA3AQpIK7gkTvq8KdHgzdFcR2yug=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhK7wEMzZpDvgUxYeqw07y4uj4q89h2lKndDj gIK7Plj5u2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSuwAKCRCPgPtYfRL+ Tql4CACibtjb7MoMPwK/QFusOJrRV/PTZB0AK1KY73AwyE6W0xfcGAHQMsdXhy6e71UZL6JpVr/ P920+t1qHobfHNZHgpZMFLOiRlIEHWJ4KVpEUuNxHSUa9zQzNpPZLpKwmgnhSlXTzT6+XU/tmXj HQCLEVFfT0v9XcYCiJ57oFu1dFDXsOXr0yVzztk8s6WKL8j2Hr1MrRFki+WTWN/Lo8MPGOrPHG0 nL7V4RHDcGysnieTH3mg7tEdoyOfir/aPgFD8bIDR1GwXf4NLgXhahVBXdH+MTBdQdLr8nG/8nL 8dmlDQ9FhM9/o6EzydOvIOwWginPpiCLxDr7j06R6z48wDUp X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024350819477979 X-GMAIL-MSGID: 1786024350819477979 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c index a36396db4b08..30f1979fa124 100644 --- a/drivers/irqchip/irq-keystone.c +++ b/drivers/irqchip/irq-keystone.c @@ -190,7 +190,7 @@ static int keystone_irq_probe(struct platform_device *pdev) return 0; } -static int keystone_irq_remove(struct platform_device *pdev) +static void keystone_irq_remove(struct platform_device *pdev) { struct keystone_irq_device *kirq = platform_get_drvdata(pdev); int hwirq; @@ -201,7 +201,6 @@ static int keystone_irq_remove(struct platform_device *pdev) irq_dispose_mapping(irq_find_mapping(kirq->irqd, hwirq)); irq_domain_remove(kirq->irqd); - return 0; } static const struct of_device_id keystone_irq_dt_ids[] = { @@ -212,7 +211,7 @@ MODULE_DEVICE_TABLE(of, keystone_irq_dt_ids); static struct platform_driver keystone_irq_device_driver = { .probe = keystone_irq_probe, - .remove = keystone_irq_remove, + .remove_new = keystone_irq_remove, .driver = { .name = "keystone_irq", .of_match_table = of_match_ptr(keystone_irq_dt_ids),