[04/10,next] scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmapraw
Message ID | 4c2277b8aa3de8600c807ff8c995635f414161f9.1687974498.git.gustavoars@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9122380vqr; Wed, 28 Jun 2023 11:21:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6x7tdaCBHXxaPdCtAOp7jgbWw5ax9QqaCAQS6mFb6inL+LsvBS5tZ6Ir2OMUaieKk1EyI4 X-Received: by 2002:a17:906:74cd:b0:987:f332:5329 with SMTP id z13-20020a17090674cd00b00987f3325329mr22983574ejl.1.1687976489457; Wed, 28 Jun 2023 11:21:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687976489; cv=none; d=google.com; s=arc-20160816; b=tUv/kAhmVYTRsmNvHLtOI6DuSZ+r4+eyLp6CanjY+9pA59j3a6ukb730my61a+SIxx DIiZbzmO8gZyVwTM/PyI/Y/GaigDWu6D8E2/+490QItdV/eZHaZ/GSUREB6vQdyjfukX LnlYe+SlhsfFuUPgS7lJfjzfz1uQV6R18lA8FLM+b8KRyq0bm1k2P752/ruKUElu5qsG Dw5i455oYhWLAW+ZokDKtaRitokxeoQ2FhV83gkOMkxoxo1wupDnEpUbPHaONbFVkMIl 4+Sz6RblcBJ20GjXOg+R4rcBa+g3RILMWudm8m9KQFRrs1kjRpnHf7/dlnPyeCOI1Kiq C6yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZopqdX0YNL6QSXcmzByIH6cEEYrnRae1/zMV2jdCalg=; fh=2ET6nL/wlcZ4gumDTTusm6ilw662ytnheFDwMTsLDv4=; b=IFNz9SUvplzIkc0y7H2s/WI/nz6VMCgREqoqs8vy/7mieUttK4fh9VI4Eu9gY07PQr FaXYvMR8UDPzC5cd9aWJhSZZYD0bdau96PPF0rBCOiURVSNFd/DeRyIxnypBGWgAcRga qN6taTJOWndZGQOYZ4LT9J4p62Dh5/dmyZIBrHP+RahfBF7cTkGZzZXruOtW81qZVu65 7zSZ8nCTHhMtJtzZpVK5xHSJRN0OGD2q263IchJ1Z1HzdmmYy56KOMdOFIGrxMvVLWyh RbEaMcTrXBtogWzLBVUekkDpcVEq6G5Bead/0Pib3/khmXAgnqt69d2FImAe+MGiL4F0 E1cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RmuxOHe4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a170906081100b0096f53f61cc8si5832550ejd.967.2023.06.28.11.21.03; Wed, 28 Jun 2023 11:21:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RmuxOHe4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232099AbjF1Rz0 (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Wed, 28 Jun 2023 13:55:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbjF1Ryz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Jun 2023 13:54:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C3A42681; Wed, 28 Jun 2023 10:54:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2247E6139D; Wed, 28 Jun 2023 17:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B536BC433C0; Wed, 28 Jun 2023 17:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687974893; bh=plV4nM9kY1seEi2E6G5RifIXmBYxufGUPbUvfxDlnUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RmuxOHe4Dp8GBzik4q7A9/cuR8XTkx2C/8mmbApEAIa5ixksWpREBzzySrOS0TJ/o C0w3iZlSmyxGeZ6dKYfAVMGNoAiDsv515TZsDLeO69ZrB0onpnXLkBBl7RcenAcuri +FuXQLbEHdWN5WqE54VrsCAz/5C7+xbFSekpCyD+2Xx8qNQE8Guc3AY6JRLwj07BW2 gy4Z5u8Az8XYuVEmSmlSwCsGQLn+ZFCpucxv0TlEF3AKvuM399EAb4TuYtGV8ZYhLE mov3A6XFmu1LUGwSsDlMzs1S1IpqXr5DFppJZjGAKEt0uAa2AYs5MIe+lk6lizC0pn tctk8Fk0j76bg== Date: Wed, 28 Jun 2023 11:55:47 -0600 From: "Gustavo A. R. Silva" <gustavoars@kernel.org> To: aacraid@microsemi.com, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, linux-hardening@vger.kernel.org Subject: [PATCH 04/10][next] scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmapraw Message-ID: <4c2277b8aa3de8600c807ff8c995635f414161f9.1687974498.git.gustavoars@kernel.org> References: <cover.1687974498.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1687974498.git.gustavoars@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769971635373009793?= X-GMAIL-MSGID: =?utf-8?q?1769971635373009793?= |
Series |
scsi: aacraid: Replace one-element arrays with flexible-array members
|
|
Commit Message
Gustavo A. R. Silva
June 28, 2023, 5:55 p.m. UTC
Replace one-element array with flexible-array member in struct
user_sgmapraw.
This results in no differences in binary output.
Issue found with the help of Coccinelle and audited and fixed,
manually.
Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/ClangBuiltLinux/linux/issues/1851
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Jun 28, 2023 at 11:55:47AM -0600, Gustavo A. R. Silva wrote: > Replace one-element array with flexible-array member in struct > user_sgmapraw. > > This results in no differences in binary output. Confirmed. > > Issue found with the help of Coccinelle and audited and fixed, > manually. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/ClangBuiltLinux/linux/issues/1851 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 2e1623344327..d1fc1ce2e36d 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -532,7 +532,7 @@ struct sgmapraw { struct user_sgmapraw { u32 count; - struct user_sgentryraw sg[1]; + struct user_sgentryraw sg[]; }; struct creation_info