From patchwork Wed Nov 29 13:36:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 171356 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp342618vqn; Wed, 29 Nov 2023 05:39:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHq3ldYhfNKqFPk/hamqEpuB2CwAwFoY91XRQ552K4fXy0Ekg6rCcOge/15B4jFTfIfty0O X-Received: by 2002:a17:902:cec1:b0:1cf:6d8c:c8f1 with SMTP id d1-20020a170902cec100b001cf6d8cc8f1mr20707186plg.46.1701265164500; Wed, 29 Nov 2023 05:39:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701265164; cv=none; d=google.com; s=arc-20160816; b=sYf8qxnZ5GEBbfag0A6vIkkul5j0M8IjOsHGYF9/insDfdcQWncMSGsWf1x7me0bVb n5pWb9NF+AxWmpLzuRak3GTyZ+SNH5EJtanfwSYLfSTQNJhACk0uqP5ufcINlc+4mxRs TjpOi69ZfuQDX4ZHYQjyTK4xETXp+YRVffZ+9KJA+PXuznC111lWAq/1aWIVxIxwEXlS udIdskXcZwL4lT+nS1gJz9KaadC2PeaeNxRPI5kHFBCDV1rMchTztQDo86kf9BU4Jylp 6l2O1ItCfC79pnpc8QBr/dEUlgL6rjvBKG2Gev2U9n7kE6Rj1Ul8w9IlgDG8L5K+4uih zBfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/GYMB58NC+vR0/tkbSs0/7b+6prdzZqOQqM9ppA5Ma8=; fh=7MtGe3Dn5wgXLQQm5DZb5OyhwmEFEEdRNCLYMJcP5yE=; b=LRCVSUKodpT6CN3LpL2vDUXNApEWBOuqnyLFEX+dAjtuxD30zJcfMt8n+FzE/j+fuG QQgJfFXivtq2IRtqKLSK4a1DeLZi1fxI+Fvz+clvleqXS+SLAKfLFMOWX37EAIfFmjxz z/lRrcE21YcItFgoTNN95d1rUG2SXOLW20Ep2gOoD76XbvufGv/zxn+aCBqS6QSmzkSp 5ds97XgBCGJRJoAnwyNontNmpo/48uHV4lpc2IDX76eB0QWFy5CP1vEQ3QVxqYyzYE+7 BDNq/0zFFEsZeJg0Ll6Vc2t4O2/wI8C4MadmGWGIyTv7oVZ/Fj7mv9K0VjqsM5aVpbEQ tbag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id e6-20020a170902d38600b001cfa8f0e365si11069282pld.305.2023.11.29.05.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 05:39:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id AFA7881EE500; Wed, 29 Nov 2023 05:39:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233111AbjK2NjH (ORCPT + 99 others); Wed, 29 Nov 2023 08:39:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230389AbjK2NjG (ORCPT ); Wed, 29 Nov 2023 08:39:06 -0500 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F8D3C1; Wed, 29 Nov 2023 05:39:12 -0800 (PST) Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 5.4.0) id 295bd8a3e4d37812; Wed, 29 Nov 2023 14:39:10 +0100 Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 5623E6685F2; Wed, 29 Nov 2023 14:39:10 +0100 (CET) From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Daniel Lezcano , Srinivas Pandruvada , Zhang Rui , Lukasz Luba Subject: [PATCH v3 1/2] thermal: trip: Drop a redundant check from thermal_zone_set_trip() Date: Wed, 29 Nov 2023 14:36:07 +0100 Message-ID: <4897451.31r3eYUQgx@kreacher> In-Reply-To: <12350772.O9o76ZdvQC@kreacher> References: <12350772.O9o76ZdvQC@kreacher> MIME-Version: 1.0 X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrudeihedghedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffqoffgrffnpdggtffipffknecuuegrihhlohhuthemucduhedtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpedftfgrfhgrvghlucflrdcuhgihshhotghkihdfuceorhhjfiesrhhjfiihshhotghkihdrnhgvtheqnecuggftrfgrthhtvghrnhepvdffueeitdfgvddtudegueejtdffteetgeefkeffvdeftddttdeuhfegfedvjefhnecukfhppeduleehrddufeeirdduledrleegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudelhedrudefiedrudelrdelgedphhgvlhhopehkrhgvrggthhgvrhdrlhhotggrlhhnvghtpdhmrghilhhfrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqedpnhgspghrtghpthhtohepiedprhgtphhtthhopehlihhnuhigqdhpmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghnihgvlhdrlhgviigtrghnoheslhhinhgrrhhordhorhhgpdhrtghpthhtohepshhrihhnihhvrghsrdhprghnughruhhvrggurgeslhhinhhugidrihhnthgv lhdrtghomhdprhgtphhtthhopehruhhirdiihhgrnhhgsehinhhtvghlrdgtohhmpdhrtghpthhtoheplhhukhgrshiirdhluhgsrgesrghrmhdrtghomh X-DCC--Metrics: v370.home.net.pl 1024; Body=6 Fuz1=6 Fuz2=6 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 05:39:16 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783905821345961547 X-GMAIL-MSGID: 1783905821345961547 From: Rafael J. Wysocki After recent changes in the thermal framework, a trip points array is required for registering a thermal zone that is not tripless, so the tz->trips pointer in thermal_zone_set_trip() is never NULL and the check involving it is redundant. Drop that check. No functional impact. Signed-off-by: Rafael J. Wysocki Reviewed-by: Lukasz Luba Acked-by: Daniel Lezcano --- v2 -> v3: Add the tag from Lukasz v1 -> v2: New patch --- drivers/thermal/thermal_trip.c | 3 --- 1 file changed, 3 deletions(-) Index: linux-pm/drivers/thermal/thermal_trip.c =================================================================== --- linux-pm.orig/drivers/thermal/thermal_trip.c +++ linux-pm/drivers/thermal/thermal_trip.c @@ -153,9 +153,6 @@ int thermal_zone_set_trip(struct thermal struct thermal_trip t; int ret; - if (!tz->ops->set_trip_temp && !tz->ops->set_trip_hyst && !tz->trips) - return -EINVAL; - ret = __thermal_zone_get_trip(tz, trip_id, &t); if (ret) return ret;