| Message ID | 483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp495881vqo;
Tue, 2 May 2023 03:19:56 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ52jAx+GAQO94RwmKXTn0QpVFNBvrt4WKObhgEon4P0t4bUbYxUYPMAw9/wy2fTyuZ7aADj
X-Received: by 2002:a05:6a21:3981:b0:f0:558b:8fbb with SMTP id
ad1-20020a056a21398100b000f0558b8fbbmr18184843pzc.34.1683022795859;
Tue, 02 May 2023 03:19:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1683022795; cv=none;
d=google.com; s=arc-20160816;
b=hoXISiJFpvLYvdCAXALkzXuiEfINc1RtJMS8HWQHMfOUqbNEuPRbwFLpsAVXLFu533
jC+YxKY91u8bufPlQPC2sykZ5pNdhVAr43ewgwIuQ5vU1k7HZdizNZxLlod1nTOlCTtV
1kaD9TpN2rtBUppUKocbEhGkZPjdIiTHSJmDBpyWShdhmqJuhMgiaS6TSJsqjFCEyplA
W/QrlHl+vff5wJvVeUvUpEtsFdfWftsHDixHriDDhaFCu+qosvMY1881ygw1Xn18iUz1
wDryhsG7rreiiRnfu0LCozonSezGGByB6e2bWOlm63yreXKXIihy1Xe/F9CBXS9c6uhu
mA+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=cQABdtxKoCiBh4Rk84Ypi9yRfFehc8bxfc9C8DJE7FM=;
b=0ssfKlObz/FdOAclsaOage+NXDpjiHXo7SiWqt1d4RkReH5Ox5QgdAu57NCQjGQK8c
PX1KvgoOAC1XhkMiqRAP+OMx0zbDqhAojBOHrYmLWvETDKg1ywd700SqVyl2FOSl12jt
lw9jKQQgKPBQQNeGPjTMw3Qd6HFGUbdg2zRwIwQM7V+YGwgrlefk7kvOIOn1Fal72J7f
2610K8ZIxRPZOvei9a0NwSn0gNw7cE5JJDt0GzQZxeHaMKTSIr7svQDfvuqTpjGFKGzE
mGu066H+b0FUOMlAhjm9UgUtaGB9/guUpcvj4Nhy2W45tvNHLbdPSC0q8A87NG6lARrW
Iwug==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
q19-20020a631f53000000b00518f82d7053si30824646pgm.493.2023.05.02.03.19.40;
Tue, 02 May 2023 03:19:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233120AbjEBKRX (ORCPT <rfc822;rbbytesnap@gmail.com> + 99 others);
Tue, 2 May 2023 06:17:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57074 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233582AbjEBKRS (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 2 May 2023 06:17:18 -0400
Received: from albert.telenet-ops.be (albert.telenet-ops.be
[IPv6:2a02:1800:110:4::f00:1a])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B1E35B8
for <linux-kernel@vger.kernel.org>;
Tue, 2 May 2023 03:17:12 -0700 (PDT)
Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:f07a:92a2:297:162b])
by albert.telenet-ops.be with bizsmtp
id rmHA290075FQxRj06mHAk0; Tue, 02 May 2023 12:17:10 +0200
Received: from rox.of.borg ([192.168.97.57])
by ramsan.of.borg with esmtp (Exim 4.95)
(envelope-from <geert@linux-m68k.org>)
id 1ptn4D-000ymZ-Vj;
Tue, 02 May 2023 12:17:10 +0200
Received: from geert by rox.of.borg with local (Exim 4.95)
(envelope-from <geert@linux-m68k.org>)
id 1ptn4H-00AtQA-WA;
Tue, 02 May 2023 12:17:10 +0200
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>
Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 2/2] Input: tests - modular KUnit tests should not depend on
KUNIT=y
Date: Tue, 2 May 2023 12:17:03 +0200
Message-Id:
<483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <cover.1683022164.git.geert+renesas@glider.be>
References: <cover.1683022164.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,
HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1764777311388995201?=
X-GMAIL-MSGID: =?utf-8?q?1764777311388995201?=
|
| Series |
Input: tests - miscellaneous fixes
|
|
Commit Message
Geert Uytterhoeven
May 2, 2023, 10:17 a.m. UTC
While KUnit tests that cannot be built as a loadable module must depend
on "KUNIT=y", this is not true for modular tests, where it adds an
unnecessary limitation.
Fix this by relaxing the dependency to "KUNIT".
Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/input/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hello Geert, I've only been Cc'ed in patch #2. Geert Uytterhoeven <geert+renesas@glider.be> writes: > While KUnit tests that cannot be built as a loadable module must depend > on "KUNIT=y", this is not true for modular tests, where it adds an > unnecessary limitation. > > Fix this by relaxing the dependency to "KUNIT". > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Javier, On Tue, May 2, 2023 at 1:19 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > I've only been Cc'ed in patch #2. Not really, you're in the To-header on the full series? https://lore.kernel.org/all/cover.1683022164.git.geert+renesas@glider.be > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > While KUnit tests that cannot be built as a loadable module must depend > > on "KUNIT=y", this is not true for modular tests, where it adds an > > unnecessary limitation. > > > > Fix this by relaxing the dependency to "KUNIT". > > > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks! Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Hi Javier, > > On Tue, May 2, 2023 at 1:19 PM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> I've only been Cc'ed in patch #2. > > Not really, you're in the To-header on the full series? > https://lore.kernel.org/all/cover.1683022164.git.geert+renesas@glider.be > Strange... I only got patch #2, neither patch #1 nor the cover letter. For patch #1 as well: Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Sorry for missing that bug and thanks a lot for fixing it!
On Tue, 2 May 2023 at 18:17, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > While KUnit tests that cannot be built as a loadable module must depend > on "KUNIT=y", this is not true for modular tests, where it adds an > unnecessary limitation. > > Fix this by relaxing the dependency to "KUNIT". > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Works here, thanks! Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > drivers/input/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig > index 735f90b74ee5ad44..3bdbd34314b3495a 100644 > --- a/drivers/input/Kconfig > +++ b/drivers/input/Kconfig > @@ -168,7 +168,7 @@ config INPUT_EVBUG > > config INPUT_KUNIT_TEST > tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS > - depends on INPUT && KUNIT=y > + depends on INPUT && KUNIT > default KUNIT_ALL_TESTS > help > Say Y here if you want to build the KUnit tests for the input > -- > 2.34.1 >
diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig index 735f90b74ee5ad44..3bdbd34314b3495a 100644 --- a/drivers/input/Kconfig +++ b/drivers/input/Kconfig @@ -168,7 +168,7 @@ config INPUT_EVBUG config INPUT_KUNIT_TEST tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS - depends on INPUT && KUNIT=y + depends on INPUT && KUNIT default KUNIT_ALL_TESTS help Say Y here if you want to build the KUnit tests for the input