From patchwork Fri Dec 22 22:50:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182791 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371178dyi; Fri, 22 Dec 2023 14:52:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/BbRza9mdsSzlJzxwVecXVB8GYyl58T2HmsvKRVX5H6vvZQ7bjKFKw0pKvpsAUq5P/V1L X-Received: by 2002:a17:902:e84d:b0:1d4:35b7:35f9 with SMTP id t13-20020a170902e84d00b001d435b735f9mr305325plg.34.1703285535884; Fri, 22 Dec 2023 14:52:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285535; cv=none; d=google.com; s=arc-20160816; b=JJFWkNgqkYVZ+K7oVFlQOFztdReRV4nqt01fn/CBXa5IwVYkA0DsCnnUH2Tv9x7m6l FxFQZ2YdWrJyykva39E17Pu6cG+Yxcwk9TccKpFYO0wyvJwayVi9UQvIv6fa6aBqcQ+g VWJGMZxM4LA95ktNyJMcOUD/yLsI2bICssMkylapewsvm1yZcXUoQIAnFh0HQZgB19Mq oM3vLkl887hsb90cPy9AyO7iqfK/GlLKYb+H5EUojcB35inq1lTxV2diqctdwe85ks40 4CIE1TsQjyLgdPEyXDbE6pWJs7xJGnD2YA+KewFUZyiL9stdsOzcIazQaIp6R5rNrrP5 8Y0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=fNzfWq1M39TgiT2+Dq9sRCypc7D7ktvH46WSe4JEnWU=; fh=pRhPfQLlVYfHlKr8jnvugZHZivgJvP42cwXk4G+Q8Nc=; b=OhX0IsV98ZDmVrvZNePL2V9AJMNW3Ms70CLKelVH8J1tIldsaYSVVhzxxkeUpaiXJU Pg/tkWphtqbqXHUvn+hBWzDry+YLRhEHcynS6iiJdJ3sw3e8664XlphPEZwCT3v0Tj3q mp7rHLuCJI+iAue5eSBjYjRz/1SCA8RRGBT1auNNrMwXUqQNOvWnM3nkV5XrtO8a7qMW l83YN6BQKvzIS53ADxdQLyFMjFEmKnfmiSHLNYNOycmeJb9M5r6Y+eSdFxVLqu7Haqzk JcKOwKSA31fMevwF6wgZSgPP0rUwUsnzzBrwOO99Gu4woaFCfLHYKRzpFF/T+rAFyqn2 OfBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10091-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10091-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d5-20020a170902728500b001d406f83496si3394448pll.398.2023.12.22.14.52.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:52:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10091-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10091-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10091-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9EC39B2101E for ; Fri, 22 Dec 2023 22:52:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1336231757; Fri, 22 Dec 2023 22:51:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA1E2EAFA for ; Fri, 22 Dec 2023 22:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMK-0005ZU-RX; Fri, 22 Dec 2023 23:51:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMJ-000quv-CD; Fri, 22 Dec 2023 23:51:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMK-000Ff4-1G; Fri, 22 Dec 2023 23:51:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 01/13] irqchip/imgpdc: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:32 +0100 Message-ID: <472fc6f6bcd54b73f8af206d079a80cb8744d0ca.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ikkg4JLsV23pZpK+eXaO/MNjdovcQlGL4kRwoXR9+eQ=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtQ2oR3rk4JSF9mdDfhk+6o3Y+ZUM7XqrHiNO2F7OyxE9 /SJdnZ1MhqzMDByMciKKbLYN67JtKqSi+xc++8yzCBWJpApDFycAjARh0L2f6pVXTPsjf3vRq78 p+1ab/Lj7GY5e+nkh3f1Uybzusz9GnX456zNSZ/uzZ1X5Bh4sq8mf9a5ktPlV0qdXh66VGqzhP2 6dPc7C21nPmm1xrUbe9dK+MTFsUyelS1zzDBgk96b5HW+yg45l5peTLTKYZ5+gpnZal2xjv2zx2 nqniUVk74b+dw4Z5n+PJl1bvh8Fctc9Zj/G1amROiFzys+InujQfKD/QbvGYExWXlhTh+W/Zy+v yP0Zte5A/3qF89VfZoZyXf80dzY3IPRUluKQ3fpHvd6aZD0gclp2SO3iZFMDzvmmpvZxme09cbW eUlLsZf+jl9jH/7EQtz9oePi/1lml3bHLD79zENFi9kRAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024334348064554 X-GMAIL-MSGID: 1786024334348064554 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-imgpdc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c index 5831be454673..be7451c52f3b 100644 --- a/drivers/irqchip/irq-imgpdc.c +++ b/drivers/irqchip/irq-imgpdc.c @@ -461,12 +461,11 @@ static int pdc_intc_probe(struct platform_device *pdev) return ret; } -static int pdc_intc_remove(struct platform_device *pdev) +static void pdc_intc_remove(struct platform_device *pdev) { struct pdc_intc_priv *priv = platform_get_drvdata(pdev); irq_domain_remove(priv->domain); - return 0; } static const struct of_device_id pdc_intc_match[] = { @@ -480,7 +479,7 @@ static struct platform_driver pdc_intc_driver = { .of_match_table = pdc_intc_match, }, .probe = pdc_intc_probe, - .remove = pdc_intc_remove, + .remove_new = pdc_intc_remove, }; static int __init pdc_intc_init(void)