From patchwork Fri Oct 21 10:33:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanjuate Brunostar X-Patchwork-Id: 6625 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp621837wrr; Fri, 21 Oct 2022 03:42:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5573IT4dfek+GuUg3/TNe8TG3+j9Yvd/YXSeSdxxSnj4kuj8OyugysPss14BlHNuB7KRmG X-Received: by 2002:a17:906:dac8:b0:741:545b:796a with SMTP id xi8-20020a170906dac800b00741545b796amr14605143ejb.240.1666348928210; Fri, 21 Oct 2022 03:42:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666348928; cv=none; d=google.com; s=arc-20160816; b=Vp4lNQYRPad4FUbNaHZzRAangO4qwPqhq3wrpok9TpHrbwxQg1yF24Qpr8sibfVSj2 MyaTfWL2VUpPC2rkaZoFsUZbbQL77rcmH+o7fcSGo8u3n+goc5HCYW5HzlHAEJcFyaXK Rvw3xGY1Ngi3ObkhTsM8RzVzkLWOM7T1DxOwliZv/AfenYkk1EvN+DU3Qpf9ZtBJSi7a OUb3mp060XQwRfR0h59A4IF1uT9JRU493fCA36HDnqGCaoSI4XfmE81Tjj1ZzqbT4tN6 mFUAKJ/ZWtzC+B3vH64DrF2KeR8ubSHWbrpLCazwAwIupCLVgsNnDD8CMNx0RICDfJ1t tmGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4maC1ewmpW31x1+/ZutwiTXSSsedpc4aQ1ME2Ogiqcg=; b=m6NW0nYYzkerVobK8m86hIWLSupgqmKMvycUNOGcyp+20TnMxYBUJo9PE8tLew8/cQ 73o9PksYC502nM0U6qtiT+oh1ve9f9rMrMF6J7U8WbWKGVuVskg0EHGgOGPWOxLzIdr8 Ekrz0FfuYmqy/G5/KFlA1MlZjIYwDeCbB2Lxrzc7qw+P13WPR3hWw+Kd0V6SQjU651AI NHa5I/NXF/yj7hjB9Zce0TMuHzl1a/I/B52jFWD3CEcuOXLzfuucRjxpjzOWPn99RZmO Oj406epV/KwyzOFIwzm218XsZtg/sPaiqroxM890KvpfZZgqPg4cuntcMOyxwgXmjiVj dpPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oXKd4wDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o7-20020a056402038700b00458bbd3a0d2si16972314edv.602.2022.10.21.03.41.43; Fri, 21 Oct 2022 03:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oXKd4wDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbiJUKd6 (ORCPT + 99 others); Fri, 21 Oct 2022 06:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiJUKdz (ORCPT ); Fri, 21 Oct 2022 06:33:55 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A4A825E083 for ; Fri, 21 Oct 2022 03:33:53 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id c22so3107526lja.6 for ; Fri, 21 Oct 2022 03:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4maC1ewmpW31x1+/ZutwiTXSSsedpc4aQ1ME2Ogiqcg=; b=oXKd4wDB4DD/B7gLaHv7Sl4KmCGo/s7JNBHPkGWeTn1KXyppLpoDNeyh81FZ/S+KBP iHnLMTZfX8VFAlqzAqRCa+qdkQASbBnPF/BxeE7Axd/8k2/8QkRl5RmrE2seoIDqtyYS NkhUtf092/lbBTYj1NbLpvEjvtuBgm/MtFqxJsr2jbesiph08v7Glk/k4bqludHQPoGC 6yrTdWsSohuuwLSzGFaw7V8UDNhl2DQbIAR6p86fnmmQgk3PcbNARsUdnWp3BvxJU7gP u9UDbwEGnzikWQg/QLSEN7GdlzlXFTAr6ranmxWm1ElSdAuK0cEEqIZucl9IuMNs2q13 /kDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4maC1ewmpW31x1+/ZutwiTXSSsedpc4aQ1ME2Ogiqcg=; b=x2Mh++Fc1G8ZvlW1QCNXhxOsJ93Xj86OUXPtzPUDE//gr/wjKGWOWmITivBX6J1KiQ 9+xalTu58MZAycNVK9XWKGTXtwSeo0wxpgFVQqzel13KSjjtMUUNcLhJXJNM/s8RK+8s ISBbPBsoxIZzaeGtK8RycvDLFSwWHBQsh/jR/y/MRYJIAtaiauoJQxnYFf0K0h30Wtv4 dd71m+4VL9nfoJQdUHnCp9CKa0TO/+vX7i77gh9eY4xxQgdvFdqPeBYDHG71ApT5FtHK GbXJ4xA5tmhggyeD+js4naE+qfa40PF7xKM/ZUYj6PvB73XZ1l9wQAPLlIaLu0IIYAIs txbg== X-Gm-Message-State: ACrzQf14McsS/lKBdTHuRXEM4hwvzXytIIkRZUJvrBRGwS/3wJAjvmgQ wawenwoKgPAEdmCbCkNV7iI= X-Received: by 2002:a2e:4c12:0:b0:26e:8e13:9378 with SMTP id z18-20020a2e4c12000000b0026e8e139378mr6358920lja.336.1666348431661; Fri, 21 Oct 2022 03:33:51 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id u12-20020ac258cc000000b00492d7a7b4e3sm3119775lfo.4.2022.10.21.03.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 03:33:51 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH v2 1/6] staging: vt6655: fix lines ending in a '(' Date: Fri, 21 Oct 2022 10:33:05 +0000 Message-Id: <46a2791fc89f4dc299162418ab304ab821e494fa.1666347511.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747293493555304681?= X-GMAIL-MSGID: =?utf-8?q?1747293493555304681?= fix serveral checkpatch errors related to lines ending with a '(' by refactoring the code lines Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 149 ++++++++++++++-------------------- 1 file changed, 63 insertions(+), 86 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 1e5036121665..f9d0b00d7cff 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate) */ static unsigned int -s_uGetTxRsvTime( - struct vnt_private *pDevice, - unsigned char byPktType, - unsigned int cbFrameLength, - unsigned short wRate, - bool bNeedAck -) +s_uGetTxRsvTime(struct vnt_private *pDevice, + unsigned char byPktType, + unsigned int cbFrameLength, + unsigned short wRate, + bool bNeedAck) { unsigned int uDataTime, uAckTime; @@ -215,19 +213,16 @@ static __le16 get_rtscts_time(struct vnt_private *priv, /* byFreqType 0: 5GHz, 1:2.4Ghz */ static -unsigned int -s_uGetDataDuration( - struct vnt_private *pDevice, - unsigned char byDurType, - unsigned int cbFrameLength, - unsigned char byPktType, - unsigned short wRate, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption -) +unsigned int s_uGetDataDuration(struct vnt_private *pDevice, + unsigned char byDurType, + unsigned int cbFrameLength, + unsigned char byPktType, + unsigned short wRate, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption) { bool bLastFrag = false; unsigned int uAckTime = 0, uNextPktTime = 0, len; @@ -316,17 +311,13 @@ s_uGetDataDuration( } /* byFreqType: 0=>5GHZ 1=>2.4GHZ */ -static -__le16 -s_uGetRTSCTSDuration( - struct vnt_private *pDevice, - unsigned char byDurType, - unsigned int cbFrameLength, - unsigned char byPktType, - unsigned short wRate, - bool bNeedAck, - unsigned char byFBOption -) +static __le16 s_uGetRTSCTSDuration(struct vnt_private *pDevice, + unsigned char byDurType, + unsigned int cbFrameLength, + unsigned char byPktType, + unsigned short wRate, + bool bNeedAck, + unsigned char byFBOption) { unsigned int uCTSTime = 0, uDurTime = 0; @@ -409,22 +400,18 @@ s_uGetRTSCTSDuration( return cpu_to_le16((u16)uDurTime); } -static -__le16 -s_uFillDataHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pTxDataHead, - unsigned int cbFrameLength, - unsigned int uDMAIdx, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption, - unsigned short wCurrentRate, - bool is_pspoll -) +static __le16 s_uFillDataHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pTxDataHead, + unsigned int cbFrameLength, + unsigned int uDMAIdx, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption, + unsigned short wCurrentRate, + bool is_pspoll) { struct vnt_tx_datahead_ab *buf = pTxDataHead; @@ -555,19 +542,15 @@ s_uFillDataHead( return buf->duration; } -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void s_vFillRTSHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen = 20; @@ -752,17 +735,15 @@ s_vFillRTSHead( static void -s_vFillCTSHead( - struct vnt_private *pDevice, - unsigned int uDMAIdx, - unsigned char byPktType, - void *pvCTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - unsigned short wCurrentRate, - unsigned char byFBOption -) +s_vFillCTSHead(struct vnt_private *pDevice, + unsigned int uDMAIdx, + unsigned char byPktType, + void *pvCTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uCTSFrameLen = 14; @@ -868,21 +849,17 @@ s_vFillCTSHead( - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -) +static void s_vGenerateTxParameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *tx_buffer_head, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate) { u16 fifo_ctl = le16_to_cpu(tx_buffer_head->fifo_ctl); bool bDisCRC = false;