From patchwork Wed Dec 27 21:02:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183560 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1665981dyb; Wed, 27 Dec 2023 13:04:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcz3mr4Y7ObQRxoz/vy+3hNBtdAAldb2QzHlclnnrv7VPr4RodRTeu+TqT1hPbd/l8XiOi X-Received: by 2002:a05:6102:4704:b0:467:2aa9:83be with SMTP id ei4-20020a056102470400b004672aa983bemr1165587vsb.19.1703711064108; Wed, 27 Dec 2023 13:04:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711064; cv=none; d=google.com; s=arc-20160816; b=RoHcpLsYlxwk+bAjMWgJuBy8RZoYl8vsIUNc14RFwArglEmzifRi3YkDmwY5r0lA/v KeXPL5Ok63KQt9IPMDQ8e3MkVQbYE+GhTtZEuco4SkiNg7zr//I5v9YXMKewDQZkODsg xm0S3Dos8WEEoMzSfot/Y5lk+JBMrB8W+Gvh4a3dOpKC8ApyREOx4Jnq9eYbOgLmEGiM v8QmqkK1Q1dPYM9M2C8TN9FTrz2bxmcplXtRsKLkbQxHXQx2NwubRaGM24FZ2usl7MWQ ySiRW0wjzk5p7T/iwDmzQxomGf99Djiy8waicnfyfqzNOYVBkbXhW9nuM8T9u8sICwhQ 8kTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=gnOvMUG7ElqmexHtlC83aYMX/sHRc/KbJXc0tiD4u0g=; fh=9apTFCoTOjehv4Wznv2mb2xpDvZrq4o37EMnyVq2a9A=; b=T1cRp2KhniXIJ54W9y4FsiMkFTsEqhwWSeLy2lN3+jRkl5/FqES8HMK5UHl9EamOun zyblPFV2Aaufi8c6aJBl3yAEsR6LjdLHWzFHY1slyS/ncTDIuPyrUqz8z+W+d6ZBKKqX go5GCmSB455sGWSnWFE56I1wDI5B7ivAoP3uEgpMJwoJSOUQ3hNlHvOoHlsYiO4Emfjx EavoMzIRB5AvQI/xtJXm6uq58fdM/5B7/rTfF76Wak2xVwDhSgLN9rzL6/GL4+AIrsQs qgVCCnKcRmwGtaTNB3Lyu8PO1c5J+OYEX3ZuUTUBWUEgqiQ5hukF9o+FrIhUWFmr4mbn Uy6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12263-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12263-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id jn19-20020a05610219d300b0046705547387si762061vsb.657.2023.12.27.13.04.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12263-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12263-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12263-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DA56B1C226CB for ; Wed, 27 Dec 2023 21:04:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A5492498B7; Wed, 27 Dec 2023 21:03:04 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 950A047F7B for ; Wed, 27 Dec 2023 21:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3K-0000qs-Ib; Wed, 27 Dec 2023 22:02:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3J-001wF4-0r; Wed, 27 Dec 2023 22:02:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3K-001ZVc-08; Wed, 27 Dec 2023 22:02:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 06/12] mailbox: omap: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:34 +0100 Message-ID: <466062f1ff1438a22f79260f529a1c2cc233a150.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1656; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=j0aEwW5V8+ktwBY7iIhfiCa+CFqdltoLToqYeqCXqXY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDsFhgpgYrjS7XbMKMaLE98yrtDfwKEB3n+Q RZes6RQi4GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ7AAKCRCPgPtYfRL+ Thh1B/wPx0HuQZFnGjuuBLvOPrEQwVIO3XWlHql/3OUqpVyaTHqSr9XxEJAM/xYz1+NEPKr0rpb QsPcpQVRd8C6cLnAKwcbsnBkVBxf2w4r+9bNnSPShf1odyY0+oF4Ifz/VwdPQLe7DihdRiaWqQS QtTH85MbKOjcGE/1+Fh/M++/dtBtHGW3aJsUAFHCJZAhwRdJBBSBAT6NYVJHgBuD746NLVnnwZb ifijaU2zEYJBWSnJRlOgEIcA94rNIx7WdUkF4ex72eRJG63SMrovOSgqrgkczx9BxIKSGJRIMKs UmK7PW8zUu2S8TxwerNew41UPZtFCcBY3Lbz26L0uszRl5Ck X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470533027742676 X-GMAIL-MSGID: 1786470533027742676 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/omap-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c index 792bcaebbc9b..c961706fe61d 100644 --- a/drivers/mailbox/omap-mailbox.c +++ b/drivers/mailbox/omap-mailbox.c @@ -865,19 +865,17 @@ static int omap_mbox_probe(struct platform_device *pdev) return ret; } -static int omap_mbox_remove(struct platform_device *pdev) +static void omap_mbox_remove(struct platform_device *pdev) { struct omap_mbox_device *mdev = platform_get_drvdata(pdev); pm_runtime_disable(mdev->dev); omap_mbox_unregister(mdev); - - return 0; } static struct platform_driver omap_mbox_driver = { .probe = omap_mbox_probe, - .remove = omap_mbox_remove, + .remove_new = omap_mbox_remove, .driver = { .name = "omap-mailbox", .pm = &omap_mbox_pm_ops,