Message ID | 455b22b986de4d3bc6d9bfd522378e442943de5f.1687499411.git.baruch@tkos.co.il |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5564204vqr; Thu, 22 Jun 2023 23:18:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hP0XMhbhjjBEUxYEbtJD6ALFX0jCQEzK+BE72FsekiBl4Pw6oOrjZQeUjryWgHzCmnvBi X-Received: by 2002:a05:6a00:1595:b0:66a:5d4a:e47d with SMTP id u21-20020a056a00159500b0066a5d4ae47dmr4190956pfk.8.1687501111690; Thu, 22 Jun 2023 23:18:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687501111; cv=none; d=google.com; s=arc-20160816; b=y/OJTBGCs+V2ZMm5lY4zkdaB0CT1I+tMqB6oLVU4bBdTlFfdCdT1+ivC+t9lReNwwX 6RYtJzPZ5/BolZYvaUNIt5imyawqa+FGEZ6W8MqbErwM3qZ2id4Q9oXpWunGvB1/ac1Z f3FPcc6BuxbOYIJB7LUevkT0B5H5Mqrd2aaP4npnCFSZrMjlO1i1O4a6PFgr5NiR3kie XqMZ9eNnxFUO+ZQPXbD2qg3cM0V3y4DwL3Z5kHSnFHxT4uarjf86+cvQ2n+t8J1OJPEg WdmVS8M56JuMLhA0Xk9CazwB4LyUAOIAhPlbDr5ZZc1h5mCqHBhoHnuTteDJn0lO3MuW S3vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FO6/7JiPlqoDvwRmvK8AoFxBqUIrLxvNz+HdcKMa9/g=; b=0zrSw+d4XVIWuUWJMNYZnxzxbyID1mdcQcK/MlilLTLCG0lLTUC3eSSSyZ4fg4DqmM y+b2QWkqdBE2eCm8US5UH5zEGbn5SR0n8UBqtaFFL7SN7lxEgyKLc959ctsftLZyOziV wT9GsywSTB7l023STakDVx2E4gV87wbmXyvdbNe8WMZWb/HerC3/1aibHwrWk2rqJoLm r/e/dDbZaF3g0phuEMdAU3Qt2/cgnZxC9ZFp+TNVPqAntMEFHDmAXPV0gv407AnDd+pK +EJgCr09a4xBKOetjpgaT1F4eVRBqPrHbJNqKatptaro5dz0UQI5Mufp776EZmOpiPIO AqDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tkos.co.il header.s=default header.b=jpenR1P2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tkos.co.il Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a056a001d8d00b006562b3c3c33si3089701pfw.78.2023.06.22.23.18.18; Thu, 22 Jun 2023 23:18:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tkos.co.il header.s=default header.b=jpenR1P2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tkos.co.il Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231181AbjFWFvL (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Fri, 23 Jun 2023 01:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbjFWFuw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 23 Jun 2023 01:50:52 -0400 Received: from mail.tkos.co.il (wiki.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5517D1B4 for <linux-kernel@vger.kernel.org>; Thu, 22 Jun 2023 22:50:51 -0700 (PDT) Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 4348E440537; Fri, 23 Jun 2023 08:50:45 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1687499445; bh=9jEJgdq2Xd4QhhL1CN6tgeLdCWprH78WEI6H8wMuOog=; h=From:To:Cc:Subject:Date:From; b=jpenR1P21YYDhPHwWhHqO6KTBhbbkvbIUWzIfneujr9FMoUHiS5eouw18NwK5Yp/Q pN75u1z0+7O47PSpUOHEzHZKet4OU+AMm89sFitD4Xhn56RKHySaf8lAnYD5t8gQGx IgJq1MCoK5bMTdIkzLa4ZI/HzitMAm4u5FdZFG+XZq/z0KDA9pOrx5RgYsc0cQAqq9 OBdyyn+HvfvpmVqJdnm6veOwnpRd5JlidBGjt/HILHODeFJQfS4BVbRlF5Kefn7iOe 7d8OINSAQ6vEwmtm8b4PYzKluBL/69kWYM0xkFnAKn/bgxIHwvMuZxtB77FKTavsMc GGSzLr4TOdQ1A== From: Baruch Siach <baruch@tkos.co.il> To: Eric Biederman <ebiederm@xmission.com>, Kees Cook <keescook@chromium.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baruch Siach <baruch@tkos.co.il> Subject: [PATCH v2] elf: correct note name comment Date: Fri, 23 Jun 2023 08:50:11 +0300 Message-Id: <455b22b986de4d3bc6d9bfd522378e442943de5f.1687499411.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769473165622026303?= X-GMAIL-MSGID: =?utf-8?q?1769473165622026303?= |
Series |
[v2] elf: correct note name comment
|
|
Commit Message
Baruch Siach
June 23, 2023, 5:50 a.m. UTC
NT_PRFPREG note is named "CORE". Correct the comment accordingly.
Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2: Swap "CORE" and "LINUX" as noted by Kees
---
include/uapi/linux/elf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote: > NT_PRFPREG note is named "CORE". Correct the comment accordingly. > > Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support") > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > > v2: Swap "CORE" and "LINUX" as noted by Kees > --- > include/uapi/linux/elf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h > index ac3da855fb19..4d1c8d46e7f0 100644 > --- include/uapi/linux/elf.h > +++ include/uapi/linux/elf.h Hi, I took this patch, but it seems something is misconfigured on your end for patch generation -- normally I'd expect to need "-p1", not "-p0" to apply patches. Are you using "git format-patch" to produce these patches?
Hi Kees, On Fri, Jun 23 2023, Kees Cook wrote: > On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote: >> NT_PRFPREG note is named "CORE". Correct the comment accordingly. >> >> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support") >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> --- >> >> v2: Swap "CORE" and "LINUX" as noted by Kees >> --- >> include/uapi/linux/elf.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h >> index ac3da855fb19..4d1c8d46e7f0 100644 >> --- include/uapi/linux/elf.h >> +++ include/uapi/linux/elf.h > > Hi, I took this patch, but it seems something is misconfigured on your > end for patch generation -- normally I'd expect to need "-p1", not "-p0" > to apply patches. Are you using "git format-patch" to produce these > patches? I recently enabled diff.noprefix for easier copying of file names from git-diff output. I have now noticed the git-format-patch is also affected, and that it breaks the default git-am -p1. So I have reverted diff.noprefix to its default. Sorry for the inconvenience, and thanks for letting me know. baruch
diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h index ac3da855fb19..4d1c8d46e7f0 100644 --- include/uapi/linux/elf.h +++ include/uapi/linux/elf.h @@ -372,7 +372,8 @@ typedef struct elf64_shdr { * Notes used in ET_CORE. Architectures export some of the arch register sets * using the corresponding note types via the PTRACE_GETREGSET and * PTRACE_SETREGSET requests. - * The note name for all these is "LINUX". + * The note name for these types is "LINUX", except NT_PRFPREG that is named + * "CORE". */ #define NT_PRSTATUS 1 #define NT_PRFPREG 2