From patchwork Wed Dec 27 21:02:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183561 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666047dyb; Wed, 27 Dec 2023 13:04:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZ24emZFgdKmpluKPXLwgXQ819Aml1rTGkM/Jj2BW4tL/017LmTD1BhxtkS6N4Xfsm1FRw X-Received: by 2002:a17:903:2344:b0:1cc:43af:f568 with SMTP id c4-20020a170903234400b001cc43aff568mr9875644plh.6.1703711072956; Wed, 27 Dec 2023 13:04:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711072; cv=none; d=google.com; s=arc-20160816; b=z31ckfQGPWxyBhvLRSoOPjGZH+xUqzJrlac8B7SX8GS3miRW404hiYDOa1ljGaPFd8 Gwdp5JZBUOdntQZ9O4MohToT4baqrBqnSVm9U1YCSRmt3m6Vhb0Zq5awseNHLsjKgE7v IksDqSSR8tzt0ylzy/sO9/iUQrTwBMVezefi/lfm6tGQ+LnVig2bb9rssty+iZsmqhf8 J7PHIPSMdevB/1YHGvofqdkXfplnIIIdrq0ys2OFJKG0jhELUekzezMWS6XiliH/ZaX6 6u6j4IhvT6FiDXxyfZp0seM/rKroqVLIolvHmvWhB0/n2ZscARD9vnrOf8XJxQwp/XXh jopQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=VxQVfVniJXSlLdT1ccceUQpoauyNN4Vc69mlNk2EhJw=; fh=9apTFCoTOjehv4Wznv2mb2xpDvZrq4o37EMnyVq2a9A=; b=FDAqOhYcoglxNwg2jbgZ0rQFpTLtnKQaJrzhR1g/pUjYMC21pzr0zYv4LwT2g56yYD dE/dP8ADZ4iaSjT8LRJhmkGc/wwhR7xDGh/BL8W+ANfnoM9x3FODnrWCcB7L+CiilquI 5do+s7W1A7rmMTQSXFA5HokTopIK3uW38b2vkx0cgC2xUdpxKs5s3GNgTRoAHtnx7SGt 6vZafMUWYr4tFtnaICxFpV+kt4RvJHkg8Z4Roj6Y/5Qd9lqS0gDOmYxXuSGWx6Y89J6X v8iDPWN244Ca0ATWZw+oIOPDiFaM2DkBv0s6WF8X4KoZuu8CXrBE+8jfOBh0G7l2m4Aa utnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12261-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12261-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id a23-20020a170902b59700b001d3ed5570e6si11657049pls.531.2023.12.27.13.04.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12261-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12261-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12261-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6A796B2291D for ; Wed, 27 Dec 2023 21:04:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 187A2495FA; Wed, 27 Dec 2023 21:03:04 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5684B47F78 for ; Wed, 27 Dec 2023 21:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3J-0000mE-6J; Wed, 27 Dec 2023 22:02:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3H-001wEo-Md; Wed, 27 Dec 2023 22:02:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3I-001ZVM-2I; Wed, 27 Dec 2023 22:02:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 02/12] mailbox: bcm-pdc: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:30 +0100 Message-ID: <44de4bb380b6af0be33eaf8cf96d767ed7608a36.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1741; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=jveChMb3h44uByjcawnGUpyLJqMmp76ass0nnH1hY1A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDn9BM0ryFt/JmZOCM418wpd3Zmu3v/321/P Jf/1Sq+17qJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ5wAKCRCPgPtYfRL+ TnbMB/4+AiEoxUh4Rj3VweDs+RMtUOGfU48l2YhH2whN8mjFzIAIUrGWD1FPU1pWsVgejCeGcur ++/ur4Y+cw1CSQX1UXjG4Bh6GtrMxxHxX9c/j0ElXYRi3MkKKZDL7j60owkY2jJiTOZo86hMLie osli7TD/G2Wc9455gUr+hYc2xeMT5i/ZpHCakvPGNXDQ9tb+42b3h9qyWzsmcvyKgW8Xk10+yB4 4ccmNxkf6rg7U/kZnsZM6sxNiGryMiNuqdUlgq3XMwtSkJBAiwjbAV98aZTPFK8aL+yU/3dAOvs n/KCoRFLdmXgVVqQMxv/hI2lED7vfaXec4jFRRa3dGLaJX39 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470542009160949 X-GMAIL-MSGID: 1786470542009160949 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/bcm-pdc-mailbox.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c index 778faeced81e..1768d3d5aaa0 100644 --- a/drivers/mailbox/bcm-pdc-mailbox.c +++ b/drivers/mailbox/bcm-pdc-mailbox.c @@ -1605,7 +1605,7 @@ static int pdc_probe(struct platform_device *pdev) return err; } -static int pdc_remove(struct platform_device *pdev) +static void pdc_remove(struct platform_device *pdev) { struct pdc_state *pdcs = platform_get_drvdata(pdev); @@ -1617,12 +1617,11 @@ static int pdc_remove(struct platform_device *pdev) dma_pool_destroy(pdcs->rx_buf_pool); dma_pool_destroy(pdcs->ring_pool); - return 0; } static struct platform_driver pdc_mbox_driver = { .probe = pdc_probe, - .remove = pdc_remove, + .remove_new = pdc_remove, .driver = { .name = "brcm-iproc-pdc-mbox", .of_match_table = pdc_mbox_of_match,