diff mbox series

[v5,02/12] dt-bindings: net: mediatek,net: add mt7981-eth binding

Message ID 43d5e9cbf0e75ea2c039ffc632aa5cc5c83a3c33.1676128246.git.daniel@makrotopia.org
State New
Headers
Series net: ethernet: mtk_eth_soc: various enhancements |

Commit Message

Daniel Golle Feb. 11, 2023, 4:02 p.m. UTC 
  Introduce DT bindings for the MT7981 SoC to mediatek,net.yaml.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
 .../devicetree/bindings/net/mediatek,net.yaml | 43 ++++++++++++++++++-
 1 file changed, 41 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Feb. 13, 2023, 9:14 a.m. UTC | #1 
On 11/02/2023 17:02, Daniel Golle wrote:
> Introduce DT bindings for the MT7981 SoC to mediatek,net.yaml.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---

Confusing diff but in general looks ok except:

> +
> +        mediatek,wed-pcie: true

This is now anything. I propose to cleanup the bindings first, before
adding new compatible.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 7ef696204c5a..76a46a7b8228 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -21,6 +21,7 @@  properties:
       - mediatek,mt7623-eth
       - mediatek,mt7622-eth
       - mediatek,mt7629-eth
+      - mediatek,mt7981-eth
       - mediatek,mt7986-eth
       - ralink,rt5350-eth
 
@@ -210,7 +211,7 @@  allOf:
       properties:
         compatible:
           contains:
-            const: mediatek,mt7986-eth
+            const: mediatek,mt7981-eth
     then:
       properties:
         interrupts:
@@ -225,8 +226,8 @@  allOf:
             - const: fe
             - const: gp2
             - const: gp1
-            - const: wocpu1
             - const: wocpu0
+            - const: sgmii_ck
             - const: sgmii_tx250m
             - const: sgmii_rx250m
             - const: sgmii_cdr_ref
@@ -247,6 +248,44 @@  allOf:
           description:
             Phandle to the mediatek wed-pcie controller.
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mediatek,mt7986-eth
+    then:
+      properties:
+        interrupts:
+          minItems: 4
+
+        clocks:
+          minItems: 15
+          maxItems: 15
+
+        clock-names:
+          items:
+            - const: fe
+            - const: gp2
+            - const: gp1
+            - const: wocpu1
+            - const: wocpu0
+            - const: sgmii_tx250m
+            - const: sgmii_rx250m
+            - const: sgmii_cdr_ref
+            - const: sgmii_cdr_fb
+            - const: sgmii2_tx250m
+            - const: sgmii2_rx250m
+            - const: sgmii2_cdr_ref
+            - const: sgmii2_cdr_fb
+            - const: netsys0
+            - const: netsys1
+
+        mediatek,sgmiisys:
+          minItems: 2
+          maxItems: 2
+
+        mediatek,wed-pcie: true
+
 patternProperties:
   "^mac@[0-1]$":
     type: object