diff mbox series

[12/30] input: Use kstrtobool() instead of strtobool()

Message ID	4311e9cb62687449f4175e2b062abcd77aada059.1667336095.git.christophe.jaillet@wanadoo.fr
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, linux-input@vger.kernel.org Subject: [PATCH 12/30] input: Use kstrtobool() instead of strtobool() Date: Tue, 1 Nov 2022 22:14:00 +0100 Message-Id: <4311e9cb62687449f4175e2b062abcd77aada059.1667336095.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> References: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Remove strtobool() \| [00/30] Remove strtobool() [01/30] net: usb: Use kstrtobool() instead of strtobool() [02/30] wifi: Use kstrtobool() instead of strtobool() [03/30] irqchip: Use kstrtobool() instead of strtobool() [04/30] scsi: target: Use kstrtobool() instead of strtobool() [05/30] nvdimm: Use kstrtobool() instead of strtobool() [06/30] nvme: Use kstrtobool() instead of strtobool() [07/30] usb: core: Use kstrtobool() instead of strtobool() [08/30] usb: gadget: Use kstrtobool() instead of strtobool() [09/30] ACPI: sysfs: Use kstrtobool() instead of strtobool() [10/30] clocksource/drivers/arm_arch_timer: Use kstrtobool() instead of strtobool() [11/30] greybus: svc: Use kstrtobool() instead of strtobool() [12/30] input: Use kstrtobool() instead of strtobool() [13/30] platform/chrome: Use kstrtobool() instead of strtobool() [14/30] powercap: Use kstrtobool() instead of strtobool() [15/30] video: fbdev: omapfb: Use kstrtobool() instead of strtobool() [16/30] cifs: Use kstrtobool() instead of strtobool() [17/30] initramfs: Use kstrtobool() instead of strtobool() [18/30] module: Use kstrtobool() instead of strtobool() [19/30] kernel/params.c: Use kstrtobool() instead of strtobool() [20/30] mm/damon: Use kstrtobool() instead of strtobool() [21/30] mm: Use kstrtobool() instead of strtobool() [22/30] Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool() [23/30] test_firmware: Use kstrtobool() instead of strtobool() [24/30] arm64: cpufeature: Use kstrtobool() instead of strtobool() [25/30] KVM: arm64: vgic-v3: Use kstrtobool() instead of strtobool() [26/30] s390/ipl: Use kstrtobool() instead of strtobool() [27/30] KVM: x86/mmu: Use kstrtobool() instead of strtobool() [28/30] x86/xen: Use kstrtobool() instead of strtobool() [29/30] driver core: Use kstrtobool() instead of strtobool() [30/30] kstrtox: Remove strtobool()

Commit Message

Christophe JAILLET Nov. 1, 2022, 9:14 p.m. UTC

  strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is part of a serie that axes all usages of strtobool().
Each patch can be applied independently from the other ones.

The last patch of the serie removes the definition of strtobool().

You may not be in copy of the cover letter. So, if needed, it is available
at [1].

[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
 drivers/input/input.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dmitry Torokhov Nov. 3, 2022, 8:46 p.m. UTC | #1

On Tue, Nov 01, 2022 at 10:14:00PM +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
> 
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
> 
> While at it, include the corresponding header file (<linux/kstrtox.h>)
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Please feel free to merge with the rest of the series. Or let me know if
you want me to pick just this one through my tree.

Thanks.

Christophe JAILLET Nov. 3, 2022, 9:37 p.m. UTC | #2

Le 03/11/2022 à 21:46, Dmitry Torokhov a écrit :
> On Tue, Nov 01, 2022 at 10:14:00PM +0100, Christophe JAILLET wrote:
>> strtobool() is the same as kstrtobool().
>> However, the latter is more used within the kernel.
>>
>> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
>> the other function name.
>>
>> While at it, include the corresponding header file (<linux/kstrtox.h>)
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Please feel free to merge with the rest of the series. Or let me know if
> you want me to pick just this one through my tree.
> 
> Thanks.
> 

Hi,

the patch can go through your tree.
There is no plan to merge the whole serie at once, and some other 
maintainers have asked for some patches to be re-sent as individual patches.

CJ

Dmitry Torokhov Nov. 7, 2022, 7:40 p.m. UTC | #3

On Thu, Nov 03, 2022 at 10:37:19PM +0100, Christophe JAILLET wrote:
> Le 03/11/2022 à 21:46, Dmitry Torokhov a écrit :
> > On Tue, Nov 01, 2022 at 10:14:00PM +0100, Christophe JAILLET wrote:
> > > strtobool() is the same as kstrtobool().
> > > However, the latter is more used within the kernel.
> > > 
> > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> > > the other function name.
> > > 
> > > While at it, include the corresponding header file (<linux/kstrtox.h>)
> > > 
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > 
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > Please feel free to merge with the rest of the series. Or let me know if
> > you want me to pick just this one through my tree.
> > 
> > Thanks.
> > 
> 
> Hi,
> 
> the patch can go through your tree.
> There is no plan to merge the whole serie at once, and some other
> maintainers have asked for some patches to be re-sent as individual patches.

OK, applied, thank you.

diff mbox series

Patch

diff --git a/drivers/input/input.c b/drivers/input/input.c
index ebb2b7f0f8ff..783961df3626 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -21,6 +21,7 @@ 
 #include <linux/seq_file.h>
 #include <linux/poll.h>
 #include <linux/device.h>
+#include <linux/kstrtox.h>
 #include <linux/mutex.h>
 #include <linux/rcupdate.h>
 #include "input-compat.h"
@@ -1465,7 +1466,7 @@  static ssize_t inhibited_store(struct device *dev,
 	ssize_t rv;
 	bool inhibited;
 
-	if (strtobool(buf, &inhibited))
+	if (kstrtobool(buf, &inhibited))
 		return -EINVAL;
 
 	if (inhibited)