From patchwork Wed Apr 12 17:29:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 82610 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp499743vqo; Wed, 12 Apr 2023 10:41:36 -0700 (PDT) X-Google-Smtp-Source: AKy350bdrpmVpcRUPOEhTSgBXU/1H16kvYNT31F6+azDaA2sQKBXpRDysb1cZQUzhCuZQdGePVBq X-Received: by 2002:a05:6402:150c:b0:505:6556:88d with SMTP id f12-20020a056402150c00b005056556088dmr1381671edw.42.1681321296077; Wed, 12 Apr 2023 10:41:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681321296; cv=none; d=google.com; s=arc-20160816; b=LQOh8dJ4NEDsOV/5m/6hm6oDu2I4YJshT7WmC8mL+RnaiX2Yp8SOD74B+78yqpVIox tzX0gR7VA9WhsI1bX83U37O04UTo9DCVb45gi0XqukLYAHDTvAdgfg4+Zx1l/vBuTCa0 r8E+v+vAG0VbG8T3K+g+qsLHzx1tLaygGXE6Wxf22U6KOWEY3iuqWmSANMKptsvC0RxR txXidLJiue7GFxhRxpFmUtmYrZyrQiQvVOvcdSu7epYX0pd9iwJKhuIYS0nQ345fth0y RaLD7iAAlDkUG/VV7w19d8yusuzjwce8GScjd53S86jVbQSkdxry86BR+eBWt2Ncys9o 2+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ccXKNXlq5V3fBVOLexgCiwTKjGiXR2XV556pQ17ACj0=; b=VLr6+v7BOLHBXgKbevU+hPZ5PzxfqQgUhKdMDmxSjRHKWdFsK5Fbq14G9TswMNQrEh WrZ9+XoRrTId7C7TFPQQ/bhUJPdQ9Fy978Ju3OV6c4sgEmGnCFu2EIJ0RIRJns3aa37m 4ttsAwK0TL6A2zGTJ+yvHdsraETbH5cKgx3s/Yu9nbx5AwchzlnLz2mczun7cYiMoeEt +nrw+FMOZedfAC7V2HnNeajjbZjWMuxNE9WMQr9v+TB9mxw+IdxVu+dJ6TMTrqwO46tu 9b9yUK/dPXxqRNf+uLvqYFQufZFUs6mnxFD2DaZ8NuVy6gSgDZIvAGPSVH/z8H/mVRMI UNnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b01YoJgu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be14-20020a0564021a2e00b005049ba125b9si8144965edb.431.2023.04.12.10.41.09; Wed, 12 Apr 2023 10:41:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b01YoJgu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjDLR3r (ORCPT + 99 others); Wed, 12 Apr 2023 13:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjDLR3o (ORCPT ); Wed, 12 Apr 2023 13:29:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204C0A3 for ; Wed, 12 Apr 2023 10:29:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD8746112F for ; Wed, 12 Apr 2023 17:29:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C01C433D2; Wed, 12 Apr 2023 17:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681320583; bh=u/d+SjuZhierU9Gg0DcduPo+2fpMD4JwgALDlLtr1jg=; h=From:To:Cc:Subject:Date:From; b=b01YoJguEXeYSdygNYJT0O/VR7LIXY5NqTbef7/oMbXS8v3gXe3di/Jalb6C+/pHx SeeFI7wv7+qyykzvZzQwvJn7arChJ4kmo22R4wufDr6tu49fsoVGJ7bGpVxV8Tb95p m5JdQpZlUlhN9Nd8NWXScaIASCMk9ezlSfmoYinclupZnkKJJjn03Vi1rUPsqIX3T7 4S+rEFS2liUvycoHjUAsFhQKpmVcj2sPO6AeXcnTekseZS9pUdIowOM1obuCTrQuBn qbN9QERkdtvpHdCuR77O0KuMjWLCUf8/+s7DCdsaCmgDmtBdIOtlbylXsmjlTUba+z DAC78763LaPAA== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Miroslav Benes Subject: [PATCH] objtool: Add stackleak instrumentation to uaccess safe list Date: Wed, 12 Apr 2023 10:29:35 -0700 Message-Id: <42e9b487ef89e9b237fd5220ad1c7cf1a2ad7eb8.1681320562.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762993159336746147?= X-GMAIL-MSGID: =?utf-8?q?1762993159336746147?= If a function has a large stack frame, the stackleak plugin adds a call to stackleak_track_stack() after the prologue. This function may be called in uaccess-enabled code. Add it to the uaccess safe list. Fixes the following warning: vmlinux.o: warning: objtool: kasan_report+0x12: call to stackleak_track_stack() with UACCESS enabled Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index f937be1afe65..34bd6a11bddd 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1278,6 +1278,8 @@ static const char *uaccess_safe_builtin[] = { "__ubsan_handle_type_mismatch_v1", "__ubsan_handle_shift_out_of_bounds", "__ubsan_handle_load_invalid_value", + /* STACKLEAK */ + "stackleak_track_stack", /* misc */ "csum_partial_copy_generic", "copy_mc_fragile",