From patchwork Mon Jul 10 17:10:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Leemhuis X-Patchwork-Id: 117993 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp5182498vqx; Mon, 10 Jul 2023 10:33:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlG+sfH9BH45U5KaQa6KLCDu0Cz0xe3QGXfDvOnzprzP+U3BIhlvOg09pMkRGYC0d9jbJiiD X-Received: by 2002:a17:902:e5ce:b0:1b8:30d8:bc45 with SMTP id u14-20020a170902e5ce00b001b830d8bc45mr12143524plf.47.1689010419538; Mon, 10 Jul 2023 10:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689010419; cv=none; d=google.com; s=arc-20160816; b=v4UCylccfl+Iim7aus4bit2pIZrH1iBdT5xMJCn9LX+kN3ZcLu3waaMQIhn20nIs/o EzScwVfI2Y3i7d3Hm/H4A+HaHWr7KuDzkhBnK/kThfwxkYEDvIesbDqMlcBDQXAO7+aE wwk3PWoZW+TKLRtenlBhlcHjM4Z+TxWpNGd1wtrenqL1tbGRplcL5+dqqHCZY+QzHdTi MSZBloq4JKgeXc9VpeQSXC1/jJglVCbLRGDC7u0Lhljj39zP4mMigtsAj8qqJ4jByak7 +bs7d2YIsxgIf3KBkyMc4+cMBqwIkOqxhr2qPy7BKXKD82G2pVQaloUjdIbEMy6ftHz9 l0ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GPSXOBkAl/3xhH5oTIzC+TeoMq/fa1AtWU2gUFwDW+k=; fh=IyOYz2aApVSZcG0zYEej1oDoCpl4LIOyTRZ6Vqq7g1o=; b=hGLMBrwHDNup/AAy/dY8rmTym7F4K5oWN4G1LIqLvlZ5+XpkGzLSIk87UuGp1DyQLA A9+M1lsiD1BmEaQDuBduRa2WBa1wqYE0XQxTkTe+bVIaFoxye4g024+yyX+JaJ85mCpx PUYnxE99w1Mg+iGJdPxfoTs1cjaR+4jzQxDfu8vfxIyjFwSCFD5vN82Rf+cjmpILJFhy M5ETDnFjQ5/uq+vLMreCNwjzWXV32DG5p5dFPph5dFLUy0W70QVjwOqfI9t3a1JrvlCU PCNhVhA7c+cjb5Fubviv01U9oT1YHHEPcEBltrnft8h81autD3fNA4vaLzFUTsG70NpP Pp7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a170902694c00b001b8079085a1si136307plt.380.2023.07.10.10.33.26; Mon, 10 Jul 2023 10:33:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232143AbjGJRKV (ORCPT + 99 others); Mon, 10 Jul 2023 13:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbjGJRKT (ORCPT ); Mon, 10 Jul 2023 13:10:19 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1881BB; Mon, 10 Jul 2023 10:10:18 -0700 (PDT) Received: from ip4d148da6.dynamic.kabel-deutschland.de ([77.20.141.166] helo=truhe.fritz.box); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1qIuOt-0006Iv-P7; Mon, 10 Jul 2023 19:10:15 +0200 From: Thorsten Leemhuis To: Greg KH , stable@vger.kernel.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Jonathan Corbet Subject: [RFC PATCH v1 2/3] docs: stable-kernel-rules: make rule section more straight forward Date: Mon, 10 Jul 2023 19:10:12 +0200 Message-Id: <420fc78dd7f3cd537143ebdb25a51ea58d3f031d.1689008220.git.linux@leemhuis.info> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-bounce-key: webpack.hosteurope.de;linux@leemhuis.info;1689009018;df12a5bf; X-HE-SMSGID: 1qIuOt-0006Iv-P7 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771055789745661775 X-GMAIL-MSGID: 1771055789745661775 Tweak some of the rule text to make things more straight forward, with the goal to stick closely to the intend of the old text: * put the "it or equivalent fix must be ustream" rule at the top, as it's one of the most important ones that at the same time often seems to be missed by developers. * "It must fix only one thing" was dropped, as that is almost always a thing that needs to be handled earlier when the change is mainlined. Furthermore, this is already indirectly covered by the "Separate your changes" section in Documentation/process/submitting-patches.rst which the rules already point to. * six other rules are in the end one rule with clarifications; structure the text accordingly to make it a lot easier to follow and understand the intend. CC: Greg KH CC: Sasha Levin CC: Jonathan Corbet Signed-off-by: Thorsten Leemhuis --- Documentation/process/stable-kernel-rules.rst | 39 +++++++++---------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst index 6e4026dd6882..85d5d2368034 100644 --- a/Documentation/process/stable-kernel-rules.rst +++ b/Documentation/process/stable-kernel-rules.rst @@ -6,31 +6,30 @@ Everything you ever wanted to know about Linux -stable releases Rules on what kind of patches are accepted, and which ones are not, into the "-stable" tree: + - It or an equivalent fix must already exist in Linus' tree (upstream). - It must be obviously correct and tested. - It cannot be bigger than 100 lines, with context. - - It must fix only one thing. - - It must fix a real bug that bothers people (not a, "This could be a - problem..." type thing). - - It must fix a problem that causes a build error (but not for things - marked CONFIG_BROKEN), an oops, a hang, data corruption, a real - security issue, or some "oh, that's not good" issue. In short, something - critical. - - Serious issues as reported by a user of a distribution kernel may also - be considered if they fix a notable performance or interactivity issue. - As these fixes are not as obvious and have a higher risk of a subtle - regression they should only be submitted by a distribution kernel - maintainer and include an addendum linking to a bugzilla entry if it - exists and additional information on the user-visible impact. - - New device IDs and quirks are also accepted. - - No "theoretical race condition" issues, unless an explanation of how the - race can be exploited is also provided. - - It cannot contain any "trivial" fixes in it (spelling changes, - whitespace cleanups, etc). - It must follow the :ref:`Documentation/process/submitting-patches.rst ` rules. - - It or an equivalent fix must already exist in Linus' tree (upstream). - + - It must either fix a real bug that bothers people or just add a device ID. + To elaborate on the former: + + - It fixes a problem like an oops, a hang, data corruption, a real security + issue, a hardware quirk, a build error (but not for things marked + CONFIG_BROKEN), or some "oh, that's not good" issue. In short, something + critical. + - Serious issues as reported by a user of a distribution kernel may also + be considered if they fix a notable performance or interactivity issue. + As these fixes are not as obvious and have a higher risk of a subtle + regression they should only be submitted by a distribution kernel + maintainer and include an addendum linking to a bugzilla entry if it + exists and additional information on the user-visible impact. + - No "This could be a problem..." type of things like a "theoretical race + condition", unless an explanation of how the bug can be exploited is also + provided. + - No "trivial" fixes without benefit for users (spelling changes, whitespace + cleanups, etc). Procedure for submitting patches to the -stable tree ----------------------------------------------------