diff mbox series

[2/3] dt-bindings: arm: ti: Add binding for Siemens IOT2050 M.2 variant

Message ID 3f825ff8853b1ffd8228d3283c7da0483ddf55d5.1674059300.git.jan.kiszka@siemens.com
State New
Headers
Series arm64: dts: Add IOT2050 M.2 board, describe QSPI layout |

Commit Message

Jan Kiszka Jan. 18, 2023, 4:28 p.m. UTC 
  From: Jan Kiszka <jan.kiszka@siemens.com>

This new variant is derived from the Advanced PG2 board, replacing the
MiniPCI slot with B and E-keyed M.2 slots.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 18, 2023, 5:07 p.m. UTC | #1 
On 18/01/2023 17:28, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This new variant is derived from the Advanced PG2 board, replacing the
> MiniPCI slot with B and E-keyed M.2 slots.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Vignesh Raghavendra Jan. 18, 2023, 5:43 p.m. UTC | #2 
Hi Jan,

On 1/18/2023 9:58 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This new variant is derived from the Advanced PG2 board, replacing the
> MiniPCI slot with B and E-keyed M.2 slots.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index 203faab80142..7af813202f1f 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -43,6 +43,7 @@ properties:
>            - enum:
>                - siemens,iot2050-advanced
>                - siemens,iot2050-advanced-pg2
> +              - siemens,iot2050-advanced-m2

Could you re arrange alphabetically?

>                - siemens,iot2050-basic
>                - siemens,iot2050-basic-pg2
>                - ti,am654-evm


Regards
Vignesh
Jan Kiszka Jan. 19, 2023, 6:34 a.m. UTC | #3 
On 18.01.23 18:43, Raghavendra, Vignesh wrote:
> Hi Jan,
> 
> On 1/18/2023 9:58 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This new variant is derived from the Advanced PG2 board, replacing the
>> MiniPCI slot with B and E-keyed M.2 slots.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> index 203faab80142..7af813202f1f 100644
>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>> @@ -43,6 +43,7 @@ properties:
>>            - enum:
>>                - siemens,iot2050-advanced
>>                - siemens,iot2050-advanced-pg2
>> +              - siemens,iot2050-advanced-m2
> 
> Could you re arrange alphabetically?

Time of release ordering, but I can reorder as well.

Jan

> 
>>                - siemens,iot2050-basic
>>                - siemens,iot2050-basic-pg2
>>                - ti,am654-evm
> 
> 
> Regards
> Vignesh
Krzysztof Kozlowski Jan. 19, 2023, 7:43 a.m. UTC | #4 
On 19/01/2023 07:34, Jan Kiszka wrote:
> On 18.01.23 18:43, Raghavendra, Vignesh wrote:
>> Hi Jan,
>>
>> On 1/18/2023 9:58 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This new variant is derived from the Advanced PG2 board, replacing the
>>> MiniPCI slot with B and E-keyed M.2 slots.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> index 203faab80142..7af813202f1f 100644
>>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> @@ -43,6 +43,7 @@ properties:
>>>            - enum:
>>>                - siemens,iot2050-advanced
>>>                - siemens,iot2050-advanced-pg2
>>> +              - siemens,iot2050-advanced-m2
>>
>> Could you re arrange alphabetically?
> 
> Time of release ordering, but I can reorder as well.

The entries look ordered alphabetically, not by time of release. BTW, I
assume time of release != time of adding to Linux, which would be just
dropping stuff to the end...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index 203faab80142..7af813202f1f 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -43,6 +43,7 @@  properties:
           - enum:
               - siemens,iot2050-advanced
               - siemens,iot2050-advanced-pg2
+              - siemens,iot2050-advanced-m2
               - siemens,iot2050-basic
               - siemens,iot2050-basic-pg2
               - ti,am654-evm