From patchwork Mon May 29 06:22:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 100114 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1320076vqr; Sun, 28 May 2023 23:51:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5aQSgVd8lmbEuXcK0zRvG1nkCTN7RFVFtUNpCAFrnujaVMYf3x6ZMjIvSVgfWiPCS8CJoJ X-Received: by 2002:a05:6a20:7485:b0:10d:bc30:b9ea with SMTP id p5-20020a056a20748500b0010dbc30b9eamr9505420pzd.39.1685343090013; Sun, 28 May 2023 23:51:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685343089; cv=none; d=google.com; s=arc-20160816; b=w4Te2WGBKmn9WnNSwmq0z0L/h6YRlXL4KFotIro5jZ+UGLZh9hpHKUrNihE1+tMdgL trzBB8WTYN5lIZ6tzbbE2QPnEesLDkZKUJIYQNakLqHE352PwQ7DNECpKPITnbzz9YM9 YfmNl3gzfiiZFdLe5y71RpifS4xfAGi7RxBz4n91wEhaeCe83I3Fn5MQdpCLBApfrM7m Pv2cIIzY7C7FUhMRJmRkMWji73EfR9DRsZtpV2p94bMCtzQipfJIEEN6wIVMhlZ7g+OX RI+xlqrQrCjAmuzuY7y1tkYSxcuhV3LZM+mqRXpwZVMAa/KHoIdu0OPNgStqxfmvkGXn VgBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JRZkhSfNi/CahwvYTKjgmeTw6RKVKTnQbqpayNzly3w=; b=TNf/JWjbTG/UNr2aju0aqQ+pKsnKxu1/WM8bBfMxVXI9RrFD3dYp//8aVQhksxo3D+ mum8aNlpFgWNLUpdIXswEq6V+4IHD+fib6adgd2jDWwpP8qoDyz3LoCEZso6uNc6Q4SC TUJ3aBcmK3b1I5IdoSHeXYmUzQOw3a3HCcWolqVIQIhXSmuIrfr5wKrdwO3NFy2vPpQF qwnTjMo9jaCIzU//pxYQm6J02ThsOa6+vIbfwKIv9uoWXv+ouQvSJB8DyWQlBDne638F X2ynHwqHJooS9LbjLpV+AbbKkao3X562w65NAYoEiI4Mtfrtk+b9upUy8qOSOJCUJcLO xpsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="NgR/fbJP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q23-20020a170902bd9700b001ab13c7505asi6346771pls.125.2023.05.28.23.51.15; Sun, 28 May 2023 23:51:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="NgR/fbJP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230392AbjE2GWo (ORCPT + 99 others); Mon, 29 May 2023 02:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjE2GWl (ORCPT ); Mon, 29 May 2023 02:22:41 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B10C2; Sun, 28 May 2023 23:22:39 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4f3b5881734so3268562e87.0; Sun, 28 May 2023 23:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685341358; x=1687933358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JRZkhSfNi/CahwvYTKjgmeTw6RKVKTnQbqpayNzly3w=; b=NgR/fbJPAxlA6ez4qMq0Ef7YeLvwdGjfoAR11dyQrwOqRT3j5c5e3HOaCb7pOtnDWO xHoYdgZIg7kLKjsza+J0mrXKaFWuH74btl0Y/4OFE9xhyn6yppFKZtCO7WwDzLR9SWiq v+zK4NTRcstq4UOtSjQ5OyG/bsgXK11Eq20CMlIBJEhRSn3ROKcu3A0ijeUqmCWj4rq7 M+ScwPFEoLcV7G8Ylh3Z8HQsaXK82shh4Oj95VzQLO893tA/3VL/epny988lwT7cyTED U2TBpUQXCuBaISPLj7a0T++zoH2qn7WZfIotXwPNNYoJFEDPjzAB+y5CvdSp0xNe14bn gLIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685341358; x=1687933358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JRZkhSfNi/CahwvYTKjgmeTw6RKVKTnQbqpayNzly3w=; b=CRguAAEK8C1khJO4d0uAJlQyn24mbUn50ejSgeritJ1m8brqAY9q/iODcdFY7sCpty /jhgL8YrKcZTw2ccReEIMqaEKpmArGyvVDLuaECZN5ONRLfIVUY7V7rg1/plNpzsLwIT 7PyJeJN5d7C5/Yxm6ewEMVzHgZ0AuTm4eYNe3fCDZaq0OM2gD+NEeNim7Xb1sMNRAGOq 5HELW01h6/Vc7R598nTql/wCYI8JoCO07HiqnzlvEJUfEew4bTSP0tWnA9AcnnKh3yg5 WbP44B5oM/nNxRBTbY5Lwp7aRXK9K4Q2AEzj+v/zrq9/CIyzoe9DOnFYVt1X00tPa4wr QxJw== X-Gm-Message-State: AC+VfDyvAJ6Yihnej3sauXvhDBAwsh7eVVVOSvnJcd52da/UWbYG9mkh rjbgjRdd3tkJEFu4rTFHTe4= X-Received: by 2002:ac2:5298:0:b0:4f1:5010:4b34 with SMTP id q24-20020ac25298000000b004f150104b34mr3954548lfm.18.1685341357703; Sun, 28 May 2023 23:22:37 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id z3-20020a19f703000000b004f11eb32f20sm1870130lfe.13.2023.05.28.23.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 23:22:37 -0700 (PDT) Date: Mon, 29 May 2023 09:22:33 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v7 1/9] drivers: fwnode: fix fwnode_irq_get[_byname]() Message-ID: <3e64fe592dc99e27ef9a0b247fc49fa26b6b8a58.1685340157.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767210315617200250?= X-GMAIL-MSGID: =?utf-8?q?1767210315617200250?= The fwnode_irq_get() and the fwnode_irq_get_byname() return 0 upon device-tree IRQ mapping failure. This is contradicting the fwnode_irq_get_byname() function documentation and can potentially be a source of errors like: int probe(...) { ... irq = fwnode_irq_get_byname(); if (irq <= 0) return irq; ... } Here we do correctly check the return value from fwnode_irq_get_byname() but the driver probe will now return success. (There was already one such user in-tree). Change the fwnode_irq_get_byname() to work as documented and make also the fwnode_irq_get() follow same common convention returning a negative errno upon failure. Fixes: ca0acb511c21 ("device property: Add fwnode_irq_get_byname") Suggested-by: Sakari Ailus Suggested-by: Jonathan Cameron Signed-off-by: Matti Vaittinen Reviewed-by: Andy Shevchenko Reviewed-by: Jonathan Cameron --- Revision history: v4 =>: - No Changes v3 => v4: - Change also the fwnode_irq_get() --- drivers/base/property.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/base/property.c b/drivers/base/property.c index f6117ec9805c..8c40abed7852 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -987,12 +987,18 @@ EXPORT_SYMBOL(fwnode_iomap); * @fwnode: Pointer to the firmware node * @index: Zero-based index of the IRQ * - * Return: Linux IRQ number on success. Other values are determined - * according to acpi_irq_get() or of_irq_get() operation. + * Return: Linux IRQ number on success. Negative errno on failure. */ int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index) { - return fwnode_call_int_op(fwnode, irq_get, index); + int ret; + + ret = fwnode_call_int_op(fwnode, irq_get, index); + /* We treat mapping errors as invalid case */ + if (ret == 0) + return -EINVAL; + + return ret; } EXPORT_SYMBOL(fwnode_irq_get);