From patchwork Sun Dec 17 14:29:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734503dyi; Sun, 17 Dec 2023 06:34:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVt/TKTGzrIfGF3a9W2DdRySZn1c4i1TsyU714mLG4WzJ13G3KAcVzVU2W9WFbBbBiW2Q2 X-Received: by 2002:a05:6e02:1c0d:b0:35f:af72:1d9b with SMTP id l13-20020a056e021c0d00b0035faf721d9bmr828663ilh.127.1702823699078; Sun, 17 Dec 2023 06:34:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823699; cv=none; d=google.com; s=arc-20160816; b=wbcOD9oAYwKUSHWV59slXJksM/K/3MkDc8Wvkr/3bUZMKU90/jy8bLDtvKC0eQWv0f h7V73WNY66FLxCpKysAAqmckrMe8JU2siD9YXzw7gmYPYqx+U0Od8deLv+QrGJz5b7v9 dANs7bogeZE025G+x2dSkyDLsQrrhw0u8I7es9muc0I28hl251ZLeyTKlUECZPzaHE9Y hyO3gfetYzxHTXb+lqR6O30oj1Wpy2sl6481IUbU4JEokq42kttvhfcNVEoPMkwWtL6g Qg+ZO4maeEggZSE4bMg9CrBijiA9LVPU4kOPjAbidteLW7yteZKUZCrZQVIUKb2kXLgn fh6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=iiXVnUOpVQilQIWOO+65bUFbNTweck1K2hJVmqsHEGE=; fh=0chRuGPFzrQz3xfHA/HszxMAL9+QTc+wVvcsMLE+/iI=; b=VZMBMBWwF+otPSxNQlTj9H6Vp2H0shyJfK2SvJiSBXPrHqdhMlCyhYc9MKnTBQxOan VICpv4tdR8jcauA8/4T7FPW7aaCj+UmGp+eVPcLwSTNGxlQAo0UlAuev2UF2LsNKgnYv 8E4XMb5zs2A7XknT6UOrnQNlPZrCAL9m34ni9TtvHgGBqJ7eE7VqI53zdPmItFRHcDZL pqf7Dk89TA3m01xs4ACsWzXm19p0hYt4DtqETONaDMxUCfvWHDgAGYjNEan7OkU6tr5e tNcOBH8Kcig6UJsSAhOoIaBnyzy2Pxc9YM3iLfkx0eu/GkZFG+9paTfg5i23WVzrfFwn UqPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b14-20020a631b4e000000b00564c67e66fbsi16358330pgm.842.2023.12.17.06.34.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:34:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8E971B228BD for ; Sun, 17 Dec 2023 14:34:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1CA6481C7; Sun, 17 Dec 2023 14:30:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3E046453 for ; Sun, 17 Dec 2023 14:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006Y8-By; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhn-Nz; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzk-Ef; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Thierry Reding , Jonathan Hunter , Rob Herring , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 13/15] memory: tegra210-emc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:39 +0100 Message-ID: <3e2951685dddbc0ab32244916a9849af206a6730.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1901; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=bGdyoxMNmY/bbwpr5SN+sb3K9b9jnZzp/Hcxotdsv9Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXUZZG5GWUBTUeLiKtuoBiiZylSrm31PtSWX 94NiU6Y59uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F1AAKCRCPgPtYfRL+ TgCOB/0dPqf5bYKYlXnyRskNAJ2J1KfXnjmdTEdDVhDx7V8W651gEkJ9kWcgIzMMPe1kNm9w/MY /FZWlvbRm+V21imJBp+IdlVEXmodVoxUIwNOuZcKHz2yP/OSnVf8zfhKPorwXKlH/wT/INl4zzj +Pp7/rJ8FcK4/aCw0fdDYKFlGNvaThJQ4VOY/UeHWvqjAnhYDzc/gNwlbV0mKnaiBA9aaJV3neO ++YWHaihxoT0q8mH8WePbRn7Xf1x6AvpL/1VSfbvIXOmGixnJk50Zj8A5ci7txtFmrLqJ3yTTg1 gM3wuXnlc82ARyW0RhkX1kgKKS5rMIX9fyRC7pAkdkeMOsaI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540063367070514 X-GMAIL-MSGID: 1785540063367070514 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/tegra/tegra210-emc-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c index 3300bde47c13..78ca1d6c0977 100644 --- a/drivers/memory/tegra/tegra210-emc-core.c +++ b/drivers/memory/tegra/tegra210-emc-core.c @@ -1985,15 +1985,13 @@ static int tegra210_emc_probe(struct platform_device *pdev) return err; } -static int tegra210_emc_remove(struct platform_device *pdev) +static void tegra210_emc_remove(struct platform_device *pdev) { struct tegra210_emc *emc = platform_get_drvdata(pdev); debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); of_reserved_mem_device_release(emc->dev); - - return 0; } static int __maybe_unused tegra210_emc_suspend(struct device *dev) @@ -2053,7 +2051,7 @@ static struct platform_driver tegra210_emc_driver = { .pm = &tegra210_emc_pm_ops, }, .probe = tegra210_emc_probe, - .remove = tegra210_emc_remove, + .remove_new = tegra210_emc_remove, }; module_platform_driver(tegra210_emc_driver);