From patchwork Tue Mar 14 10:13:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeniy Baskov X-Patchwork-Id: 69512 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1697574wrd; Tue, 14 Mar 2023 04:25:52 -0700 (PDT) X-Google-Smtp-Source: AK7set/V95zDILEoJyg9VfuSR8/ais84dUxGg2ZSLUhBl2BErgrpHsKTlNIsTqkJywOclo90JGvp X-Received: by 2002:a17:902:f68a:b0:1a0:67fb:445c with SMTP id l10-20020a170902f68a00b001a067fb445cmr2152333plg.28.1678793152097; Tue, 14 Mar 2023 04:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678793152; cv=none; d=google.com; s=arc-20160816; b=rtb6SF+6EXPZKUeguMl5VfcNtI264sHONiRYXrd98+UcUOaIQnfPyj54EBqZQJwP+S Xi3/vRyFhHnv3k/9pAswOMKsRN93w8YTWtES6fMtHqU7S+c56R04S9e8Urd3EFZSXGaV 5JJQ8G6wF1J+gDlIPDyFtXdA1wBnqDCCF7dIlEXvtkAPQR5YbR0EVsNVjToL6It0bSuX dLxlq7IXjkIjc4yCcfZ9h19oV9iXakFgR4jYn3TI0ko6JZ4XVVK/GXAEoELeq4aqU445 k4fq8h9yVmGDGj23cJc2MSf+QeRH906D2KyaaRkG8GCRRwtuEL1hb+1bH34TpT2OeIZK 4GfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=xWgPhy9flM1A9RQwR6AaR8Ed4LhIfck7ee61NCgDLok=; b=Xl3Wdo2SEdqAukPpcx039vh1KdkRzuoWNDGhIXmLMYgTTdz3QGlcqWqXcewnMf4wLS hKOZt2lyuXhWOvUNezyRjGN2MGKSGkunH422Hqq6jrKPUZB1w5ARJhU6ymHc/CkhiDos RrE1/oeuzpHTFIn4S8tRvl4Rk1jMh2xfp1CA6gl+Wu66KWOjAA/PuXBDd/2crULalZYI SUTN2FqP3Zb+kwKb2mzMzlTB5SsFxCS1RzDG+GK1s96zkJKIvvmFdL4lF20vTZzED3In 2Uc3wDt14PrHBm9XEmjb743tHIgLoHI6YAFO9iba6QCdWdduNeLDXU9T8YUvNEHtZh56 mdow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=S6KKotKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lh15-20020a170903290f00b0019afac78059si2125580plb.603.2023.03.14.04.25.35; Tue, 14 Mar 2023 04:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=S6KKotKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbjCNLCX (ORCPT + 99 others); Tue, 14 Mar 2023 07:02:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjCNLCS (ORCPT ); Tue, 14 Mar 2023 07:02:18 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A36E94A4E; Tue, 14 Mar 2023 04:02:02 -0700 (PDT) Received: from localhost.localdomain (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id 0C9EB4076B3D; Tue, 14 Mar 2023 10:23:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 0C9EB4076B3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1678789406; bh=xWgPhy9flM1A9RQwR6AaR8Ed4LhIfck7ee61NCgDLok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S6KKotKUXYAemnX5XK5UnGMWprOHJmI/0GF4uIjSOryzlLFL1wE+0pU+PcyK/yTTx IbRu8Q7UFzpNUgeTHtF8FuoIcdQ0ayamdvlh7+LLD7HJD0HeyifAZdjdWZ3DUNL+lD yyzj+ch5Ewns83S/bxivutfRQkjDBtbDVaAbfGeU= From: Evgeniy Baskov To: Ard Biesheuvel Cc: Peter Jones , Borislav Petkov , Andy Lutomirski , Dave Hansen , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexey Khoroshilov , Gerd Hoffmann , "Limonciello, Mario" , joeyli , lvc-project@linuxtesting.org, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v5 26/27] efi/libstub: make memory protection warnings include newlines. Date: Tue, 14 Mar 2023 13:13:53 +0300 Message-Id: <3d60d0fa9fc96cbb85938042ad7be0d9884ff70c.1678785672.git.baskov@ispras.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760342208460747402?= X-GMAIL-MSGID: =?utf-8?q?1760342208460747402?= From: Peter Jones efi_warn() doesn't put newlines on messages, and that makes reading warnings without newlines hard to do. Signed-off-by: Peter Jones --- drivers/firmware/efi/libstub/mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c index 77cf745ade0d..d58b552739ed 100644 --- a/drivers/firmware/efi/libstub/mem.c +++ b/drivers/firmware/efi/libstub/mem.c @@ -298,7 +298,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attr_clear); if (status != EFI_SUCCESS) { - efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status); @@ -311,7 +311,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attributes); if (status != EFI_SUCCESS) { - efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status);