From patchwork Fri Dec 8 16:08:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555403vqy; Fri, 8 Dec 2023 08:09:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDeSEZ8UR4EyVZbn/tBI/ABqa9Ur1QC7zhMqxVfizt0vujGD0Ms41zjxB/7fnEOCAAQplH X-Received: by 2002:a17:90b:b10:b0:286:f3d8:de3f with SMTP id bf16-20020a17090b0b1000b00286f3d8de3fmr280026pjb.84.1702051762373; Fri, 08 Dec 2023 08:09:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051762; cv=none; d=google.com; s=arc-20160816; b=DoojonjQVZnGaBHJC8d1FXWm3AdwT/X3pJrrSsw1lnTS3l2blWoeiO2QRptx8Qxbyw aj1y7asBlipx/VGPRA7LEtDY1kbmeEciTWYBtrGz2GkG+mQltrRbbGNbi0dH0QilEV2T NX+vKZRfa37Ynk3OSS8qSaJ5OtbSiRnEJzkfklfOvLSJE2THv1ezBeB25Q6DVMIvC/9d bo1h1IMns2j5tmJ+CsLGA3Xx6q6dau9y0rXx6c9Rk+3X7sOd3R3oljyHmgB5BZyPpgrN H2fbc7Dk/9aLhukJSFMVVvS4I3Ycs0iXJpQYWHB1pPheoQ8jgdh+d7RXRv7VvKAUl3Oj AaSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PqYgDDFD03a/9CFqZDSq0c02MUJUSRZn8OXXTaebIrc=; fh=vyx8h/R3/RgPDF3hs4DKbHATzneQA+WUA+Ft3xYcKZY=; b=eq0lPGhmT7oQPrj2eWGDe7JQoZX40yQFwes6vtqBInql8YwXHHVe7IA8AScIRXoor/ wEQOTLz/bqRkSP/ENMdvErSYizvzFJRtMWTI3NUH4lRKpDtimiwD0KIsuFXMNpjNcIEo 32BxUQrTUEhmxhhB/ZVv/DlOLEzoCc9Xu0LXA5fvONQhgrDgbSxeKlC3SjbRjsIINzTI G5ViF+LLRBgnU53+FwEWy8dBh8OtDaOdlZPKEaM5IQT/WpxcvC5F0WsbAmVd4igrk4n6 BPBYsl4RDR3C2LQLxZvr3P+U+Sc+59kYvZwn8KUEBIM96yzOd7+rI03NwtCTbFkLWwGk +Vig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c10-20020a17090a8d0a00b00286971a69a4si3177292pjo.94.2023.12.08.08.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AC0F580A8B5C; Fri, 8 Dec 2023 08:09:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbjLHQJK (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233525AbjLHQJI (ORCPT ); Fri, 8 Dec 2023 11:09:08 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF88173F for ; Fri, 8 Dec 2023 08:09:14 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPc-00007x-Rv; Fri, 08 Dec 2023 17:09:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0I-Cn; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaG-3a; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/7] pcmcia: db1xxx_ss: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:07 +0100 Message-ID: <3d4c108421f2b1175d3a75ee6854e7772f8a0f82.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1949; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=hoOY5rB1wBTrm118MtH1tMoeiGlvJRV6JaXbOehuwJI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9s7low3YagEVqKvVCP8KpeDw29gpuTL57GW 8gR3BuoyWSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bAAKCRCPgPtYfRL+ TquFB/9ngk35j3HsFMuqUz7AHsV1DL1owZ3//hwU4IDZar2fh9KXu8S6NdL69qrH3ONbRq6r2I9 D5fi/U+YlDS1j03udvaDYEBdXi36THcMqLUaSPJb16vyTF+cWGzugfXK9ybwHv49KGM1Wfg5yq7 FfzoKCDwZ7V54bl0racUEOYQhcXA5ltYrIOpVSdpDI/4mpAQQB7OwW73SDBrdCvl6ggyz7PgYsL DRnCw7RCSWzVRAnILInxCiBXFLgssOittjh7ScwUpv9SNc4J5y1vvFVQleJ7fyUbdzWxErYRwD6 0aH3XGiDkjf8cCPTBfSis2uyJ6d4yxKcBEUvZxlcrbXJE2bS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730628632901494 X-GMAIL-MSGID: 1784730628632901494 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/db1xxx_ss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia/db1xxx_ss.c index 87a33ecc2cf1..509713b9a502 100644 --- a/drivers/pcmcia/db1xxx_ss.c +++ b/drivers/pcmcia/db1xxx_ss.c @@ -577,7 +577,7 @@ static int db1x_pcmcia_socket_probe(struct platform_device *pdev) return ret; } -static int db1x_pcmcia_socket_remove(struct platform_device *pdev) +static void db1x_pcmcia_socket_remove(struct platform_device *pdev) { struct db1x_pcmcia_sock *sock = platform_get_drvdata(pdev); @@ -585,8 +585,6 @@ static int db1x_pcmcia_socket_remove(struct platform_device *pdev) pcmcia_unregister_socket(&sock->socket); iounmap((void *)(sock->virt_io + (u32)mips_io_port_base)); kfree(sock); - - return 0; } static struct platform_driver db1x_pcmcia_socket_driver = { @@ -594,7 +592,7 @@ static struct platform_driver db1x_pcmcia_socket_driver = { .name = "db1xxx_pcmcia", }, .probe = db1x_pcmcia_socket_probe, - .remove = db1x_pcmcia_socket_remove, + .remove_new = db1x_pcmcia_socket_remove, }; module_platform_driver(db1x_pcmcia_socket_driver);