From patchwork Thu Oct 26 20:01:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 158672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp135993vqb; Thu, 26 Oct 2023 13:01:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEvXcxTr/Vs8vCgToPoMGuMcf6OtkxdCHFlCl4c5mkrp3Wh6FlWSWir2gGBR2Jzi1I58kz X-Received: by 2002:a05:6902:1083:b0:d9d:39af:2feb with SMTP id v3-20020a056902108300b00d9d39af2febmr484293ybu.50.1698350498177; Thu, 26 Oct 2023 13:01:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698350498; cv=none; d=google.com; s=arc-20160816; b=Dz/fdvNFdq1qLQdNwEyNwMmW6GbH9cE1p7Y93q8ZfB3bfgY69bFGL1u6JRHkbPBUy3 BfD2elEIx6weazd8NKsi9RBSCiByEIXZ+XcLR7orRTKpZ9SjaEoCAN6XhkODqAda/oWa w9biQfM0hGJdg3IevgpazZCWMJYdQn0NlSxXyXhn9R21PsrVKnvp+NJKymrlQTL7hCSH nhw35Oq+Zwklfno0SFpIczDoGSuN2EJI0di6yn/cdKK79fQ3OZGSe6FTF6xNxcHVNEbj 79Yzzsg2UAkvKzDDYbrWfOQ7CYM2S4ol2XH11YWyBaCMr+wGoQiC+vxvCWLCOFMsTl3N 8alA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i2fWBBG9mLsogb4ThmIrsmZJLekVVeeZs1stUDz5bLY=; fh=swjxqjQ9hhASm8GoxkZi+6BQ9X7UYEMXc0fZW0c9whc=; b=NtpynsY49UzczRzQCQmeLH7KnyBmDB27/c/+RpJl9Z6GmIxlHNifnNNmchzwKFApWy Wv7vCX8HSGgeMmY6bTDAt3sTTEaPIKOTvvu/OqjGYaJ4KHPZFH8iEXTAvC7YP+SN6NrI sj55iNrDQsE9Ult0KogSnhsG+mg8ARpwAmIqLg86jnRWOki8cl3y65rrAHpBbYLP+N12 4KiEq4UMZ2TbypU1m9vnfclSUj7aDTPvFvyjnoAjMwRrdg3FwuNY02aW6JxbOAkB5orY PL8jhsgdsZ4TKcl2wcy1DMDdeYJIiO3ai4z0perTmTCI1+phNnmDmN4f/CkghZTZ6sOz G/ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=aggK5mRY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id g10-20020a25b10a000000b00da0adab33c8si208553ybj.466.2023.10.26.13.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 13:01:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=aggK5mRY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 90FE881BE2D3; Thu, 26 Oct 2023 13:01:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231701AbjJZUB3 (ORCPT + 26 others); Thu, 26 Oct 2023 16:01:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjJZUB1 (ORCPT ); Thu, 26 Oct 2023 16:01:27 -0400 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [IPv6:2001:41d0:1004:224b::bc]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1433BC0 for ; Thu, 26 Oct 2023 13:01:25 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698350483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i2fWBBG9mLsogb4ThmIrsmZJLekVVeeZs1stUDz5bLY=; b=aggK5mRYNgfUFifJAY6PRh8UPuM4z6Xtj3PW/t5bGjwxdH0d2b88z3eQ04wjdZNzx8+X7+ pp2Lo/wHupV12uFZ5T97mtTvwIi9LO814iRGBsuURqZ/lhC1GtSS5BYEx+l4Y9srIl1Hrm coM2+KKYuNpZtBh3w08FwqxN4x/sPSk= From: andrey.konovalov@linux.dev To: Greg Kroah-Hartman Cc: Andrey Konovalov , Alan Stern , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] usb: raw-gadget: don't disable device if usb_ep_queue fails Date: Thu, 26 Oct 2023 22:01:13 +0200 Message-Id: <3c5df3dddb67623b4aeb11c5546370363e65d8e2.1698350424.git.andreyknvl@gmail.com> In-Reply-To: <0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698350424.git.andreyknvl@gmail.com> References: <0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698350424.git.andreyknvl@gmail.com> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 26 Oct 2023 13:01:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780849572008315509 X-GMAIL-MSGID: 1780849572008315509 From: Andrey Konovalov During device operation, the host might decide to reset a device emulated via Raw Gadget. In this case, if the device emulation code has endpoint requests queued, usb_ep_queue will fail with -ESHUTDOWN. Currently, this disables the Raw Gadget device and makes the emulation code unable to proceed. Do not disable the Raw Gadget device if usb_ep_queue fails. Signed-off-by: Andrey Konovalov --- drivers/usb/gadget/legacy/raw_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/raw_gadget.c b/drivers/usb/gadget/legacy/raw_gadget.c index ce9e87f84911..daac1f078516 100644 --- a/drivers/usb/gadget/legacy/raw_gadget.c +++ b/drivers/usb/gadget/legacy/raw_gadget.c @@ -693,7 +693,6 @@ static int raw_process_ep0_io(struct raw_dev *dev, struct usb_raw_ep_io *io, dev_err(&dev->gadget->dev, "fail, usb_ep_queue returned %d\n", ret); spin_lock_irqsave(&dev->lock, flags); - dev->state = STATE_DEV_FAILED; goto out_queue_failed; } @@ -1080,7 +1079,6 @@ static int raw_process_ep_io(struct raw_dev *dev, struct usb_raw_ep_io *io, dev_err(&dev->gadget->dev, "fail, usb_ep_queue returned %d\n", ret); spin_lock_irqsave(&dev->lock, flags); - dev->state = STATE_DEV_FAILED; goto out_queue_failed; }