From patchwork Thu Oct 26 14:24:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 158562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp716444vqb; Thu, 26 Oct 2023 07:26:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnWve8iCr2hYqP4whC8S/k+J2DdH9KNU2Kl4c7lz96Jf3Vtqcw4qEgv2fMlgi+N6GVckGn X-Received: by 2002:a05:6808:ab7:b0:3ad:f5b7:d691 with SMTP id r23-20020a0568080ab700b003adf5b7d691mr19659564oij.18.1698330394986; Thu, 26 Oct 2023 07:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698330394; cv=none; d=google.com; s=arc-20160816; b=Kbz7OkobuSCzOCHF7c6Ng0sZW9kAnqheCj0G7hcSQHV0Xg/wpHBR746yzX53i8NK6U elXvDinJIw+FZwpLOglG7u3zy9xAByjZ6iXueTtXmKEtXhyOZFoQyVHkBIX2Bqr9382q T24ZgZF182BcMnYkZnGiiblQ0FXMBIjus9Be9MLj/nLmEf8ofnvvyFp6J1l1fnKRbjTA Rsg6Iq6vRYCvnVMH00MXLUmH6SyxDCLcWLe85ksIJDcbEqN5HH3YUyqpRGBhSRUPrsPH FEpleETBPPZYDknPz7IYxv+ybaee2GFUISeaIUorSF8p6bntXm/aTBjCu9vzYQ2gphPZ As8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i2fWBBG9mLsogb4ThmIrsmZJLekVVeeZs1stUDz5bLY=; fh=q6dJyfmJ5aFZN8bWGYgWdkT0uTkQR5Dhijz5GpOkTmI=; b=ZfX+B3bpHIBlW1HGNTgP/zoHMrqCFx0f7FraI41qrAHKJh1cWuSgUO5HlhlsYcT8uQ WNVKYZPbKwnxHOPqEuHRBju1knnBpjHRAYv6fDhPphG1/H6sRt9DFVZfK5FdFOGUG7Ri Lr9krM6CmrVQrCnbB7UQIx7o3krsgL4vJStSY/mVPu7tEvw64RsEUZeNPXEczyingKGq P1OPFeqXpVnq8g4zds6Uf2TMxaBU1VQ7Ftfrk/8SilSTNqKEfr6pbbVo2f4uaogZOEOg SnW3wq0y45MH68zKyQA7/k+bWl2uM3M7ckIR5KgfHEhStpKqYdCgh/N9TQR0Yh7RS3So dvCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XBvI+jgF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id m74-20020a25264d000000b00d7757c8c584si16005976ybm.574.2023.10.26.07.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 07:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XBvI+jgF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2FF0E808286F; Thu, 26 Oct 2023 07:25:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345207AbjJZOYO (ORCPT + 26 others); Thu, 26 Oct 2023 10:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjJZOYN (ORCPT ); Thu, 26 Oct 2023 10:24:13 -0400 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DE9C1B2 for ; Thu, 26 Oct 2023 07:24:10 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698330247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i2fWBBG9mLsogb4ThmIrsmZJLekVVeeZs1stUDz5bLY=; b=XBvI+jgFgfBTEd3SPlLvylwAVqtL0K0PzVa2uIgN3YzHxGBA567eUeA+uGIeE8BOOgyigz EEbDUIErsoIamX7fErA4whB0G/ptZmzumkL5O2Zkht57Ue4sMRFqaoyeA1ElapIU6H4wDM Ro3JhkWurPuVf/RtAJtc7ru+TEaPdDA= From: andrey.konovalov@linux.dev To: Greg Kroah-Hartman , Alan Stern Cc: Andrey Konovalov , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] usb: raw-gadget: don't disable device if usb_ep_queue fails Date: Thu, 26 Oct 2023 16:24:00 +0200 Message-Id: <3c5df3dddb67623b4aeb11c5546370363e65d8e2.1698329862.git.andreyknvl@gmail.com> In-Reply-To: <0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698329862.git.andreyknvl@gmail.com> References: <0db45b1d7cc466e3d4d1ab353f61d63c977fbbc5.1698329862.git.andreyknvl@gmail.com> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 07:25:45 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780828491935025855 X-GMAIL-MSGID: 1780828491935025855 From: Andrey Konovalov During device operation, the host might decide to reset a device emulated via Raw Gadget. In this case, if the device emulation code has endpoint requests queued, usb_ep_queue will fail with -ESHUTDOWN. Currently, this disables the Raw Gadget device and makes the emulation code unable to proceed. Do not disable the Raw Gadget device if usb_ep_queue fails. Signed-off-by: Andrey Konovalov --- drivers/usb/gadget/legacy/raw_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/raw_gadget.c b/drivers/usb/gadget/legacy/raw_gadget.c index ce9e87f84911..daac1f078516 100644 --- a/drivers/usb/gadget/legacy/raw_gadget.c +++ b/drivers/usb/gadget/legacy/raw_gadget.c @@ -693,7 +693,6 @@ static int raw_process_ep0_io(struct raw_dev *dev, struct usb_raw_ep_io *io, dev_err(&dev->gadget->dev, "fail, usb_ep_queue returned %d\n", ret); spin_lock_irqsave(&dev->lock, flags); - dev->state = STATE_DEV_FAILED; goto out_queue_failed; } @@ -1080,7 +1079,6 @@ static int raw_process_ep_io(struct raw_dev *dev, struct usb_raw_ep_io *io, dev_err(&dev->gadget->dev, "fail, usb_ep_queue returned %d\n", ret); spin_lock_irqsave(&dev->lock, flags); - dev->state = STATE_DEV_FAILED; goto out_queue_failed; }