[v2,resend,3] ahci: qoriq: Add platform dependencies

Message ID 3b6733f683c13ac02093206e76a3e30c7d045366.1678279668.git.geert+renesas@glider.be
State New
Headers
Series [v2,resend,3] ahci: qoriq: Add platform dependencies |

Commit Message

Geert Uytterhoeven March 8, 2023, 12:49 p.m. UTC
  The Freescale QorIQ AHCI SATA controller is only present on Freescale
Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
symbol, to avoid asking the user about it when configuring a kernel
without Layerscape support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Li Yang <leoyang.li@nxp.com>
---
v2:
  - Add Acked-by.
---
 drivers/ata/Kconfig | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Damien Le Moal March 14, 2023, 12:12 p.m. UTC | #1
On 3/8/23 21:49, Geert Uytterhoeven wrote:
> The Freescale QorIQ AHCI SATA controller is only present on Freescale
> Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without Layerscape support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> v2:
>   - Add Acked-by.
> ---
>  drivers/ata/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b56fba76b43f48f7..42b51c9812a0ebab 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -276,6 +276,7 @@ config AHCI_XGENE
>  config AHCI_QORIQ
>  	tristate "Freescale QorIQ AHCI SATA support"
>  	depends on OF
> +	depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
>  	select SATA_HOST
>  	help
>  	  This option enables support for the Freescale QorIQ AHCI SoC's

Do you want this in fixes or queuing this for 6.4 is fine ?
  
Geert Uytterhoeven March 14, 2023, 12:50 p.m. UTC | #2
Hi Damien,

On Tue, Mar 14, 2023 at 1:12 PM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
> On 3/8/23 21:49, Geert Uytterhoeven wrote:
> > The Freescale QorIQ AHCI SATA controller is only present on Freescale
> > Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
> > symbol, to avoid asking the user about it when configuring a kernel
> > without Layerscape support.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Li Yang <leoyang.li@nxp.com>
> > ---
> > v2:
> >   - Add Acked-by.
> > ---
> >  drivers/ata/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index b56fba76b43f48f7..42b51c9812a0ebab 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -276,6 +276,7 @@ config AHCI_XGENE
> >  config AHCI_QORIQ
> >       tristate "Freescale QorIQ AHCI SATA support"
> >       depends on OF
> > +     depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
> >       select SATA_HOST
> >       help
> >         This option enables support for the Freescale QorIQ AHCI SoC's
>
> Do you want this in fixes or queuing this for 6.4 is fine ?

I guess 6.4 is fine. We've been seeing this message while configuring
our kernels for years, so a few extra weeks won't hurt ;-)

Gr{oetje,eeting}s,

                        Geert
  
Damien Le Moal March 15, 2023, 1:27 a.m. UTC | #3
On 3/8/23 21:49, Geert Uytterhoeven wrote:
> The Freescale QorIQ AHCI SATA controller is only present on Freescale
> Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without Layerscape support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Li Yang <leoyang.li@nxp.com>

Applied to for-6.4. Thanks !
  

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index b56fba76b43f48f7..42b51c9812a0ebab 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -276,6 +276,7 @@  config AHCI_XGENE
 config AHCI_QORIQ
 	tristate "Freescale QorIQ AHCI SATA support"
 	depends on OF
+	depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the Freescale QorIQ AHCI SoC's