From patchwork Mon Dec 25 14:26:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chenguanxi11234@163.com X-Patchwork-Id: 183205 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp416176dyb; Mon, 25 Dec 2023 06:28:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeyhpETXg9idppzMD3XpCrjdSJptzKWEy7ghL9vXwjQUKD8AEMb6U3aaMCnFb1bhNIkb6r X-Received: by 2002:a05:6214:2b:b0:680:112a:366e with SMTP id b11-20020a056214002b00b00680112a366emr991132qvr.111.1703514497235; Mon, 25 Dec 2023 06:28:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703514497; cv=none; d=google.com; s=arc-20160816; b=JyRleCwSh9TfovlpNLaEjflh5FNfPK7J24aZcP5rxozlpu59CQvIX+0bTR1lRkEB9m wjeVb91HjEm5slyKOnFAzNMjRQvJs0ywZeRLmvEFLCHNcZBR13/2MB/Iqp+qSbwNg/NG Hx+zkRWBeEGDZrT60KfQ6w3XWlf5IeR0UwTbfdzPuY8SdYuuDfDJKUgrEvp35Esymplu oyYmz/oBwr/Fk6E7YEmSBf3cf1uwIhBe+p0c8wtBLj6Ucmj6lbUCuAlhlltgTC0u8y2N sP0brw/EOxq/HjAegpvhuebMyrsfUpclbhV4ND4wgK6usjB31OTHlVfz3xVcH/eHngap s7Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3EdazbBuWn+zR00jVC2IdNv8Gvt/eD6wDHkffcQ4WIU=; fh=fESz7eH+6ov3I3HpwHxHgId8cwAtC5FFVoeJhEdI/7I=; b=CNB2hrMyLEdTLck11ckVIpkgCWKAO2B6VwM2wZhtWU0m08pnNXRFbltOsqyJrnYIlD fsq1GSpbkTt23PgqQQkt30gbGfgowHy9fXdn6j/LBjHUet1wWfFUtyTaV/uCR4k/Dd1o eTNVYwKFhN0ROpLjncYTZYt7AmKUpTJFk5UqBgxL/skp0dnCHQ1vmsnmd+Darh9p7nSd xjSn9VoZjCTH1Bfe71tZkfee3dHBwMGm9VK7rXnqRoLT0PwE56MVwqSoVtX3bz3JIWu0 BDBcc/x26/WnoVcjL3nzSj+1Eeq1N+YHIobSGuDdSfARNz1XWdXqgeQNfAJJAW5ej4hJ 92Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=mq7Vgsxv; spf=pass (google.com: domain of linux-kernel+bounces-11084-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11084-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p7-20020a05620a22e700b007811b68d9f4si9526789qki.720.2023.12.25.06.28.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 06:28:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11084-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=mq7Vgsxv; spf=pass (google.com: domain of linux-kernel+bounces-11084-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11084-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0ABDF1C21898 for ; Mon, 25 Dec 2023 14:28:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C96C552F6F; Mon, 25 Dec 2023 14:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="mq7Vgsxv" X-Original-To: linux-kernel@vger.kernel.org Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C0D84524C9 for ; Mon, 25 Dec 2023 14:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=3Edaz bBuWn+zR00jVC2IdNv8Gvt/eD6wDHkffcQ4WIU=; b=mq7VgsxvzC25fxBq8Bs4X EzQG6tcDcREDQJG6Y7Mna7g12xzFIn0TsvWpMpi6Kh85tFnYn2Kl5md1mOVUup6E mEC+O/8PrKlEr68W1fM/6mluL28XGGGH1MFLYRo2OEY8sk9M73QsLy5l3qmDjN8C IHbw04CeO0ZKbzlq559iOM= Received: from ubuntu22.localdomain (unknown [117.176.219.50]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wDHF0wJkYllJEGXGg--.64396S2; Mon, 25 Dec 2023 22:26:18 +0800 (CST) From: chenguanxi11234@163.com To: hanxu5@huaqin.corp-partner.google.com Cc: cgel.zte@gmail.com, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yang.guang5@zte.com.cn, jiang.xuexin@zte.com.cn, Chen Haonan Subject: [PATCH linux-next v2] drm/panel: Simplify with dev_err_probe() Date: Mon, 25 Dec 2023 22:26:15 +0800 Message-Id: <3ac20d355b0b3ad3cedb87c8f4efa819a055624b.1702967834.git.chen.haonan2@zte.com.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: _____wDHF0wJkYllJEGXGg--.64396S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WF1DZFW8CFy3Cr4ftr1DZFb_yoW8Cr1kpF 4UJF9FvF98AFWS939xAF97AF1jya1xKF4YkFs2g397Aw17tr4xWr17GFy0vFW5tFyrXFW5 JF1xXFy3ua4UZr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jM89_UUUUU= X-CM-SenderInfo: xfkh0wxxdq5xirrsjki6rwjhhfrp/xtbBzwVR+mV4G-HRcAABs2 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786264417728041602 X-GMAIL-MSGID: 1786264417728041602 From: Chen Haonan dev_err_probe() can check if the error code is -EPROBE_DEFER and can return the error code, replacing dev_err() with it simplifies the code. Signed-off-by: Chen Haonan Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c index 11b64acbe8a9..e225840b0d67 100644 --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c @@ -854,26 +854,20 @@ static int panel_add(struct panel_info *pinfo) pinfo->pp18_gpio = devm_gpiod_get(dev, "pp18", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp18_gpio)) { - ret = PTR_ERR(pinfo->pp18_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get pp18 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp18_gpio), + "failed to get pp18 gpio\n"); } pinfo->pp33_gpio = devm_gpiod_get(dev, "pp33", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->pp33_gpio)) { - ret = PTR_ERR(pinfo->pp33_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get pp33 gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->pp33_gpio), + "failed to get pp33 gpio\n"); } pinfo->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(pinfo->enable_gpio)) { - ret = PTR_ERR(pinfo->enable_gpio); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get enable gpio: %d\n", ret); - return ret; + return dev_err_probe(dev, PTR_ERR(pinfo->enable_gpio), + "failed to get enable gpio\n"); } drm_panel_init(&pinfo->base, dev, &panel_funcs,