From patchwork Wed Jan 10 15:42:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 186940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp875308dyi; Wed, 10 Jan 2024 07:44:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQc0NtjvyzKXRi9/X2oER2vEh9Fss6Z3bwHx5I+ACWtCp8PmDsi1ET6EqyR84r6YI6h4bQ X-Received: by 2002:a05:6402:b29:b0:558:18c7:478d with SMTP id bo9-20020a0564020b2900b0055818c7478dmr267631edb.21.1704901498873; Wed, 10 Jan 2024 07:44:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704901498; cv=none; d=google.com; s=arc-20160816; b=EY1B5KV3oPFieE/CrUyCC8KJxc8sdOVw+K0d4x/e0m1HwLj5dAHorh4o8P8CTSvSmM tJfoxiKHdSAIdAt7t3PVBEIEy7C9We8+JPPs/Hal+jMMhYR6itWhcCfG8pXir99MDh3v RbyiD/ngBc6nZYgZQSbNqYaEIVTxYg17JO6o63pjZ21HJtBETeDJ8Qk8NI/Xo8mRM6Bz aN5ODo32Ef7noLcNAHs3sVNCS/5gqKUMScJUiOr2qhmbIMBCitN7RQTkF+F1rn88VvGS hfBu/BlgAtIlOBQVlRWf6y7DJ1nDo1fuMSTwV/c2V038MWCS6f26+ET1QdXpfc1i7gf6 h1Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=K1aTs0+mMseiDfhaWn5joCX/U147Je6/F19V+YYTWDs=; fh=SqPi9dDHXtQdEcWVPls+hhXQkWQrXyuO3Tueytp7Eac=; b=FN54lOm0nyEZxcPB5sc51CMfNsL0QZAJOtprMmrI1gaz0YSxXDEhooAve6PCRqTDHi sQc96rMQNguWP75kcxfovlGP19n8zVnh2ZmTTp8diNw3mdjmyzSoNm2tjXARuoY/2B2N uYW8TCMc+/XKhUi13lkHU3aI34uDLRvD2tY65OKAvXTCCidv0MRO7EsVRQzctYK8dQxe CzbkztzADHlKGfMkLeyRmGSHFV1rcRjMcJZRDbjn3CJU0znAdEHaGRSHmWw+/LFtixRa UV9hJ/8Z+T1A1n7p8drWjYfeqGfP4HkGlgE64rFwbdnBW3O5lNpeifVMc7/aZXtIlOSz sATA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22445-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22445-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t24-20020a508d58000000b00557917bfe9asi1840491edt.401.2024.01.10.07.44.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:44:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22445-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22445-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22445-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 68D101F27803 for ; Wed, 10 Jan 2024 15:44:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4DBC4D105; Wed, 10 Jan 2024 15:43:27 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3DE4BAAB for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JJ-A4; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUe-JE; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4P-1e; Wed, 10 Jan 2024 16:43:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] macintosh: windfarm_pm121: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:50 +0100 Message-ID: <36f421f845449a9700f704379105aa5f5db5dd9e.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1549; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ahSfaLmJWp+gaXOKoxuCz1P0tq1CJb3CsTzJGUZXrFg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr7FqpOPEO32kCs+/cZZvDnptqWO72wpcelD /JB3p5/NgqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66+wAKCRCPgPtYfRL+ Th2LCACT1HQcveropFDIDsahtIYtsDE+XV6WXUevICZiD0pzKxhcxb3akPORbEQXzEYUTvloubq wcZbyc7YSBvYeIRo/d5IAUoKT5HNb9dnuHBw8y0A+imiBj3+R1YYgzqU6Was6bqm/qaRP6f10K5 5dr1nVae+0DS4MSFFfMe+H35GenT2N7UjSJBoZHlMyCfjGJI34MnKuTG7zZ1kbIU53tjcFzjBFK EAdF9k+89qA5rY2fN+p89azvsOfnEgtAFANmxUenuxiZaMFSnKALUXhAXJaFOoB8uljmRkKMhNt jYyvxfjW3NhYMGpoIyScrnLV7JBDKcqyfZNPH2PisvlxqL3B X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787718793702088061 X-GMAIL-MSGID: 1787718793702088061 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_pm121.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c index 82500417ebee..cd45fbc4fe1c 100644 --- a/drivers/macintosh/windfarm_pm121.c +++ b/drivers/macintosh/windfarm_pm121.c @@ -992,15 +992,14 @@ static int pm121_probe(struct platform_device *ddev) return 0; } -static int pm121_remove(struct platform_device *ddev) +static void pm121_remove(struct platform_device *ddev) { wf_unregister_client(&pm121_events); - return 0; } static struct platform_driver pm121_driver = { .probe = pm121_probe, - .remove = pm121_remove, + .remove_new = pm121_remove, .driver = { .name = "windfarm", .bus = &platform_bus_type,