From patchwork Tue Nov 1 13:49:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2979154wru; Tue, 1 Nov 2022 06:54:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7SDZHH/DFYs09O7PTVOpi7ulR3J8dUnoN4EY32086caper/qj99RD2bLTeucct/xvE3xcW X-Received: by 2002:a05:6402:718:b0:463:275:4753 with SMTP id w24-20020a056402071800b0046302754753mr17001653edx.160.1667310847850; Tue, 01 Nov 2022 06:54:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310847; cv=none; d=google.com; s=arc-20160816; b=sNpTbtK4Haglhk44dZ4ysPpyxLDajcYK6tCfDCBLCzdyd6E34OCDbGjy+iLkHuh6Oq t9htuz5IjuvKgZ6UhXlIkslpmLSHektJLPE2jjOAAW9Kkv2Z2ru5FqRnar3nibA1Rc7t XLmIwES1iMXKFMdNeChrM2LzQQIPZ7QAZmqUJ2o3fB+UgYzmUIYyTb3UByydtQ8vgAAu jhD8XQ/8BJC3SmqQKFxSL+vASyTjSyTyNvS6Bit/fotm0vll18JHNDA1PgbOg3s95Byr nzr50Dq/nO11OWJ9wgfdKsAjq73vITavxOldjRyQiVovi0Z6HtStFjLyKWiwQXm7g7aM Zdmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ImkROb6VMESw0Ts90uPIj5PfTCehE0u1wRnI0hymNFg=; b=azIvjYNwDP1LQJi0B7Ndnqike53dm6A+dHJmfCQpwCWnKpstTZ+3QtYJh12YoZHZDU 5fMdVrXAOZivVMlwAiuZNf/Hx3jVc4QCPIlwy1bL6CRUK5f13bDEGcidn4Ygc6FG3+Ka yi4Mdx0Bt6VU6lTFdWJvGCY4MlkxD63Yo4bI+EZmVr5gNSIMuouObLuseytHE6Ao87l/ atA7a4HVF99GF03SJvDq62FUdSQ1vv3SwJbNZNAdyxvtqZBZQlWGr9iU857mbhm0eZ3k eQ7b9nj99aQ8VN03PDyF4rEo3atXuccSQzBRJ3uZFTJsbvFGs4ws19b5z8ws3AX3sv5k PQcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DPOe8NTG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a056402320d00b00453b9f11b56si12096864eda.261.2022.11.01.06.53.43; Tue, 01 Nov 2022 06:54:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DPOe8NTG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbiKANtc (ORCPT + 99 others); Tue, 1 Nov 2022 09:49:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbiKANtX (ORCPT ); Tue, 1 Nov 2022 09:49:23 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8726540 for ; Tue, 1 Nov 2022 06:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310549; bh=vFzpmBoau7NBl7FFTlmZYFwyYNbzqXjwJoyGzhQ4sDE=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=DPOe8NTGgDw6DENTKI2h+HFxSxlw2SNLglRET2d/j2LL38nDz9MOmBZYOCTJseT7Z DGvZsdmgbj7RgxGC87zlbSRSrYy3vLAYawlpka1LCMkAJM9oquaf2cMmGkCUlmE8IZ wsuDSA/zkzkWqLCLxa6ZIICZyfrWr2T/1Q5j2atk= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:49:09 +0100 (CET) X-EA-Auth: m4kbEFhoIEjDxdTr7Dx+G1fH9jl1AA03O/KmMzF+amilm1q+pNst2gH1Zw2gw19RPWicZz0R3CJzQnchs6LjAeOi4oRIlVHt Date: Tue, 1 Nov 2022 19:19:05 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/7] staging: wlan-ng: Remove unused struct wlan_ie_tim references Message-ID: <36834007587a2e0ef7a782f5919f3a4c756b7840.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302139437316726?= X-GMAIL-MSGID: =?utf-8?q?1748302139437316726?= Pointer reference to struct wlan_ie_tim is added as a member variable of a structure; However, this references is never used. Remove such unused struct reference. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 12 ------------ 1 file changed, 12 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index 536794bdd1f0..d95ffe0097e9 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -253,16 +253,6 @@ struct wlan_ie_cf_parms { u16 cfp_durremaining; } __packed; -/*-- TIM ------------------------------------------*/ -struct wlan_ie_tim { - u8 eid; - u8 len; - u8 dtim_cnt; - u8 dtim_period; - u8 bitmap_ctl; - u8 virt_bm[1]; -} __packed; - /*-- IBSS Parameter Set ---------------------------*/ struct wlan_ie_ibss_parms { u8 eid; @@ -309,8 +299,6 @@ struct wlan_fr_beacon { struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; struct wlan_ie_ibss_parms *ibss_parms; - struct wlan_ie_tim *tim; - }; /*-- IBSS ATIM ------------------------------------*/