Message ID | 345a61f6cd56e504e1f82ac2328ffa6d89e2d510.1683523370.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1934111vqo; Sun, 7 May 2023 22:48:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4t+/5JOGh4AGXHLg3bMV8VrRgsP0Iokacq38nvqbAImwXavxguZTR1x354QivfDrm9Nqd1 X-Received: by 2002:a17:902:da89:b0:1ac:718c:3fb1 with SMTP id j9-20020a170902da8900b001ac718c3fb1mr3788006plx.19.1683524907559; Sun, 07 May 2023 22:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683524907; cv=none; d=google.com; s=arc-20160816; b=l38YH43oc1OzL+kerqY42e+bb5q38KprwymBLvBCqMNLhnl5lPuGEYecRgYnET2GMA BUiGWwbnGCrq//v8PnkNxEh1JGmKWeBxEDqcBWnD+oD9gG79leW0poYCw8cFci7Pa4Cf ik21+VolZrNHGwFdAlRYWtjtCXVrZ9FiqoJTf6bUG5J1AY6ND+LMjfOJp6DfgsSLUBKr /KCa0ubFK/1/Vrjn3ZuOVc9o2x8oL1T7R/pdU7yY1tD1aJZYnqV175bMMPkbvNEbm2mC BlrDIXiaKNt4/sjY209KW7Nufwq8yCtiq66jKcpH2NTyPHPC7e3IhXznoTRhaphdp3Tb RtkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=bbIz4fvuYCwrvONNktQcI8xnOLrAY5L/8MWYnsnCwvM=; b=A0ZZ2SnaNb+WZz020BjRtWouS2gpBB7rmZt5LSqR1mFNe+J1YCYr2UgpAWIrH1JAFH l8PPaJjUjtVzpxq2EoqYtG1NEdsSPYH7PLOdbWxzbiOyhTvrxeAslAFmNTrZJYT0ZOyQ uDs8F1JvxAbXKkrLOByNmjI8dP6W4oaOCl60izh0jV28JyO/s76m5wUQLtHFh/TWxeX6 3pl34Sd48N4qyrQiZ7uW7tOxfkNY8G1giTR5Mxl/BwVlxwS7qw6ppdARPwLkLQ1m+wwL TlAF90q+bL56TLZpO0ohz9E195uNchB0YWhAqJSszX3zcEmfwiRdaxIP2nKzVtRwTjuW tCMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=N7RseDEg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a170902db0500b001ac39a179eesi7642412plx.646.2023.05.07.22.48.14; Sun, 07 May 2023 22:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=N7RseDEg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232624AbjEHFdX (ORCPT <rfc822;baris.duru.linux@gmail.com> + 99 others); Mon, 8 May 2023 01:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232274AbjEHFdT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 8 May 2023 01:33:19 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2DDA17FEF; Sun, 7 May 2023 22:33:17 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3484dVoN018744; Mon, 8 May 2023 05:33:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=bbIz4fvuYCwrvONNktQcI8xnOLrAY5L/8MWYnsnCwvM=; b=N7RseDEgKxChe0ri95ZWxjAYwuFXZlATtYGs0GiloUb6a2c6rk+uoxfJLERYqex8lkbP lIdg97/iy/MGwFVIHJ4eRM//cnD9vna9Y49x/Vg92uxmRLU8wilKs65fzb7WJWD2iM0i ucJV9BQNJQcIVcLdOJRWl7UYzvGbXk2RGkVcFhN3fd110971Lm79CZyOhi1TYyLK30gN yCMRDilqzS9Eu3cl/5aDeuEA0e3R3ETN0MUcX9APL4Ia0dUZKuwa8NxVZz9/A/QnQzjP xjew9BkZ1XYfEC1y6yP9WbHb5Uv2xQRd2dus3hU4ahBoQyLmXUqHY1jBZ2BVBbV07SHd Og== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qdg6hjr5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 May 2023 05:33:10 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3485XAVd014738 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 May 2023 05:33:10 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 7 May 2023 22:33:05 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <amitk@kernel.org>, <thara.gopinath@gmail.com>, <rafael@kernel.org>, <daniel.lezcano@linaro.org>, <rui.zhang@intel.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: Praveenkumar I <quic_ipkumar@quicinc.com>, Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v2 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible Date: Mon, 8 May 2023 11:02:38 +0530 Message-ID: <345a61f6cd56e504e1f82ac2328ffa6d89e2d510.1683523370.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1683523370.git.quic_varada@quicinc.com> References: <cover.1683523370.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: SSvbwWrEQeGJHkPKfwEo9VacgMb1-gH- X-Proofpoint-ORIG-GUID: SSvbwWrEQeGJHkPKfwEo9VacgMb1-gH- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-08_02,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305080038 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765303813818768419?= X-GMAIL-MSGID: =?utf-8?q?1765303813818768419?= |
Series |
Enable IPQ9574 TSENS support
|
|
Commit Message
Varadarajan Narayanan
May 8, 2023, 5:32 a.m. UTC
From: Praveenkumar I <quic_ipkumar@quicinc.com> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- [v2]: Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> for the tip to make qcom,ipq8074-tsens as fallback. --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Comments
On Mon, 08 May 2023 11:02:38 +0530, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > [v2]: > Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > for the tip to make qcom,ipq8074-tsens as fallback. > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: [error] syntax error: expected <block end>, but found '-' (syntax) ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:69:11: [warning] wrong indentation: expected 12 but found 10 (indentation) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/thermal/qcom-tsens.example.dts' Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: did not find expected key make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/thermal/qcom-tsens.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml ./Documentation/devicetree/bindings/clock/qcom,gcc-ipq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: did not find expected key /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml: ignoring, error parsing file make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/345a61f6cd56e504e1f82ac2328ffa6d89e2d510.1683523370.git.quic_varada@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 08/05/2023 07:32, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Acked-by: Rob Herring <robh@kernel.org> Drop the ack, it's a bigger change. > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > [v2]: > Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > for the tip to make qcom,ipq8074-tsens as fallback. > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index d1ec963..ea67cf9 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -64,8 +64,11 @@ properties: > - const: qcom,tsens-v2 > > - description: v2 of TSENS with combined interrupt > - enum: > - - qcom,ipq8074-tsens > + - const: qcom,ipq8074-tsens > + - items: > + - enum: Please test the patch after changes and before sending. Missing indent which test would point out. Best regards, Krzysztof
On Mon, 08 May 2023 11:02:38 +0530, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > [v2]: > Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > for the tip to make qcom,ipq8074-tsens as fallback. > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: [error] syntax error: expected <block end>, but found '-' (syntax) ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:69:11: [warning] wrong indentation: expected 12 but found 10 (indentation) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/thermal/qcom-tsens.example.dts' Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: did not find expected key make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/thermal/qcom-tsens.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml ./Documentation/devicetree/bindings/clock/qcom,gcc-ipq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:67:9: did not find expected key /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml: ignoring, error parsing file make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml See https://patchwork.ozlabs.org/patch/1778256 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index d1ec963..ea67cf9 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -64,8 +64,11 @@ properties: - const: qcom,tsens-v2 - description: v2 of TSENS with combined interrupt - enum: - - qcom,ipq8074-tsens + - const: qcom,ipq8074-tsens + - items: + - enum: + - qcom,ipq9574-tsens + - const: qcom,ipq8074-tsens reg: items: @@ -277,6 +280,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens then: properties: interrupts: @@ -292,6 +296,7 @@ allOf: contains: enum: - qcom,ipq8074-tsens + - qcom,ipq9574-tsens - qcom,tsens-v0_1 - qcom,tsens-v1 - qcom,tsens-v2