diff mbox series

[next,v2,4/5] minmax: Allow comparisons of 'int' against 'unsigned char/short'.

Message ID 34492660a17e44c19a98c4f0f37f6320@AcuMS.aculab.com
State New
Headers
Series minmax: Relax type checks in min() and max(). |

Commit Message

David Laight July 28, 2023, 2:52 p.m. UTC 
  Since 'unsigned char/short' get promoted to 'signed int' it is
safe to compare them against an 'int' value.

Signed-off-by: David Laight <david.laight@aculab.com>
---
v2: No change
 include/linux/minmax.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index 4c77ac9ed284..7d3ad9cbbff6 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -20,7 +20,8 @@ 
 	(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
 
 #define __types_ok(x, y) \
-	(is_signed_type(typeof(x)) == is_signed_type(typeof(y)))
+	(is_signed_type(typeof(x)) == is_signed_type(typeof(y)) ||	\
+		is_signed_type(typeof((x) + 0)) == is_signed_type(typeof((y) + 0)))
 
 #define __cmp_op_min <
 #define __cmp_op_max >