From patchwork Fri Dec 8 16:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175889 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555712vqy; Fri, 8 Dec 2023 08:09:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQXmPsUOqKN6GtbQ9dFz1WBCs5Bu351w8rjJU/XeJRinlni+2Bqed01O26UOhFBbbFsT27 X-Received: by 2002:a05:6a20:914b:b0:190:228e:4c11 with SMTP id x11-20020a056a20914b00b00190228e4c11mr220876pzc.90.1702051784980; Fri, 08 Dec 2023 08:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051784; cv=none; d=google.com; s=arc-20160816; b=m994c2+YSlUcg2pD/4NK5btS2VDa82TXithGUoyiaiQIz46XLuJnWR86WBBH0jPmmv Y6uGJ0C3PbJqwhJh6PqJHZo2MlzYJH9D1mD72w1m8QzTRKa/yz/SAZKWHCXcLR3ls/gU UNIBW9VKeHXhfW0vFhHWz28PINynUX27vB4ayE0XNGm8rWPGmAsU3hF/TRjfryw4g9YN 9uKev9kwnRf5tKSwefR23mg5EAzciNTkAS6JymaxRrqPVELEVK2pbhZ/Wn5zvPj6DWa8 0euuRlAVUuH77JVJPRy78zKOktcc/D/vUFLzlICk6cFY8sCoElCVLwOqJJtqanaqS4qJ Apyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bnUrJ75KR7JY0FX+rTQii19xqhlihImvM0hTVxuC2G4=; fh=HkEJnMNLsUwGqICrtg0bQUhKc/ThDn5Y5tdodny3s5A=; b=bHk7nnI3sMB2Ro380oJhQ0giX2cyW799pGJREOOHG4YfadSm3wQZHSaesF9ZdaKIUi KvbYYTNuQMS3iq7T9zkxD0HiI3yZgbZRL1no8vqayMECQjJ6Ty01ysbqM5yYzC5+Cm6L /lV9FZ5RgLOjvI8QxVE7131mxLnnEuIsI52FHv3P4ormOFKHh7MtIGGrmn3nelMABC8K kuFKuiaH7OnViznlMkXEkHfv4Yj1dh0yOqJkiI/hxVztfTstxhrYq5eEPArETLp9riUg YJB0MNaf7R9EgEUJvtdO+PvNH6c+mDX8prKChLEq15H2S4lEsdUT3upL3g/AnoSWjE5F klJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bz39-20020a056a02062700b005c67e10f240si1826249pgb.312.2023.12.08.08.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 193DC82E10A7; Fri, 8 Dec 2023 08:09:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573889AbjLHQJc (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbjLHQJQ (ORCPT ); Fri, 8 Dec 2023 11:09:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B171994 for ; Fri, 8 Dec 2023 08:09:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00007w-ET; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0F-5z; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPb-00GUaC-Su; Fri, 08 Dec 2023 17:09:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , Kalle Valo , "Steven Rostedt (Google)" , Paolo Abeni , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/7] pcmcia: bcm63xx: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:06 +0100 Message-ID: <33611a4245b4dabc609a75cf0e0db5e06e9a6fc8.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1822; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=rK09bKbPy9IbxRyCb0eChVFpuUmGGmru+y/jU63xJqA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9qf3TyhbKQ0U4p75u1hl/4Mrffgxd57x3kV GXFT44SdOaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/agAKCRCPgPtYfRL+ TijcB/wOCUrzq/j4P2FtkyFicRvWJMrTqnRvDntTRY+jRqWW8O9B9u/G9kdrd4QkYgIXnEGIk03 lhfIIUesDJOtV4xZUtbpdMcmm7mddVSP3iRV5YjnCNiQp7Y4rq3bkmH5frSgnVq5tEn9syzl12W p83Rx2OUCTw4RSxDrdqxSvkbDSR4anVM7uQN4xs0P8pwUtSbJnjOKtnUy88iF4Kq9LlDFy0UtfW wtj/psLY47/K9fM3MEHJfisa+aULQ0ILBTACcVFuGG8tdQUn/+xWP9HFmEy2MR3ycAd2AziQFlu Pt9Xa4e/kgBi2QTe4s6yfHO9anTFAySqvgQupJp6X4sR3muf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730652376724901 X-GMAIL-MSGID: 1784730652376724901 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/bcm63xx_pcmcia.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/bcm63xx_pcmcia.c b/drivers/pcmcia/bcm63xx_pcmcia.c index dd3c26099048..a5414441834a 100644 --- a/drivers/pcmcia/bcm63xx_pcmcia.c +++ b/drivers/pcmcia/bcm63xx_pcmcia.c @@ -437,7 +437,7 @@ static int bcm63xx_drv_pcmcia_probe(struct platform_device *pdev) return ret; } -static int bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) +static void bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) { struct bcm63xx_pcmcia_socket *skt; struct resource *res; @@ -449,12 +449,11 @@ static int bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) res = skt->reg_res; release_mem_region(res->start, resource_size(res)); kfree(skt); - return 0; } struct platform_driver bcm63xx_pcmcia_driver = { .probe = bcm63xx_drv_pcmcia_probe, - .remove = bcm63xx_drv_pcmcia_remove, + .remove_new = bcm63xx_drv_pcmcia_remove, .driver = { .name = "bcm63xx_pcmcia", .owner = THIS_MODULE,