From patchwork Fri Feb 17 12:10:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 58536 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp853052wrn; Fri, 17 Feb 2023 04:18:51 -0800 (PST) X-Google-Smtp-Source: AK7set+ii5pkrCbeo/0BMpVwNiHk+76/FjiJhfaJGZnODvCsBkccRS4uXiOWWYKk4aPDQSDrHTqT X-Received: by 2002:aa7:cd84:0:b0:4ac:c5e5:3f33 with SMTP id x4-20020aa7cd84000000b004acc5e53f33mr21939edv.0.1676636331382; Fri, 17 Feb 2023 04:18:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676636331; cv=none; d=google.com; s=arc-20160816; b=eubpwKjm7Cj/q86fq1hteuLjg4qPmS4T8mcPzmRfyh5h2fxFiUqEW/N4IGHb6cg8w1 uhRqjOz0f/5QHKRoREHEZmW4IDwrlCOw/vvYSNBTCpjyvYnUv/WW/B4muprEQ6MxmMP6 nCbXKAePU7JcmeVhcexeQnNUy8xo4jq7hPnfwv8E0uC9rAxyPXJ4pjbLcEnUagcJuXTI vhrhynVPXz28u8pxQexmIR4VV/pRa1UWtDq+uHDEdy5fqo7+oSYLNsmrnsMLOB2c94qS acEMkdiauCMB9N/uHCKGzwQX/P8i5X/4gaHCnCPUeO/J/e+YHDOURvyW9boY4eI6MBmM zUhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4V3UrxwPFulVkoaTSh2/0V7v4vzy2jL7sVfRzU2pyAc=; b=PO6hd0EemmiPCVESuOifElcS9iDCKT7Ont0EkGk52UYjz8UL7BYXlhrvMfpzI/NvJ1 CnUgFJ14WzXl433wXu44JfbEz1zAIMor+wCvupYI3AtgzGoCqLi0dmWyc+9+vjrSWH7X NdtpUZqY/+Ykiz4Jkh83Ql84VJPKVIDmPyCYCO1FHiIrqxGf0LtfWATlGxW6CEl8eN6q P/TXBHAQSuJm/l/6KwniYG4QQEqhhve05fBeqXnw8rHtJzmbDyiD1XUEEmTgSmhJt7pP e/2in4vNKokX2bBQ99QHqfMGVbALSd9r//hjKrmkC3SptjvMJRp2P8+RyXb1J32/dFlO LuHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020a05640208d600b004aac9421ba0si5735347edz.372.2023.02.17.04.18.28; Fri, 17 Feb 2023 04:18:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbjBQMKy (ORCPT + 99 others); Fri, 17 Feb 2023 07:10:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjBQMKw (ORCPT ); Fri, 17 Feb 2023 07:10:52 -0500 Received: from smtp.smtpout.orange.fr (smtp-17.smtpout.orange.fr [80.12.242.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9546D64B33 for ; Fri, 17 Feb 2023 04:10:50 -0800 (PST) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id SzZgpJS69fKYFSzZgpVsgJ; Fri, 17 Feb 2023 13:10:48 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 17 Feb 2023 13:10:48 +0100 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: "Rafael J. Wysocki" , Len Brown Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-acpi@vger.kernel.org Subject: [PATCH] ACPI: EC: Reorder fields in 'struct acpi_ec' Date: Fri, 17 Feb 2023 13:10:46 +0100 Message-Id: <334a5e2d8c9a05ce7cbac126bfbc6b39d05e1c9c.1676635829.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758080617714144609?= X-GMAIL-MSGID: =?utf-8?q?1758080617714144609?= Group some variables based on their sizes to reduce hole and avoid padding. On x86_64, this shrinks the size of 'struct acpi_ec' from 520 to 512 bytes. This size is much better when the struct is kmalloc()'ed. Signed-off-by: Christophe JAILLET --- Using pahole Before: ====== struct acpi_ec { acpi_handle handle; /* 0 8 */ acpi_handle address_space_handler_holder; /* 8 8 */ int gpe; /* 16 4 */ int irq; /* 20 4 */ long unsigned int command_addr; /* 24 8 */ long unsigned int data_addr; /* 32 8 */ bool global_lock; /* 40 1 */ /* XXX 7 bytes hole, try to pack */ long unsigned int flags; /* 48 8 */ long unsigned int reference_count; /* 56 8 */ /* --- cacheline 1 boundary (64 bytes) --- */ struct mutex mutex; /* 64 160 */ /* --- cacheline 3 boundary (192 bytes) was 32 bytes ago --- */ wait_queue_head_t wait; /* 224 88 */ /* --- cacheline 4 boundary (256 bytes) was 56 bytes ago --- */ struct list_head list; /* 312 16 */ /* --- cacheline 5 boundary (320 bytes) was 8 bytes ago --- */ struct transaction * curr; /* 328 8 */ spinlock_t lock; /* 336 72 */ /* --- cacheline 6 boundary (384 bytes) was 24 bytes ago --- */ struct work_struct work; /* 408 80 */ /* --- cacheline 7 boundary (448 bytes) was 40 bytes ago --- */ long unsigned int timestamp; /* 488 8 */ enum acpi_ec_event_state event_state; /* 496 4 */ unsigned int events_to_process; /* 500 4 */ unsigned int events_in_progress; /* 504 4 */ unsigned int queries_in_progress; /* 508 4 */ /* --- cacheline 8 boundary (512 bytes) --- */ bool busy_polling; /* 512 1 */ /* XXX 3 bytes hole, try to pack */ unsigned int polling_guard; /* 516 4 */ /* size: 520, cachelines: 9, members: 22 */ /* sum members: 510, holes: 2, sum holes: 10 */ /* last cacheline: 8 bytes */ }; After: ===== struct acpi_ec { acpi_handle handle; /* 0 8 */ acpi_handle address_space_handler_holder; /* 8 8 */ int gpe; /* 16 4 */ int irq; /* 20 4 */ long unsigned int command_addr; /* 24 8 */ long unsigned int data_addr; /* 32 8 */ bool global_lock; /* 40 1 */ bool busy_polling; /* 41 1 */ /* XXX 2 bytes hole, try to pack */ unsigned int polling_guard; /* 44 4 */ long unsigned int flags; /* 48 8 */ long unsigned int reference_count; /* 56 8 */ /* --- cacheline 1 boundary (64 bytes) --- */ struct mutex mutex; /* 64 160 */ /* --- cacheline 3 boundary (192 bytes) was 32 bytes ago --- */ wait_queue_head_t wait; /* 224 88 */ /* --- cacheline 4 boundary (256 bytes) was 56 bytes ago --- */ struct list_head list; /* 312 16 */ /* --- cacheline 5 boundary (320 bytes) was 8 bytes ago --- */ struct transaction * curr; /* 328 8 */ spinlock_t lock; /* 336 72 */ /* --- cacheline 6 boundary (384 bytes) was 24 bytes ago --- */ struct work_struct work; /* 408 80 */ /* --- cacheline 7 boundary (448 bytes) was 40 bytes ago --- */ long unsigned int timestamp; /* 488 8 */ enum acpi_ec_event_state event_state; /* 496 4 */ unsigned int events_to_process; /* 500 4 */ unsigned int events_in_progress; /* 504 4 */ unsigned int queries_in_progress; /* 508 4 */ /* size: 512, cachelines: 8, members: 22 */ /* sum members: 510, holes: 1, sum holes: 2 */ }; --- drivers/acpi/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 06ad497067ac..acfdd23c8dec 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -179,6 +179,8 @@ struct acpi_ec { unsigned long command_addr; unsigned long data_addr; bool global_lock; + bool busy_polling; + unsigned int polling_guard; unsigned long flags; unsigned long reference_count; struct mutex mutex; @@ -192,8 +194,6 @@ struct acpi_ec { unsigned int events_to_process; unsigned int events_in_progress; unsigned int queries_in_progress; - bool busy_polling; - unsigned int polling_guard; }; extern struct acpi_ec *first_ec;