From patchwork Wed Jan 25 20:08:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 48294 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp463814wrn; Wed, 25 Jan 2023 12:09:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXuenGXfjBRTe64aop1/+Aw/+WUXVpJhZbKpG6PWE6XPU9eO1TcQyto2iQpG8PU0a10lsCnv X-Received: by 2002:a17:907:7f14:b0:84d:3e5b:7c02 with SMTP id qf20-20020a1709077f1400b0084d3e5b7c02mr40698647ejc.22.1674677385712; Wed, 25 Jan 2023 12:09:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674677385; cv=none; d=google.com; s=arc-20160816; b=vmcQbAzGAaEEaIiGUWJ0ctlQrb98hELx+XrtXvoLiEi5k2F2VDis6WCR4LSwT5caVx 8PetD+GsfLEDyFYxO2Gq/4jGABlnedibVqeLD/CgNgIzyhbYb58hLAVx2hyxhUcdiwna 1ulOPolt2NSu1Z1JxO3aUElO/vLZTRiq+SMF6iBhMILKzM0SJWYmWo78P4/XEbBqK7E4 Fc2WFPlWINt5Qk91Ji7gwQtYNWJUbBzd7MPE14asgMQ2NU8CduWskEtrp4UGr92VhxVb jrgspA/7AVznUcrrn40y+zhGsA5xKgkBmwpikSXr8FUkuGNfNuQt8WMrd1vDw0/8YoF9 N3Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=Hpf806jKkOcNu6DxvbPxcyWjzjSsCPE5qhWedvUb+3R8V/H3Rrb6fN8ZvV3PPWF8TC pBmrpAQ59NyuGAleP7EsK5Uvl6d4GvwYvyRNeJcJ5551SMvQRMFUnB9cov3PGypGNlxj EhbC/xS5stFQVbpo0/RglCntF9xgojrOLrZOaCzVeZJ+p4c57Kuxjcyi2C+jYavChxU+ dBo/gNfaC7RKq9+IqeJnZpc6NYv/jCFBs9Ul0sb44xlVKhEEL6JscgUUBuIu62gjVV4m RJPU1HAKORxUgw4IvsZRAkvocG19HV2VEnoqAPoYu0LGp6hIHw0CSkNeyr0Lzy1BaDqZ 4pjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lZjNXxnG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a17090610c700b0084d45d2e5ffsi7711637ejv.566.2023.01.25.12.09.21; Wed, 25 Jan 2023 12:09:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lZjNXxnG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjAYUIw (ORCPT + 99 others); Wed, 25 Jan 2023 15:08:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236141AbjAYUIu (ORCPT ); Wed, 25 Jan 2023 15:08:50 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C54BA5D11F for ; Wed, 25 Jan 2023 12:08:35 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so2134059wmc.1 for ; Wed, 25 Jan 2023 12:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=lZjNXxnG0NwYLfZGiRVHlHOqlnjaMPZ1JSID3VMPnHtvUjKMLeD8kgH7GkoAlRPX/d lZsrQftznCgl+6B9zFnjD0+R9mTZi5VWhbUqy+4Dn9yPmXaY6jyYgA05zUKIL4QREQK5 860WaQ3CHo79PSRDa601F2pA1CnldWLfwjFHehb6YLT3RlbdoLrWrgFfXYGOaht7gepv INCRHLR1CmWe+DN+syp7s+t92FtOLxWMVgWyvQN3aeNBwzg5pTrvlQhgsWUr4Mnq5ALl Pjus4IqrryktYkJ6L4HFew8xH3VG4y/sS7B0imQPMEb4osTROToIXx1df3catPY43Fdy Wg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=0ZCU4ps7CDjyUNain9SU2rew4DFE91VNZRxynAxv8LdtU23tDZKTdNl6b6zKk4gUNy StzqNr8QHamfWRlv/idz7jV98o8jl9DOSLZbSXRWOfTZOziyIZAGtSUTEziyRBRWIpT7 yr5mhKozdO0FiZfsbWbHiQl6W6slbLJn1w3QHdaCXQMoA3FmI0bqIqQB8KFTp8biPWjQ wOWS6iT1YZEHVrGNpWTnB1y06sc4585ehBPfrFyl9fECxPsFW25zu0NYsUoa2VUDVTv/ wDxaQfEyGMgLNLIta64IVwqt45JPCdjwjcXEy31Y0tMMXBzWSqICiVt0FkWHXDYPtY/z 6Kig== X-Gm-Message-State: AFqh2ko0tLlXmTbJ1OsquExs0W6O2GAz9rq1n5a+0YKqfYXKycPIq+1L O1x9qRuCrd7tj2zpxE4XBWk= X-Received: by 2002:a05:600c:3ba8:b0:3d9:8635:a901 with SMTP id n40-20020a05600c3ba800b003d98635a901mr8573813wms.3.1674677314209; Wed, 25 Jan 2023 12:08:34 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id bi5-20020a05600c3d8500b003db0bb81b6asm2751098wmb.1.2023.01.25.12.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:33 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:31 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/11] staging: rtl8192e: Remove unused variables rxdatacrcerr and rxmgmtcrcerr Message-ID: <32c9183fa2f4edd24ae6f93d56b808eb1821832b.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756026514048655661?= X-GMAIL-MSGID: =?utf-8?q?1756026514048655661?= rxdatacrcerr and rxmgmtcrcerr are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 ------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 605146c840c7..e0d0f4faeca7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1926,13 +1926,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) priv->rtllib->LedControlHandler(dev, LED_CTL_RX); - if (stats.bCRC) { - if (type != RTLLIB_FTYPE_MGMT) - priv->stats.rxdatacrcerr++; - else - priv->stats.rxmgmtcrcerr++; - } - skb_len = skb->len; if (!rtllib_rx(priv->rtllib, skb, &stats)) { diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 82cbc7f5536a..f91a6f7a4e0a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,8 +183,6 @@ enum reset_type { }; struct rt_stats { - unsigned long rxdatacrcerr; - unsigned long rxmgmtcrcerr; unsigned long rxcrcerrmin; unsigned long rxcrcerrmid; unsigned long rxcrcerrmax;