From patchwork Thu Jun 22 09:21:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 111553 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4937444vqr; Thu, 22 Jun 2023 02:33:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47lu61jkOFOFa3yANNvs3lh/wRXwQnGKENzLJ7IdRNFK230Ug4lK+etrV2iRSlN33bWJRN X-Received: by 2002:a05:6358:e820:b0:129:c3a3:5efd with SMTP id gi32-20020a056358e82000b00129c3a35efdmr9216272rwb.24.1687426401747; Thu, 22 Jun 2023 02:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687426401; cv=none; d=google.com; s=arc-20160816; b=Seb0etC94Kmfdp+9bjO4wp2R2J0+bRYs7GB2Y6NNsMoe445VUTy9cuSFCfuySJAOKG I0iw+mUj7ju19jCb4uqjtHGIa7ilES17Tslv97bwuz6j6jbk6uDwswMfc47WKqY8MbGK S8ecQ0DXsE6PN2gvXAjecLBme013TAYzn8O1jGOfMjNuArWOuQp/VYSach63ofZXBAqb TVUsdOa67I+OcJnTT5GltZa1NiQJFr92VzBbMTGe5B9Y8Z5iGt2DA5IuBtz1ocbJxcCH SqsLYrfePaYaQB6+MLRLrodusXc0obAQ7xGvxzSHOpzLREPnuY2VDqYicA2pbQuoOgPv 9kQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=p9jOkTmJpLk3V1q99NmTvQHYrZUkix/bERb6KE3DNWc=; b=Y+2xHHmtf8kQeR1eTABsaYDB1X4CIsst/XAn+1Be1qn7QyoyDKXDV8eXN0F45YhOaC uZZBk5S7lH1GXfga9yldYOmwK/fTR5/3oS+9s+JEv5MeCwPQRBq3USUG9Y6lTjLxADLj xLBTm8dBJZ4fCwhGaGrfLXNIM7U6yWwU/6c795A3bxbaim8O1I+Eao1mzZX1A1gAamlM SnVDSz+ViUW81qn3gior6BEujomp6Dft4NrBWxEX1/43DLB7Azo6w41L8O4GjU9XHcue c1fg/fdLhH5dtov9vaHZSLSxGNKMI4i/B711PE2k+DyjtuQ8JRio8U8J7oUXzvZjb2Uk mQ2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b00543cc3151f9si2934434pgq.461.2023.06.22.02.32.58; Thu, 22 Jun 2023 02:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231937AbjFVJas (ORCPT + 99 others); Thu, 22 Jun 2023 05:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbjFVJ3q (ORCPT ); Thu, 22 Jun 2023 05:29:46 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D84FA422F for ; Thu, 22 Jun 2023 02:22:46 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by baptiste.telenet-ops.be with bizsmtp id C9Nj2A0021yfRTD019Njq7; Thu, 22 Jun 2023 11:22:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qCGWX-000BvZ-DR; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qCGWY-003Vvx-WD; Thu, 22 Jun 2023 11:22:43 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 05/39] drm: renesas: shmobile: Correct encoder/connector types Date: Thu, 22 Jun 2023 11:21:17 +0200 Message-Id: <2f44ca769d4f524ea475123ca987472589257e0f.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769394826246071965?= X-GMAIL-MSGID: =?utf-8?q?1769394826246071965?= The first encoder output on the SH-Mobile LCD Controller is a DPI parallel bus. However, at the time of introduction of the driver, no encoder or connector types were defined yet for the DPI parallel bus, hence the driver used the ones for LVDS instead. Adjust the types accordingly. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index 11dd2bc803e7cb62..fbfd906844da490c 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -598,7 +598,7 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev) encoder->possible_crtcs = 1; ret = drm_simple_encoder_init(sdev->ddev, encoder, - DRM_MODE_ENCODER_LVDS); + DRM_MODE_ENCODER_DPI); if (ret < 0) return ret; @@ -684,7 +684,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, connector->display_info.height_mm = sdev->pdata->panel.height_mm; ret = drm_connector_init(sdev->ddev, connector, &connector_funcs, - DRM_MODE_CONNECTOR_LVDS); + DRM_MODE_CONNECTOR_DPI); if (ret < 0) return ret;