From patchwork Wed Dec 27 21:02:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666612dyb; Wed, 27 Dec 2023 13:05:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaHNIIM/6p2SUKFkvJKGEfl6jCASDQrA7KDu5c1q3InbsD4ZP5BmZjY0sEhWsh2QbAz4ll X-Received: by 2002:a50:9fa7:0:b0:554:d2c2:8d4e with SMTP id c36-20020a509fa7000000b00554d2c28d4emr4426409edf.37.1703711140038; Wed, 27 Dec 2023 13:05:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711140; cv=none; d=google.com; s=arc-20160816; b=cOMy9b2EyZXP9AkN11DwjLZfmUr3LE8PkEupNtkNu7JnmCqqpwch4LIfj+MsPtJ3P6 A4m/nzqZBYd3XVLAxBd+XKfCdB1UyBZJYENCR6c0mIx0HaP+yT2WFDC2/iGRuCyi83hA mBNVFDDHjsynchOi1OpI9fxu1qziAvz7MMY2fBcwxhnc4H8OoJ6FpMFgANgQLcZbkfoE CWq7Vf/hKiDp10OeI72dj5j8cPwTwAarnlKORSIWQPFXfKtxo73KM/fxEUR0XNJ11otd Zi2JtaIXbrYZ51KmtSbV/sVLb3jwJs6WiOINlIIO+RSGjWJZiVAx40lzizXemBDQBIiY CKpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ZMfHATbexAadZcA6X4BGrhKCUZWPCrXSgj6aAqFtKYE=; fh=9chBk7rP0At9vpKOtJJ+hb9FjsBdhkqafrLnyi3Jhvg=; b=DnDNn8AS55xOQRpo/+PFvP6o+eL4gwVncY4thwpsRLzI2UCt2GcG0qAaWv8TD5hOAb h7RW9BBgoTcWbb8ADyAAURETmrMkbSn6i8VTEI5TagS1TRepB1JRR5tH8iBcaGX0Ti+I 119s/XhgBBDaS89XNUOfh8lGTH/pg7klorGh2iSeO2GDpG023v5D2obAP1qhiN0sZFJ9 bnl+a7iL+UA79XjXucYevYEMGYl98tLuwg3NMYP3J4Mdl+tSVJ9sAYq5WNChOXeGFDe8 OjJYShr15kk+06gLK3smbxnF2dYS4b2t98KlcBHnqP+O8cKpg/yC6D4vMCb1XQ6TxKbT XjXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12270-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12270-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 17-20020a508e11000000b0055400e1f047si6568203edw.311.2023.12.27.13.05.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:05:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12270-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12270-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12270-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A5E041F231D0 for ; Wed, 27 Dec 2023 21:05:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A39784D59B; Wed, 27 Dec 2023 21:03:08 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE9B34A980 for ; Wed, 27 Dec 2023 21:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3M-0000sn-1M; Wed, 27 Dec 2023 22:03:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3J-001wFJ-Uq; Wed, 27 Dec 2023 22:02:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3K-001ZVs-36; Wed, 27 Dec 2023 22:02:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 10/12] mailbox: sun6i-msgbox: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:38 +0100 Message-ID: <2db7ef94aa35587980697405ec373e0b7bb70466.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1881; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=N/W8lZej+FeOqTdwnnoNmYqEIad8ynzkdcOjXSzw2ts=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDwoMJLjfKm4Cc4/ADr3P0UTr8GXSsZIJG6W H2DM2dIZ4+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ8AAKCRCPgPtYfRL+ TsNlCAC5RWomH9b61vsKXO9seVB+66mp+g78kJnbVAs+m+UWgdssUkxqjQl0IZqc0OlSudVdslX IjnVHkdr/ZzzYZVJVgcTzR4JNZhouUYJDLnKihWTElEo8ye0FJxgHAV9LiHuSoH8NBPRx4vlWOI 1RhV+oIdSY6PtwA5hL6W6T7El2gulfzOCdKPq/q0nawWkBKRj3PEbof8Y5LXTeF+0AV4H/Ip6YR PNVh8GG59D3SPnPZZHLaJYRxWlGwbM/xAJhISVju1WUjnJ7FuoJbXhxMux/7E5dNjCVJ5Dsa2Mr yjFXCkWDvipZ6lhZZsg/qGnz7wXC2tlUUaziuZWURgX0ZjHE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470612646853878 X-GMAIL-MSGID: 1786470612646853878 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- drivers/mailbox/sun6i-msgbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/sun6i-msgbox.c b/drivers/mailbox/sun6i-msgbox.c index 7f8d931042d3..3dcc54dc83b2 100644 --- a/drivers/mailbox/sun6i-msgbox.c +++ b/drivers/mailbox/sun6i-msgbox.c @@ -287,15 +287,13 @@ static int sun6i_msgbox_probe(struct platform_device *pdev) return ret; } -static int sun6i_msgbox_remove(struct platform_device *pdev) +static void sun6i_msgbox_remove(struct platform_device *pdev) { struct sun6i_msgbox *mbox = platform_get_drvdata(pdev); mbox_controller_unregister(&mbox->controller); /* See the comment in sun6i_msgbox_probe about the reset line. */ clk_disable_unprepare(mbox->clk); - - return 0; } static const struct of_device_id sun6i_msgbox_of_match[] = { @@ -310,7 +308,7 @@ static struct platform_driver sun6i_msgbox_driver = { .of_match_table = sun6i_msgbox_of_match, }, .probe = sun6i_msgbox_probe, - .remove = sun6i_msgbox_remove, + .remove_new = sun6i_msgbox_remove, }; module_platform_driver(sun6i_msgbox_driver);