From patchwork Fri Dec 22 22:50:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182790 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371169dyi; Fri, 22 Dec 2023 14:52:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs1ljFpx3eR1DV1pgNxmFZFHQxqvjsFWO0Ko/F6TyQnrH7UTpFgo8ujCa3pnTZBT90iLfY X-Received: by 2002:a05:6870:d60f:b0:204:492b:c1ce with SMTP id a15-20020a056870d60f00b00204492bc1cemr2013335oaq.82.1703285534401; Fri, 22 Dec 2023 14:52:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285534; cv=none; d=google.com; s=arc-20160816; b=YmXEVRZ7oWdPpH5wdobyerucCo6M9gbOmGPuIEy69jbc7t4ABFz5hN01QLOC4tqIn7 zHdwRREGY65T08gJihdVc7mqhHcnC/rxy6mNFdjGOiZDjqTzV/xHEOIxRBXZAAZj1bMG kvC3iv/qPMXiD5y8E/gO8TzqrTysYU9xRExqmGKHsDbsjmiyhrIEbEN0gPYRdYn2rFLc 0tx5vzjZP348zSuK3BKuKVVoIiJt2LNbV09TUEgv0z+D8WtPJBgRgZpc87OHkMtBQDaK 78X/dF+e5xym2+dCdd8DSkZ3LivaN9MKEpLhHeeIBm4k3M5pJXXNPHqXJ8GvXI7Tllov 5hMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=19Iq/ONWaXQAxdTnaMbWy1IMUHmdgBgTKlL55pT+B/s=; fh=pRhPfQLlVYfHlKr8jnvugZHZivgJvP42cwXk4G+Q8Nc=; b=VCsPth/J3U2n3nEUycLcFSGOMU8o4VGPMV4q/BMpBq0PkAra5hBJV6UCkiPaDAfLuK eiF2XCFw6vz5/mc0dmNRh1S/+/88YSmjrnXdEzvlpWvLi6QHaWySPd6Kb+78gKB5J6Qy szaSqerWhjqocW+mNs49k0N5ZPP7aZIOqh2oiWAn5CZ+Q5Th9Lr5WNpBTwW5PsorrNCV V55N5VuzhrAPyi+/tnlnNhCWKw6qS3/Hx9kyosoGxi1RsRet25fc0OrbEwlyOECXtsEn HBbVA9KfVmMQQajQa+gWhK4GNpbTrLxfnzgTbGh9DPUpKs1Qbvhv33tOuVrBCN9YzxW0 N7kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10093-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10093-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bz14-20020a056a02060e00b005c63a36938fsi3838373pgb.809.2023.12.22.14.52.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:52:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10093-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10093-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10093-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 28BBF283C4C for ; Fri, 22 Dec 2023 22:52:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 272FD32188; Fri, 22 Dec 2023 22:51:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20302F535 for ; Fri, 22 Dec 2023 22:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMM-0005eq-Pk; Fri, 22 Dec 2023 23:51:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoML-000qvS-5O; Fri, 22 Dec 2023 23:51:14 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMM-000Ffe-0a; Fri, 22 Dec 2023 23:51:14 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 10/13] irqchip/renesas-irqc: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:41 +0100 Message-ID: <2d367ab738ed2e4cf58cffc10d64b0cbe8a1322c.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1804; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=RbqlBUDyzNjJon1VjvvsSpLOKIrzb9IWsFsQQCiOHOs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhLCVKR7Dii+2+5hAaBXjQ5/Enl4dufiFJZ0x jLGSzewFjqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSwgAKCRCPgPtYfRL+ TirvCACSQbDFKgHkODHm4EXqgX2Vuvl/DG6J6UhiYVJAd7U0cxPHzyxMmODqfiYB8dNKEnJPGVH 4FQxt11lrVOO/dhCckci/i8HHxPTBspbYYsb5F7IauDcdyzZ359zqd5L2MwKDUeE2xXSV+cW1KN w44SgmCGJ6i0W0tt1a08bmkX2ezW9poFgyAoOdmdWLmCwdoHXJNqADzDEoVeIL+UuyqjGf1FH8B u295ZZ4KWO5qTs1xRrFKFD9H3dbxQP6enA0nvZ9Dkp+xhfMypEc8hsJuj9lgI6TTMZ4zZx8LFZC itfj1XF5KF6U6iBrXqAntwuhDf2pA5eRWhNaQiT1jsGHErL9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024332543617711 X-GMAIL-MSGID: 1786024332543617711 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-renesas-irqc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c index 49b446b396f9..2bcf14d0f34b 100644 --- a/drivers/irqchip/irq-renesas-irqc.c +++ b/drivers/irqchip/irq-renesas-irqc.c @@ -218,14 +218,13 @@ static int irqc_probe(struct platform_device *pdev) return ret; } -static int irqc_remove(struct platform_device *pdev) +static void irqc_remove(struct platform_device *pdev) { struct irqc_priv *p = platform_get_drvdata(pdev); irq_domain_remove(p->irq_domain); pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } static int __maybe_unused irqc_suspend(struct device *dev) @@ -248,7 +247,7 @@ MODULE_DEVICE_TABLE(of, irqc_dt_ids); static struct platform_driver irqc_device_driver = { .probe = irqc_probe, - .remove = irqc_remove, + .remove_new = irqc_remove, .driver = { .name = "renesas_irqc", .of_match_table = irqc_dt_ids,