From patchwork Sat Apr 8 00:10:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 81098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp593404vqo; Fri, 7 Apr 2023 17:12:55 -0700 (PDT) X-Google-Smtp-Source: AKy350aFe+l5RGEt0VXvmCwcj6kmkXCxUX3jz1p3czNkEsbmcsRmuhsrbahUAyfG+hn5Woltw+pV X-Received: by 2002:a05:6a20:2a10:b0:db:7055:d4e9 with SMTP id e16-20020a056a202a1000b000db7055d4e9mr4383041pzh.27.1680912775050; Fri, 07 Apr 2023 17:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680912775; cv=none; d=google.com; s=arc-20160816; b=Lrp4BFaJeyBHxDeim8AbM7jcNGiUXBeY4UsRwp7rMf+q88MTD0Fcb0I735+l8L2QVp ivMygpwOpdNi6fIjqDXcKJ0KrUsSQeoOgBbYyVm+r/IZ+grwOmhZLtw0gUGiPVF6V4cD 9D7DmCnrpef7kO5tbBEy3RscOvYdwvh4bnOEXWlocRlnrMsPVzqsPslLhyTG2tBT5yy/ SLl8NwFCceRTcfUafPNYMWyWbKapf5As8ou6+9GMt5IQUCH6chvFal2gidN9CFayTc7b Ney13bu+ul0WF7GesSgqL8VTLO/upZRdummRNA2Pju3Lroufv7Z8B3mj2qWxW+8F0YzT mH2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t7QpP87CUX28uvZ6wWqq8ilh5/+FPySA8z1pvpJeNVs=; b=YT42Qx4YjSCVLEJVyc4AunUOaiNRIy5k+sLrz2MT6WhIb7CtFXp+9DrOp0ELqJl7+k vo4vky+SUol+7TAo7bV1YzXhJP7BGgUz3O6car0o57oubss62E6udeTb95aFXf9DLcUB N6Hy3AxrXsJOhqOZ5fRigsWiw6C8ySvWUDgLkjFkxhU3hxGEf9hekcQQtGy0CJQP+wC4 BqxPnM8BamcZvdhFYZX8ho6rA7a+4g0DDW0ekkn39pZHilKQ5wUCdTHV7axIiGv+3/YD 4p6bU/lixY+IOsvQZINeyXzBqIusaGBUZDJMxFkoLkfR9H7WU+HmVDtmC6X+1a40q28Z imHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nH5x0z6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r11-20020a635d0b000000b0050b3083b64fsi4484118pgb.429.2023.04.07.17.12.23; Fri, 07 Apr 2023 17:12:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nH5x0z6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbjDHAKs (ORCPT + 99 others); Fri, 7 Apr 2023 20:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbjDHAKZ (ORCPT ); Fri, 7 Apr 2023 20:10:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EE101207B; Fri, 7 Apr 2023 17:10:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F258B654DF; Sat, 8 Apr 2023 00:10:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED6E4C4339B; Sat, 8 Apr 2023 00:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680912623; bh=b7H0OJvgITv94oCGcITa5YVvEl/zb04TPx9I9PIgGgo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nH5x0z6FFxlmAqk1Z+5DbvThCvD42E6/lzLGoCaJ3O0l6koHnNOU487XixzyX9cx1 RgKw/Xfg+MyNHGnq/xn2pQOFNX9zOZ/T8ozXF1IOJLcG86B/H0wINW95EANefCtfTD 7JHot1O5MXM0e7DKs0nUeSVDAsmy5VlBRa2eQF6AHarBDqcc7sWCaaljqGJ9zy5yuK a4q12wKeMh1NJOcGRtd3sGb+lz1suDINSKvkpkTytxVN6mif/EVoFBqaUJH5eVnQeB N5YYagsrOFe2UDC166bnJs9Rc1XTPXa5BgWH9zSweGMg+uxpBeBMUIufKfNoAs4lMd Li+QbEapS6x9A== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Miroslav Benes , linux-btrfs@vger.kernel.org, Mark Rutland , linux-scsi@vger.kernel.org, linux-hyperv@vger.kernel.org, Arnd Bergmann , "Guilherme G . Piccoli" , Michael Kelley , kernel test robot Subject: [PATCH 10/11] scsi: message: fusion: Mark mpt_halt_firmware() __noreturn Date: Fri, 7 Apr 2023 17:10:03 -0700 Message-Id: <2c702dfc92ea7c34092e9039eafb60662fab90fd.1680912057.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762564794093833846?= X-GMAIL-MSGID: =?utf-8?q?1762564794093833846?= mpt_halt_firmware() doesn't return. Mark it as such. Fixes the following warnings: vmlinux.o: warning: objtool: mptscsih_abort+0x7f4: unreachable instruction vmlinux.o: warning: objtool: mptctl_timeout_expired+0x310: unreachable instruction Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202302271743.78emit6I-lkp@intel.com/ Reported-by: Mark Rutland Debugged-by: Peter Zijlstra Signed-off-by: Josh Poimboeuf --- drivers/message/fusion/mptbase.c | 2 +- drivers/message/fusion/mptbase.h | 2 +- tools/objtool/check.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 9b3ba2df71c7..4f0afce8428d 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -6935,7 +6935,7 @@ EXPORT_SYMBOL(mpt_clear_taskmgmt_in_progress_flag); * @ioc: Pointer to MPT_ADAPTER structure * **/ -void +void __noreturn mpt_halt_firmware(MPT_ADAPTER *ioc) { u32 ioc_raw_state; diff --git a/drivers/message/fusion/mptbase.h b/drivers/message/fusion/mptbase.h index 4bd0682c65d3..0f226cdad64f 100644 --- a/drivers/message/fusion/mptbase.h +++ b/drivers/message/fusion/mptbase.h @@ -945,7 +945,7 @@ extern int mpt_raid_phys_disk_get_num_paths(MPT_ADAPTER *ioc, u8 phys_disk_num); extern int mpt_set_taskmgmt_in_progress_flag(MPT_ADAPTER *ioc); extern void mpt_clear_taskmgmt_in_progress_flag(MPT_ADAPTER *ioc); -extern void mpt_halt_firmware(MPT_ADAPTER *ioc); +extern void __noreturn mpt_halt_firmware(MPT_ADAPTER *ioc); /* diff --git a/tools/objtool/check.c b/tools/objtool/check.c index a42a2af99ea2..8586d4c36600 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -219,6 +219,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "lbug_with_loc", "machine_real_restart", "make_task_dead", + "mpt_halt_firmware", "nmi_panic_self_stop", "panic", "panic_smp_self_stop",