From patchwork Fri Apr 21 09:58:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 86217 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp954916vqo; Fri, 21 Apr 2023 03:10:38 -0700 (PDT) X-Google-Smtp-Source: AKy350YqeV2jZum+A7HHVRmeBoAdUgt3qVsvItpx3oshux81BrmM68owFnKRSdnOC1h/A1YEnvHW X-Received: by 2002:a17:902:eb87:b0:1a1:ee8c:eef7 with SMTP id q7-20020a170902eb8700b001a1ee8ceef7mr4122919plg.48.1682071837740; Fri, 21 Apr 2023 03:10:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682071837; cv=none; d=google.com; s=arc-20160816; b=A3tams3N/29vUvnQ+3wF/rowF2ydKk8Nwi4/IBqGvO/WM1kWG+TfLhsHGkfPxAoFUB SxBgvMwV2OELW74qs50t7MMg8ppewXe2YlhQ8CBbR/bz25MRfKQCXQRtE0J64kEwa/UT h1p6rgWv/M9QZxJLyusgCY+9uFatTVCLyEf6i8MJyMILoR9dkJAIohMPpROjz5iUiCYz 0gkBLlaAuwnOJMyT1amSP+VZZv+4XscGFzfEIXWofh7Dtwaypu6ZFGCum2Tq7hX5xT/Y SDoXgUL6s5izr8uzwcd8u6K+IwmJrvoiAaNu6J72Tf/sgJ1YpqpgR1aFR+OTyVgvYAxn VKzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Pf3RKxbf2LlBj0B+bqTUDCmn+GA3wj267rTQOAm0F4E=; b=sTKf+yq8AR086ibQNKlk/Yduph117cAMIOw5l2z1bEiBFOJzZGM00KEe0WeKgRVoVp upFMsa6uZWwKX+4+YO0gRKuONuKg4Tq4z8i6ENaNn3VA3o8sYAY3M19QP67NjbizbTEL 7CEpxsqFNq/qQ4i6ytQjEmq3xeURhEhi6+3Cxbn53UCzcLHH/mxA4cWBHjD9SKOuYL3Y bjdC4BC+YhMHKA0Wl8p1Wz+7Bgxhm/mk59nBaaJVZ7ee+k15y366MtJOBR9iXuhB0FEd uwNeGRhwV0RyhflIwAURUgCIjYSQCJVPOs0pm+obImSTHBBCkj9q4X2qd7M+VoByny2m +zNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d12-20020a170902654c00b001a6db2bef24si3924084pln.145.2023.04.21.03.10.25; Fri, 21 Apr 2023 03:10:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjDUJ6r (ORCPT + 99 others); Fri, 21 Apr 2023 05:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjDUJ6p (ORCPT ); Fri, 21 Apr 2023 05:58:45 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC056BBBB for ; Fri, 21 Apr 2023 02:58:14 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by andre.telenet-ops.be with bizsmtp id nMy72900H1C8whw01My7h8; Fri, 21 Apr 2023 11:58:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1ppnVv-00HQwh-Ha; Fri, 21 Apr 2023 11:58:07 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1ppnWp-00GXP1-Lf; Fri, 21 Apr 2023 11:58:07 +0200 From: Geert Uytterhoeven To: Greg Kroah-Hartman , Jiri Slaby , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config() Date: Fri, 21 Apr 2023 11:58:06 +0200 Message-Id: <2bd1e62be1d5d33333002910372feecc6d52e78f.1682071013.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763780159765044737?= X-GMAIL-MSGID: =?utf-8?q?1763780159765044737?= With W=1: drivers/tty/serial/8250/8250_port.c:679: warning: Function parameter or member 'termios' not described in 'serial8250_em485_config' Fix this by documenting the parameter. Fixes: ae50bb2752836277 ("serial: take termios_rwsem for ->rs485_config() & pass termios as param") Signed-off-by: Geert Uytterhoeven Reviewed-by: Jiri Slaby --- drivers/tty/serial/8250/8250_port.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index dfbc501cf9d1561e..a0fd5ecc07ac66f3 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -668,6 +668,7 @@ EXPORT_SYMBOL_GPL(serial8250_em485_supported); /** * serial8250_em485_config() - generic ->rs485_config() callback * @port: uart port + * @termios: termios structure * @rs485: rs485 settings * * Generic callback usable by 8250 uart drivers to activate rs485 settings