Message ID | 26932016c83c2ad350db59f5daf96117a38bbbd8.1679566927.git.geert@linux-m68k.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2833098wrt; Thu, 23 Mar 2023 03:41:01 -0700 (PDT) X-Google-Smtp-Source: AK7set99ynt4gQW3wydI/DpLxCN/jP1Z9He1DIOzfhjmmAtdnm7e8zO0oqIa9yecFqRzSPJhnJT6 X-Received: by 2002:aa7:dc0e:0:b0:501:c3de:dc5c with SMTP id b14-20020aa7dc0e000000b00501c3dedc5cmr10539041edu.18.1679568061797; Thu, 23 Mar 2023 03:41:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679568061; cv=none; d=google.com; s=arc-20160816; b=S064jNlu2IKTlcG0muSOgF/GRaIELUZ42xcBm29wG5gkjMwh8vwmfKKEPqNC3/P8qz fM83Te2dylMmFaZpc78R4RJ4FIdKxI8/57lOKNGzwaG95PcwwafTgrCf4XDNSpeGtH7x 5+e/mfUiOtMkPjajMHcpMLrEWSvh9LwGIgi6fsF7Zg/FO4pzDrr1RV/Nq3DvuiYy4KRT mz8SQGL9ar59Mk9SMVtbJyqqXu+KBMN/jj6BWEvlxbv8GCZLfZCbnl9ccQrpPGDqOSDO zz2hXEyBwJc5RXj0vV4IQDZDiK2Vd61Vo7NbFne/RNI99yon/6MoXrzjVu85KQ8Vrwr8 +wTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VZUdnllUyJEXYJRHTAhFbC3zf6bIjVc60Zdmr0F7xWE=; b=IH/k2n6efvHp1FzWqitw3Dd+kq093X6L7suF8T5IEFkwlKNIUHZiVHNtolxA1IsaKX kJjuLDVpQuENjljUlBUUInRGwes9R7+6niLaL2uqVpEgPgeVQIVHYLa844uiYBKVjA9m IIk0NitjSUsyNIPh1Bp7QnCNMU6cmUWkPll5xII9VwzHg96KBLOGXOhcQrklXX7cf7CE XOGsneQUOB48tasVTXw56YXOJmVY8T0RIaTXwZroLEIxQ+5m2UlsDG+/WdbQjTrmMku5 JmLMVHzBNx9uUYq0koescfQKzek7XNcAdH5gyjNkGC0cwGFt9mcOvk01NnFv844SXbYH SrBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ov14-20020a170906fc0e00b0092d0f8f0111si16636348ejb.340.2023.03.23.03.40.38; Thu, 23 Mar 2023 03:41:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbjCWKXM (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Thu, 23 Mar 2023 06:23:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbjCWKXI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Mar 2023 06:23:08 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 569E3D528 for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 03:23:06 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by baptiste.telenet-ops.be with bizsmtp id bmP32900n1C8whw01mP4V1; Thu, 23 Mar 2023 11:23:04 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1pfI5N-00EKrY-K1; Thu, 23 Mar 2023 11:23:03 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1pfI63-00CE9y-RH; Thu, 23 Mar 2023 11:23:03 +0100 From: Geert Uytterhoeven <geert@linux-m68k.org> To: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH v2] sh: Replace <uapi/asm/types.h> by <asm-generic/int-ll64.h> Date: Thu, 23 Mar 2023 11:22:59 +0100 Message-Id: <26932016c83c2ad350db59f5daf96117a38bbbd8.1679566927.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761154759850967314?= X-GMAIL-MSGID: =?utf-8?q?1761154759850967314?= |
Series |
[v2] sh: Replace <uapi/asm/types.h> by <asm-generic/int-ll64.h>
|
|
Commit Message
Geert Uytterhoeven
March 23, 2023, 10:22 a.m. UTC
As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide
any sh-specific uapi definitions, and it can just include
<asm-generic/int-ll64.h>, like most other architectures.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
- Rebased for SPDX-License-Identifier addition in 2017.
arch/sh/include/asm/types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Geert! On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote: > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide > any sh-specific uapi definitions, and it can just include > <asm-generic/int-ll64.h>, like most other architectures. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v2: > - Rebased for SPDX-License-Identifier addition in 2017. > > arch/sh/include/asm/types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h > index 68eb24ad201383ef..9b3fc923ee28701c 100644 > --- a/arch/sh/include/asm/types.h > +++ b/arch/sh/include/asm/types.h > @@ -2,7 +2,7 @@ > #ifndef __ASM_SH_TYPES_H > #define __ASM_SH_TYPES_H > > -#include <uapi/asm/types.h> > +#include <asm-generic/int-ll64.h> > > /* > * These aren't exported outside the kernel to avoid name space clashes It seems that many (most?) architectures don't even provide their own types.h header. Does it even make sense to still carry that header or can it be provided from somewhere else? Adrian
Hi Adrian, On Fri, Apr 21, 2023 at 1:14 PM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote: > > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide > > any sh-specific uapi definitions, and it can just include > > <asm-generic/int-ll64.h>, like most other architectures. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > --- > > v2: > > - Rebased for SPDX-License-Identifier addition in 2017. > > > > arch/sh/include/asm/types.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h > > index 68eb24ad201383ef..9b3fc923ee28701c 100644 > > --- a/arch/sh/include/asm/types.h > > +++ b/arch/sh/include/asm/types.h > > @@ -2,7 +2,7 @@ > > #ifndef __ASM_SH_TYPES_H > > #define __ASM_SH_TYPES_H > > > > -#include <uapi/asm/types.h> > > +#include <asm-generic/int-ll64.h> > > > > /* > > * These aren't exported outside the kernel to avoid name space clashes > > It seems that many (most?) architectures don't even provide their own types.h > header. Does it even make sense to still carry that header or can it be provided > from somewhere else? SH does because it defines extra types {insn,reg}_size_t. We can get rid of it by moving these extra types elsewhere, but is that worth the effort? Gr{oetje,eeting}s, Geert
On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote: > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide > any sh-specific uapi definitions, and it can just include > <asm-generic/int-ll64.h>, like most other architectures. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v2: > - Rebased for SPDX-License-Identifier addition in 2017. > > arch/sh/include/asm/types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h > index 68eb24ad201383ef..9b3fc923ee28701c 100644 > --- a/arch/sh/include/asm/types.h > +++ b/arch/sh/include/asm/types.h > @@ -2,7 +2,7 @@ > #ifndef __ASM_SH_TYPES_H > #define __ASM_SH_TYPES_H > > -#include <uapi/asm/types.h> > +#include <asm-generic/int-ll64.h> > > /* > * These aren't exported outside the kernel to avoid name space clashes Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Hi Geert! On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote: > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide > any sh-specific uapi definitions, and it can just include > <asm-generic/int-ll64.h>, like most other architectures. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > v2: > - Rebased for SPDX-License-Identifier addition in 2017. > > arch/sh/include/asm/types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h > index 68eb24ad201383ef..9b3fc923ee28701c 100644 > --- a/arch/sh/include/asm/types.h > +++ b/arch/sh/include/asm/types.h > @@ -2,7 +2,7 @@ > #ifndef __ASM_SH_TYPES_H > #define __ASM_SH_TYPES_H > > -#include <uapi/asm/types.h> > +#include <asm-generic/int-ll64.h> > > /* > * These aren't exported outside the kernel to avoid name space clashes Is the use of your linux-m68k email address for this patch intentional? I'm asking because the other one you posted is with your geert+renesas address. Do you want to adjust this? Adrian
Hi Adrian, On Tue, Apr 25, 2023 at 8:32 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote: > > As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide > > any sh-specific uapi definitions, and it can just include > > <asm-generic/int-ll64.h>, like most other architectures. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > --- > > v2: > > - Rebased for SPDX-License-Identifier addition in 2017. > > > > arch/sh/include/asm/types.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h > > index 68eb24ad201383ef..9b3fc923ee28701c 100644 > > --- a/arch/sh/include/asm/types.h > > +++ b/arch/sh/include/asm/types.h > > @@ -2,7 +2,7 @@ > > #ifndef __ASM_SH_TYPES_H > > #define __ASM_SH_TYPES_H > > > > -#include <uapi/asm/types.h> > > +#include <asm-generic/int-ll64.h> > > > > /* > > * These aren't exported outside the kernel to avoid name space clashes > > Is the use of your linux-m68k email address for this patch intentional? > > I'm asking because the other one you posted is with your geert+renesas > address. > > Do you want to adjust this? It is fine, v1 was sent in 2013 https://lore.kernel.org/all/1385369734-24893-20-git-send-email-geert@linux-m68k.org Thanks! Gr{oetje,eeting}s, Geert
diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h index 68eb24ad201383ef..9b3fc923ee28701c 100644 --- a/arch/sh/include/asm/types.h +++ b/arch/sh/include/asm/types.h @@ -2,7 +2,7 @@ #ifndef __ASM_SH_TYPES_H #define __ASM_SH_TYPES_H -#include <uapi/asm/types.h> +#include <asm-generic/int-ll64.h> /* * These aren't exported outside the kernel to avoid name space clashes