From patchwork Fri Dec 15 13:59:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179302 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9294223dys; Fri, 15 Dec 2023 06:01:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVSGDYxRSb9DDObTfukPivy2OKxe3BhPJPlg+UCrfiQ/rWHSuu9D/uDVpS3zIrcM5REc8N X-Received: by 2002:ac5:c818:0:b0:4b2:83ab:7ebd with SMTP id y24-20020ac5c818000000b004b283ab7ebdmr3927901vkl.11.1702648885180; Fri, 15 Dec 2023 06:01:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702648885; cv=none; d=google.com; s=arc-20160816; b=r0QeyanBXzcVdjHAtagffvGZIX8kg0j+FkIOwgnMUSy7m2DtNrk5bFhhHtYmrfhGC/ ezCrIXr0CFs4fZ6HUPj6A0ZBY4FUzQE5c81VWkJDRLHtc6KlHEu8+TG+hBCmGiJvghN9 TpIEbBxIV0/fb9X5iNdQorhD19wZZfdnZ7jgjn8/U7wLMCOR3qt0o0Ged2nzmBX6M/Q4 lTxtAdeuIiVNjYTcE4XdFSu/NB/2IkOXANoUIjMbh8XJFb2tMKqt53ta+be7inna8tqz XT49GPzIFupF7Ed+Hvtux96xJ5jyFKKnRHbX1SVyjujBY/n9qMLXftyBaFwS4gEG7/L8 0T5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=LO8tfA83ro7aJasBu/eZ4vCmAKZzSkqkt3/2PWnzAPg=; fh=WBAvDUdZQ65Hx9170m7xg5JkwQLI0WSCirM0+e+PVtk=; b=hyYrG0Vc6dN4XjUImbNx1u71SjIF/FmdaRXbuE5AjIhzjstOI9OYmWRdErtEvYdrtX MqCGzrcPtFmGTmqPcwj8DxdDy3Hz9KLk2fm+9zKhVXzDEa4fsFi+rM24RBGQzxsO8oqN dbjiB8dthb0/2uWhQyfhBw7CximLm/6TOK6BOCzuCUrKxJN1EZDQLa0oGjC4/oCjyNza YGWXGwzlSpfe2Z7wdJYGA0LNwZQy3auupuFerNrEPWCHhHZfV97vLO/ueJxZ+CrztcHh yqlG2kTBqLKmhdBjWmuRygpscOu8Ghc4Dgg5/x7CXOdgc+CiBFeYBApyIg4e3Xnmxe+v AP6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1057-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1057-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y124-20020a1f4b82000000b004b2d92f7eabsi3439143vka.264.2023.12.15.06.01.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:01:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1057-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1057-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1057-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F2E441C22C0E for ; Fri, 15 Dec 2023 14:01:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D24331A63; Fri, 15 Dec 2023 13:59:39 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F156C2EB1A for ; Fri, 15 Dec 2023 13:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8iw-0002mJ-Tn; Fri, 15 Dec 2023 14:59:30 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8iw-00G2Zl-Gk; Fri, 15 Dec 2023 14:59:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iw-003cCY-7L; Fri, 15 Dec 2023 14:59:30 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/18] perf: arm_smmuv3: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:09 +0100 Message-ID: <23bfd1a73ce819ffce6137c237608684a3cdfda6.1702648125.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1779; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=WoUmgvDx6FwJTMCVD5BbKw0j9xOmLxz1U/nwD6WKOcw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFuvsCq62C9qwNvQCGzRX11jvZolyVoVwJoOU 2Pmd6ixFyyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbrwAKCRCPgPtYfRL+ Tko8B/4gczEX6cq/EpSayum0gjAC6YWceqcQyx+h3VFIm0jNwy1lr8d0iDJMRDqEeDZN0MEuCCh a+KRJiDm1t4J7zO8axMAreV6sCCMdL9vi8wLNJhphHuxDUaSu2CCmcKqkU7u/R4vXYf7D0qTAIM JhblkMgyhjTfzeqLNET/vGatSow+qjW5KWUVlH4cBNTVUWjk4t8nuxg5++dtTrUGnof6bo0Ivcn BPfniPiTdoBEE23U6vHSnp55tep/W0h9rqokLUZdRBE3F4r99Dvp8DqAKS5kQIuK+2E4dTadnFt Iv57KcGOAQZschzGKhWvvkv9JJigxUJemXGDPKAvp9NttgOz X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356757342700920 X-GMAIL-MSGID: 1785356757342700920 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/arm_smmuv3_pmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c index 6303b82566f9..af3ab3eb944e 100644 --- a/drivers/perf/arm_smmuv3_pmu.c +++ b/drivers/perf/arm_smmuv3_pmu.c @@ -965,14 +965,12 @@ static int smmu_pmu_probe(struct platform_device *pdev) return err; } -static int smmu_pmu_remove(struct platform_device *pdev) +static void smmu_pmu_remove(struct platform_device *pdev) { struct smmu_pmu *smmu_pmu = platform_get_drvdata(pdev); perf_pmu_unregister(&smmu_pmu->pmu); cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node); - - return 0; } static void smmu_pmu_shutdown(struct platform_device *pdev) @@ -997,7 +995,7 @@ static struct platform_driver smmu_pmu_driver = { .suppress_bind_attrs = true, }, .probe = smmu_pmu_probe, - .remove = smmu_pmu_remove, + .remove_new = smmu_pmu_remove, .shutdown = smmu_pmu_shutdown, };