[v1,5/5] ACPI: processor: perflib: Adjust acpi_processor_notify_smm() return value

Message ID 21694351.EfDdHjke4D@kreacher
State New
Headers
Series ACPI: processor: perflib: Assorted cleanups |

Commit Message

Rafael J. Wysocki Dec. 5, 2022, 7:08 p.m. UTC
  From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Avoid returning a confusing error code from acpi_processor_notify_smm()
if it is called for the second time in the case when SMM notification
regarding P-state control is not supported.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/processor_perflib.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
  

Patch

Index: linux-pm/drivers/acpi/processor_perflib.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_perflib.c
+++ linux-pm/drivers/acpi/processor_perflib.c
@@ -475,10 +475,12 @@  int acpi_processor_notify_smm(struct mod
 
 	result = acpi_processor_pstate_control();
 	if (result <= 0) {
-		if (!result)
+		if (result) {
+			is_done = result;
+		} else {
 			pr_debug("No SMI port or pstate_control\n");
-
-		is_done = -EIO;
+			is_done = 1;
+		}
 		goto out_put;
 	}