Message ID | 21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2811031wrn; Mon, 13 Feb 2023 23:09:40 -0800 (PST) X-Google-Smtp-Source: AK7set+NRlX7C00XibmyS59EJjVk9aFIcI4qU9feLAdtN77htzcVvN5zgnhWSp0AET0BUgOEMiER X-Received: by 2002:a50:ce1c:0:b0:4ab:4c36:463c with SMTP id y28-20020a50ce1c000000b004ab4c36463cmr1236671edi.16.1676358580414; Mon, 13 Feb 2023 23:09:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676358580; cv=none; d=google.com; s=arc-20160816; b=JVAddQ7n1ue7N82Kr8xH4hyyI535I8+9lIKO7k2Nii2Jc/oaWEZLN9chhLjTbF1ktI KWBi5xE6nK+BrzMfdG6G5DBpV4Mq9sOVDV7MY7B8gFZswUnn/z9QuGY2hBMGxIDE5xPJ YD5FCKq+gxYRM7TJ2FvpeNECfXSC3Xi/YpgjbRkyGDdgAUmZSMOWPRJM+lKW3vYwqZyl zPsISyLUIHnz51Q5ozVTX6HJC5W77dQIilV/wUcg0Cobxo965uAQj3Q/zz5J/9JONhtf hLQUHa+40oQyTiUJxPBAyahz2hFxhF8cXxPoyR/T/IVNmMpPU8IzdS0aFZ4VPrP4kkjw wu7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jT0BSzK2N10KU3r2AzY9256A63zm35SqD//NuSL/auM=; b=gDmT/Bij7XWizwf9ctM9GEP6IFm8aDgZn0gq1JyWPzWHHhKv3ukC+RHcWg5EK+HmvO lydEmyEW8wtQ9HMctmE4tUuFXbRz8Lmo5m4bRBmvvsOird02mEDWh00wjzAa0MrmK6+o w6kB+IAesAPm//1k0N8ENWAP3/l2Fkc+i2WGfxnwZsWSCW+Q0vEC8QpN3yC3bDcVvOfw prSNR1Rk7LtLyOGSRhBEbkYgM0buGIszryIBLU9HNUGuU6xiL5DvDwDunMPdSX5QqyXu tZqvZh4DxzJeN2uKfCljP8a+VL2rKJ8G56yblxZIzv4lJ5JZ+UdgYqqLstWwM7nOMdQi aoWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=haQ67CC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020aa7c502000000b004acd30eabb3si3121244edq.69.2023.02.13.23.09.15; Mon, 13 Feb 2023 23:09:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=haQ67CC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbjBNHHv (ORCPT <rfc822;tebrre53rla2o@gmail.com> + 99 others); Tue, 14 Feb 2023 02:07:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231831AbjBNHH1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 14 Feb 2023 02:07:27 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDDC01DBB2; Mon, 13 Feb 2023 23:07:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5059B81A02; Tue, 14 Feb 2023 07:07:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE3C6C433A4; Tue, 14 Feb 2023 07:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676358421; bh=faSU9WIlOndHpDhDf2FIwcDy94fg1S+/xLr91iuYnFs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=haQ67CC9AnruMMdRvLTP3ur8+9rfxW3kiW8NLQWfr7tHyhY9ET6F9E7ucDtc5OPVR V8ui5J7DmGKI6YpM6s3RuN0BEgPp/zTnZ+REFssZ3oevvAO2c7PQH3bWcJIYTwl6cs FR7+2FEPOdGt0yqGNLg7UTWojyuUbyC3x4unOsqDhORgoeZEHgmKxt7X4ZupgDVwOU mP13mc/quC3FdnBlkNjpmbSYXWbt1fLOxPEeYCxsBPJ/xfixJfB/wjf9fYbs/Cw84m 8AJ+Mn6Ozye8bNGzZXJ/+FdFcGV0KgsLy9yuFiw/Lx8Rx6gYUvFHSq0SPX2bMnh6fI hq5rMOVOB+K9Q== From: Josh Poimboeuf <jpoimboe@kernel.org> To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org Subject: [PATCH v2 07/24] loongarch/cpu: Make sure play_dead() doesn't return Date: Mon, 13 Feb 2023 23:05:41 -0800 Message-Id: <21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <cover.1676358308.git.jpoimboe@kernel.org> References: <cover.1676358308.git.jpoimboe@kernel.org> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789374736066056?= X-GMAIL-MSGID: =?utf-8?q?1757789374736066056?= |
Series |
cpu,sched: Mark arch_cpu_idle_dead() __noreturn
|
|
Commit Message
Josh Poimboeuf
Feb. 14, 2023, 7:05 a.m. UTC
play_dead() doesn't return. Make that more explicit with a BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
arch/loongarch/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/loongarch/kernel/smp.c b/arch/loongarch/kernel/smp.c index 8c6e227cb29d..51f328169a7b 100644 --- a/arch/loongarch/kernel/smp.c +++ b/arch/loongarch/kernel/smp.c @@ -336,7 +336,7 @@ void play_dead(void) iocsr_write32(0xffffffff, LOONGARCH_IOCSR_IPI_CLEAR); init_fn(); - unreachable(); + BUG(); } #endif