From patchwork Mon Mar 4 14:39:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 209564 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1464027dyc; Mon, 4 Mar 2024 06:41:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWSVDpa2sAayIaOfxju5XYWL7bc0lt7oNKyoXnOfSElw+FxF80b4oILjpS+H3EoLO9OqHL21cC05RrDC/KW5JJpTpJBBQ== X-Google-Smtp-Source: AGHT+IGoyG1xfRqelz69S3zdnM9Ceb6HT5DqrBQp9NGl69oTvaJpIB2jVoZ6+6o3zXjhQiVtLrki X-Received: by 2002:a05:6808:dc5:b0:3c1:f692:8ded with SMTP id g5-20020a0568080dc500b003c1f6928dedmr567943oic.45.1709563291296; Mon, 04 Mar 2024 06:41:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709563291; cv=pass; d=google.com; s=arc-20160816; b=aIxmeoISjb00aCrmagXadhZBzHV76DRkWD5qGBHRh0+mKO87VIU3IaBc+tB1iSxXGA OUKme1hAr82qm9U/MYLWmhK/3DPjqfFq/xJIjD1TEWSJ/wvAcyT4T64EnFrKrMAnCuFW Fkzd9JbixlBcC97THjLkgE+B/O10M2vYmCAV3HcVZod7OlDmbPRKyQRClqirwQzwk8qi qTQhoETEk8mOrmET07OcDbQXPI9Xp3JdnHeieGjjV2emwGqFq2yQPCFxOnFVqLtglA+v jmHRW+aRNIRskyKNirGalJon5FnMDQXGXiJSa8qBIPh3CLiAQGNP6L2nSfoVlBVwyAlb q9Cw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=7d56sd/m9dIXtjbN0XPV7LjoZmJMo1g25wEJ7BSlmJI=; fh=iWkGsoy7TPTmscZDaNwAhCaNzZd4htfetWN3qPRQ3vU=; b=CocTI+yQSuOKuzGLIa39MbHzUynahN1f6CwJsRSP0tmFPF1er2ozo+tlNYYMoeUATk K96+keK0I1QpJosoGaDqTAxYm9gZObublKKYRMRsMm3xpm4GGyqJCGR724xCKsSjbGcX NIc109Lfoxb4pBjRwlrGOHrWNQrAXxP69oeUA74eJfQk/56pOkp3mqjyyl9Oji/u1XUn QU1Ls/n4w759WYFrcj6SZfKwdwLMarxK+NG8EF+SpQFpbMNM2UKT0A5Ydnakdcwdrr4u buSIKm3oeVo/lhHBqEZN0BS/93VTmVWLJ3ERGF2H75iDhZbU52ARcAxkag+v8VqNmk5h cCUg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fxTbWTPM; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-90747-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90747-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 5-20020ac85945000000b0042ef63a31f3si1289612qtz.51.2024.03.04.06.41.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 06:41:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90747-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fxTbWTPM; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-90747-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90747-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BEEAA1C21B36 for ; Mon, 4 Mar 2024 14:40:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09E8A4AEEE; Mon, 4 Mar 2024 14:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fxTbWTPM" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8026245BF6 for ; Mon, 4 Mar 2024 14:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709563161; cv=none; b=gJ+KCj5zoFrPw2vEAiV+iaM0nNL/fthZADKGk16JRjr8ILjJzg61U+y7ZGumlfi5Slc3iT4yckhcxQGdaflm8NVLjuTmxxH2dN9wY2/JBGU8+b4lyj1iKMvnnV6knoulWSX0eb3m6jOjBQQnnp5znOyNb5jBMDE2j0t2e4aaVwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709563161; c=relaxed/simple; bh=TQZp5xpOX2dnHZfG1mH9kj65SYkNhEAl0tLk1zElFu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uCiE6aIjKPW5DmpSMMI6WAAwmwZEa/Y25IxvSe3xRFPUOWOdQV0GJycNY4hWI4ZaOVqT8cN749Byn2c59m4oSLIhKSbCivjI6AM9AzSBtMB0kldwjaJbhN1ES0T3LQFiM8sAyh7HNzvU3XPAESDay9EwXRBjsyexxMFTVew+VYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fxTbWTPM; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709563159; x=1741099159; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TQZp5xpOX2dnHZfG1mH9kj65SYkNhEAl0tLk1zElFu0=; b=fxTbWTPM6vY/SxI7rqxSR1H3NzoWUV1/AUSyNp/Sx/ezxh6hhqgH8V0n TlWm0kt1bOoBTvsFLPfHQ4+7Ft3Kc5QGmOQVn6hcGKJ7+Sr87uRXWjJHF b4zYBoPX3VoAtE93HX3Gb2XTSEvT6H2rIHr6Ge9f28bAX0JN7wsuMMEjk 2uhZVEhppkDYglOT/VZOX4HWM/LOWciBZqsOfN1iQZKXFeo0Fw00cNZt8 kZzaU3r4ytx/F/M9kHtbxc2OuYjbAACAAyVytaL+0uuQAWVv1JhUvbnev meExvP4Tz8pdUg8JTpQknzh/1paqPDsfuphR++SR5VCstWRW3WpLf0gb2 g==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="15464644" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="15464644" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 06:39:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="9162552" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 06:39:18 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH v3 4/4] drm/xe: Increase devcoredump timeout Date: Mon, 4 Mar 2024 06:39:05 -0800 Message-ID: <20240304143905.52740-4-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304143905.52740-1-jose.souza@intel.com> References: <20240304143905.52740-1-jose.souza@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792607038069944916 X-GMAIL-MSGID: 1792607038069944916 5 minutes is too short for a regular user to search and understand what he needs to do to report capture devcoredump and report a bug to us, so here increasing this timeout to 1 hour. Cc: Rodrigo Vivi Cc: Jonathan Cavitt Acked-by: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/xe_devcoredump.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c index 109c027188bd9..08c60531e0db4 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -52,6 +52,9 @@ #ifdef CONFIG_DEV_COREDUMP +/* 1 hour timeout */ +#define XE_COREDUMP_TIMEOUT_JIFFIES (60 * 60 * HZ) + static struct xe_device *coredump_to_xe(const struct xe_devcoredump *coredump) { return container_of(coredump, struct xe_device, devcoredump); @@ -229,8 +232,9 @@ void xe_devcoredump(struct xe_sched_job *job) drm_info(&xe->drm, "Check your /sys/class/drm/card%d/device/devcoredump/data\n", xe->drm.primary->index); - dev_coredumpm(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, - xe_devcoredump_read, xe_devcoredump_free); + dev_coredumpm_timeout(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, + xe_devcoredump_read, xe_devcoredump_free, + XE_COREDUMP_TIMEOUT_JIFFIES); } static void xe_driver_devcoredump_fini(struct drm_device *drm, void *arg)