From patchwork Mon Mar 4 09:13:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 209443 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1305372dyc; Mon, 4 Mar 2024 01:18:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXjTJe1l73F3oc0U/MJ791Vog2XDJGE2hpXYig1xMmNlimf5Gki3A5Bf/5BsiMNT8mqJjsu9+ZzvMQ1lpgBnu9wQ/16iw== X-Google-Smtp-Source: AGHT+IEw8XUwIkVRPCzbYSiYjWHtJ5AhcKJ4Fzl/b9ePzhho+qbMfsQ7nU4M6A8/oyJXfY/44y5B X-Received: by 2002:a17:902:ee4d:b0:1dc:ae92:7e9 with SMTP id 13-20020a170902ee4d00b001dcae9207e9mr8969080plo.62.1709543890639; Mon, 04 Mar 2024 01:18:10 -0800 (PST) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id t14-20020a170902e84e00b001dba722cf4csi8288200plg.40.2024.03.04.01.18.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 01:18:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90282-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-90282-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90282-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 58531B2124D for ; Mon, 4 Mar 2024 09:13:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AC8420B33; Mon, 4 Mar 2024 09:13:39 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228EC1B27A for ; Mon, 4 Mar 2024 09:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709543617; cv=none; b=MxChbHjipmEWjB/ju4n4FlNqbZp/rdeoLWAc27gdvkBR/ljjsJszy65vbHCXZKZfBoBaKes9JAAiJDHLZPB07ynahXNS9IE3Pjy+OJvKZOpAOq0CvLavi152Kl7aVY2lKd9JL9OAY3L2q4k/EggB5IxW3pFLxy5XJP7dKfyrha4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709543617; c=relaxed/simple; bh=n4g6A/1gV2oAFkfciMKSmu9PWw+8nLkwQuD7vVTJDCk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gmzmZMFF3rKFGNB2ZMtYJDTOXwz0Am6MvZgEPOTP6ICuUOeQV1wcP/QZZ11ygWvZlUoBRvlnE2Kvxg70RvvCU1rGheUeFec3XEKmOIMGBArO7Lq1hFFmG2c3ere1KxzN1WJ4p8JKD7cXHMTFUZWCRJPXvhMtBEgqPVlLqJjM2d4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rh4O3-00036d-5I; Mon, 04 Mar 2024 10:13:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rh4O2-004K1A-4l; Mon, 04 Mar 2024 10:13:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rh4O2-00GVS1-0B; Mon, 04 Mar 2024 10:13:30 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran , Min Li Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ptp: fc3: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 10:13:25 +0100 Message-ID: <20240304091325.717546-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1785; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=n4g6A/1gV2oAFkfciMKSmu9PWw+8nLkwQuD7vVTJDCk=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtSnE7YdyRIIWl+xzPDn90I2o7MZD72Eyp/eP7Zuj4j2m osb28PvdzIaszAwcjHIiimy2DeuybSqkovsXPvvMswgViaQKQxcnAIwEeFE9n9a9/6u+WFWXOQv +u1UEtvRaxeZOk68tGDxeyXPoPo5Q/lAou71GwKNnq+37bJt0g9Y73Z9xsE1fzUMVwrkSqzwuX6 7IvfErr8OZWmtLh7K8hvyX+22C/SQNys8/Kev9DXvhxzbNiXrLG2rOwIFsb8dXgSLBK2PLFual6 mQ3yEV6Wndt5aJt6R2Ru2VADfN5yLTnGOn+Bjsj6nzSjGbq27HUT9Nzv5zhlNKyESNaE6rO19es Xu8z41L0ZTN4X2sscLpSWO5/N9JGblzrkrGRzklLlHPSPip3ruR67ieUwn/rtNxhydJftq+6pTu MqB/ZrawPdQUPdsi2yATPDnXKL875/HFcrGF1cp7DwMA X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792586694962671277 X-GMAIL-MSGID: 1792586694962671277 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- Hello, note this driver is currently only available in next. Best regards Uwe drivers/ptp/ptp_fc3.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89 diff --git a/drivers/ptp/ptp_fc3.c b/drivers/ptp/ptp_fc3.c index 0e2286ba088a..6ef982862e27 100644 --- a/drivers/ptp/ptp_fc3.c +++ b/drivers/ptp/ptp_fc3.c @@ -996,13 +996,11 @@ static int idtfc3_probe(struct platform_device *pdev) return 0; } -static int idtfc3_remove(struct platform_device *pdev) +static void idtfc3_remove(struct platform_device *pdev) { struct idtfc3 *idtfc3 = platform_get_drvdata(pdev); ptp_clock_unregister(idtfc3->ptp_clock); - - return 0; } static struct platform_driver idtfc3_driver = { @@ -1010,7 +1008,7 @@ static struct platform_driver idtfc3_driver = { .name = "rc38xxx-phc", }, .probe = idtfc3_probe, - .remove = idtfc3_remove, + .remove_new = idtfc3_remove, }; module_platform_driver(idtfc3_driver);