diff mbox series

[net-next,v2,07/21] rxrpc: Do lazy DF flag resetting

Message ID	20240304084322.705539-8-dhowells@redhat.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel+bounces-90224-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; From: David Howells <dhowells@redhat.com> To: netdev@vger.kernel.org Cc: David Howells <dhowells@redhat.com>, Marc Dionne <marc.dionne@auristor.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 07/21] rxrpc: Do lazy DF flag resetting Date: Mon, 4 Mar 2024 08:43:04 +0000 Message-ID: <20240304084322.705539-8-dhowells@redhat.com> In-Reply-To: <20240304084322.705539-1-dhowells@redhat.com> References: <20240304084322.705539-1-dhowells@redhat.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	rxrpc: Miscellaneous changes and make use of MSG_SPLICE_PAGES \| [net-next,v2,00/21] rxrpc: Miscellaneous changes and make use of MSG_SPLICE_PAGES [net-next,v2,01/21] rxrpc: Record the Tx serial in the rxrpc_txbuf and retransmit trace [net-next,v2,02/21] rxrpc: Convert rxrpc_txbuf::flags into a mask and don't use atomics [net-next,v2,03/21] rxrpc: Note cksum in txbuf [net-next,v2,04/21] rxrpc: Fix the names of the fields in the ACK trailer struct [net-next,v2,05/21] rxrpc: Strip barriers and atomics off of timer tracking [net-next,v2,06/21] rxrpc: Remove atomic handling on some fields only used in I/O thread [net-next,v2,07/21] rxrpc: Do lazy DF flag resetting [net-next,v2,08/21] rxrpc: Merge together DF/non-DF branches of data Tx function [net-next,v2,09/21] rxrpc: Add a kvec[] to the rxrpc_txbuf struct [net-next,v2,10/21] rxrpc: Split up the DATA packet transmission function [net-next,v2,11/21] rxrpc: Don't pick values out of the wire header when setting up security [net-next,v2,12/21] rxrpc: Move rxrpc_send_ACK() to output.c with rxrpc_send_ack_packet() [net-next,v2,13/21] rxrpc: Use rxrpc_txbuf::kvec[0] instead of rxrpc_txbuf::wire [net-next,v2,14/21] rxrpc: Do zerocopy using MSG_SPLICE_PAGES and page frags [net-next,v2,15/21] rxrpc: Parse received packets before dealing with timeouts [net-next,v2,16/21] rxrpc: Don't permit resending after all Tx packets acked [net-next,v2,17/21] rxrpc: Differentiate PING ACK transmission traces. [net-next,v2,18/21] rxrpc: Use ktimes for call timeout tracking and set the timer lazily [net-next,v2,19/21] rxrpc: Record probes after transmission and reduce number of time-gets [net-next,v2,20/21] rxrpc: Clean up the resend algorithm [net-next,v2,21/21] rxrpc: Extract useful fields from a received ACK to skb priv data

Commit Message

David Howells March 4, 2024, 8:43 a.m. UTC

  Don't reset the DF flag after transmission, but rather set it when needed
since it should be a fast op now that we call IP directly.

This includes turning it off for RESPONSE packets and, for the moment, ACK
packets.  In future, we will need to turn it on for ACK packets used to do
path MTU discovery.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: "David S. Miller" <davem@davemloft.net>
cc: Eric Dumazet <edumazet@google.com>
cc: Jakub Kicinski <kuba@kernel.org>
cc: Paolo Abeni <pabeni@redhat.com>
cc: linux-afs@lists.infradead.org
cc: netdev@vger.kernel.org
---
 net/rxrpc/output.c | 4 ++--
 net/rxrpc/rxkad.c  | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
index 1e039b6f4494..8aa8ba32eacc 100644
--- a/net/rxrpc/output.c
+++ b/net/rxrpc/output.c
@@ -231,6 +231,7 @@  int rxrpc_send_ack_packet(struct rxrpc_call *call, struct rxrpc_txbuf *txb)
 	txb->ack.previousPacket	= htonl(call->rx_highest_seq);
 
 	iov_iter_kvec(&msg.msg_iter, WRITE, iov, 1, len);
+	rxrpc_local_dont_fragment(conn->local, false);
 	ret = do_udp_sendmsg(conn->local->socket, &msg, len);
 	call->peer->last_tx_at = ktime_get_seconds();
 	if (ret < 0) {
@@ -406,6 +407,7 @@  int rxrpc_send_data_packet(struct rxrpc_call *call, struct rxrpc_txbuf *txb)
 	 * think it's small enough */
 	if (txb->len >= call->peer->maxdata)
 		goto send_fragmentable;
+	rxrpc_local_dont_fragment(conn->local, true);
 
 	txb->wire.flags = txb->flags & RXRPC_TXBUF_WIRE_FLAGS;
 	txb->last_sent = ktime_get_real();
@@ -492,8 +494,6 @@  int rxrpc_send_data_packet(struct rxrpc_call *call, struct rxrpc_txbuf *txb)
 		rxrpc_inc_stat(call->rxnet, stat_tx_data_send_frag);
 		ret = do_udp_sendmsg(conn->local->socket, &msg, len);
 		conn->peer->last_tx_at = ktime_get_seconds();
-
-		rxrpc_local_dont_fragment(conn->local, true);
 		break;
 
 	default:
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index 28c9ce763be4..e451ac90bfee 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -726,7 +726,6 @@  static int rxkad_send_response(struct rxrpc_connection *conn,
 
 	rxrpc_local_dont_fragment(conn->local, false);
 	ret = kernel_sendmsg(conn->local->socket, &msg, iov, 3, len);
-	rxrpc_local_dont_fragment(conn->local, true);
 	if (ret < 0) {
 		trace_rxrpc_tx_fail(conn->debug_id, serial, ret,
 				    rxrpc_tx_point_rxkad_response);