diff mbox series

Removed inputq,namedq field description to prevent kernel doc warnings.

Message ID 20240303143919.6903-1-prosunofficial@gmail.com
State New
Headers
Series Removed inputq,namedq field description to prevent kernel doc warnings. |

Commit Message

R SUNDAR March 3, 2024, 2:39 p.m. UTC 
  /net/tipc/node.c:150: warning: Excess struct member 'inputq' description in 'tipc_node'
/net/tipc/node.c:150: warning: Excess struct member 'namedq' description in 'tipc_node'

Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
---
 net/tipc/node.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Randy Dunlap March 3, 2024, 4:41 p.m. UTC | #1 
Hi,

On 3/3/24 06:39, R SUNDAR wrote:
> /net/tipc/node.c:150: warning: Excess struct member 'inputq' description in 'tipc_node'
> /net/tipc/node.c:150: warning: Excess struct member 'namedq' description in 'tipc_node'
> 
> Signed-off-by: R SUNDAR <prosunofficial@gmail.com>

This is already fixed in linux-next and net-next, as was another one of your
patches.
I suggest that you focus more on the -next trees for such patch targets.

Thanks.

> ---
>  net/tipc/node.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/tipc/node.c b/net/tipc/node.c
> index 3105abe97bb9..c1e890a82434 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -86,8 +86,6 @@ struct tipc_bclink_entry {
>   * @lock: rwlock governing access to structure
>   * @net: the applicable net namespace
>   * @hash: links to adjacent nodes in unsorted hash chain
> - * @inputq: pointer to input queue containing messages for msg event
> - * @namedq: pointer to name table input queue with name table messages
>   * @active_links: bearer ids of active links, used as index into links[] array
>   * @links: array containing references to all links to node
>   * @bc_entry: broadcast link entry
Simon Horman March 4, 2024, 5:32 p.m. UTC | #2 
On Sun, Mar 03, 2024 at 08:41:56AM -0800, Randy Dunlap wrote:
> Hi,
> 
> On 3/3/24 06:39, R SUNDAR wrote:
> > /net/tipc/node.c:150: warning: Excess struct member 'inputq' description in 'tipc_node'
> > /net/tipc/node.c:150: warning: Excess struct member 'namedq' description in 'tipc_node'
> > 
> > Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
> 
> This is already fixed in linux-next and net-next, as was another one of your
> patches.
> I suggest that you focus more on the -next trees for such patch targets.

Yes, agreed. A similar patch was accepted in January.

Link: https://git.kernel.org/netdev/net-next/c/5ca1a5153a28
diff mbox series

Patch

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 3105abe97bb9..c1e890a82434 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -86,8 +86,6 @@  struct tipc_bclink_entry {
  * @lock: rwlock governing access to structure
  * @net: the applicable net namespace
  * @hash: links to adjacent nodes in unsorted hash chain
- * @inputq: pointer to input queue containing messages for msg event
- * @namedq: pointer to name table input queue with name table messages
  * @active_links: bearer ids of active links, used as index into links[] array
  * @links: array containing references to all links to node
  * @bc_entry: broadcast link entry