From patchwork Sat Mar 2 00:16:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Pylypiv X-Patchwork-Id: 209134 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp234040dyc; Fri, 1 Mar 2024 16:19:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXjJVAHycWKofE8i72+A0bQcGLAw1WMqgvic74PumOjiJPpqJWA5bbAFgog5e/HeP9Rrvfw2g0QxYGW/qKAcRqJtknZmQ== X-Google-Smtp-Source: AGHT+IGOckkhBmlSxdDBMNzrWhVuhiXoMsPVQQd8HRmi81Gvnf3QJlzYu+/LCSAbJ8MBsS0fmhBE X-Received: by 2002:a17:90b:4d8d:b0:29a:83da:efd1 with SMTP id oj13-20020a17090b4d8d00b0029a83daefd1mr3184446pjb.6.1709338773681; Fri, 01 Mar 2024 16:19:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709338773; cv=pass; d=google.com; s=arc-20160816; b=N8qe0fEjtTztRoY+7eh4z9Q426zr7u6bdtLbb+ok+SF1li6URvNLRRTMV5JBnMhJFK AU5acQOAii1FhkuakUvb66TONvjmDH1QUptDQY8GfsEY3GXXqNWEBeoIUfYg+2cwvTmS JhOH/t7yoIBgWo9AT5SvqcHzhSI/+H+i4Kd3lKAeScplX8YXm0EsVnWJDSXQgu7WVrXj +GMPZ7jobpt5KPhcIG0iTINDuaNKKAv0cmt4je16kQoUonYuE5lIBXkFBxs+Yg7oJFj+ WhkaTU1ptCISGsHhBknVGohROIIJgFuFZAkGweutnmMN0wzfd1HqZjKW4xDkHsv25p2g UfwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=jZVgry90rEYwnQ29s3Mz+RKBDNtmCmbKQoUc6PEOd2Y=; fh=8S4yxS4kN94meou5RHToSOITy+kNAVIII1wuWwN85xY=; b=rfbMg/hRvksO9j4fpZttOaxqZo/ub7GAuW1X6DXxomDvvVHVPjyOfSq1l422Zg/n3i qbCafM7WwdcBW5VdqLNDNwsvGcHXxzMtwf1TVecDKcz1+/xE4krCO/DjCEjER/rKQtg9 TgRHj4WJgm1+lILBu45WYAGjc/NEJOPsEX02SZvPdYVZYMN+2YBuafl1xLeXQhp17aua E2284MWk4o+9Yi3EiOBVNi+OO14KSp0MOqObGQ2L8zwYojiWhLyBCLIWBbM2h4Tq7gxt peJ26Oq29veP20CnO09H+LoxlP2+QTRKYFXAHiKPvkoDwu/+k4NljYl0SyMXZZt0YYaX rqSg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=PPcCR5CE; arc=pass (i=1 spf=pass spfdomain=flex--ipylypiv.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-89261-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89261-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id oh8-20020a17090b3a4800b0029b2fd9a5f2si920752pjb.80.2024.03.01.16.19.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 16:19:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89261-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=PPcCR5CE; arc=pass (i=1 spf=pass spfdomain=flex--ipylypiv.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-89261-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89261-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3A9D7B252F5 for ; Sat, 2 Mar 2024 00:18:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1C7B713AE8; Sat, 2 Mar 2024 00:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PPcCR5CE" Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695FC10A16 for ; Sat, 2 Mar 2024 00:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709338622; cv=none; b=VBgrAWK7RrAHojoq3MooTT4P+TaL4m/zahhjbGVTmNru6mp0NWBCQGDse0Sa37sUjKVfujm4ak2IW/ybWYZNFdJdkwAUfLB25mV8qA48qV5I92ISZYW35ZNi53LSldBVtWZ8xIm9wCyj/9lbFZLUL/htq0H/ZFO1uwFyidffbqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709338622; c=relaxed/simple; bh=KWCF/wRFo5DDf67uvUwFxQaljHz80tfPANfuy0kjn8k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GJNo8aTxB0r6kIUk+6jZgR14bq3RDLdVnGEbyMVh7wmSeoCPBhzc11qPESozzfD1jdSoYeV+AeNou0gULFFZQl+RwQFY28LyaQULL5r0DovX1Ca8PqHImoJbbn+wyCIndc5UrsqHNFnz7dIB0abgqyJQVIhZyCWghg0GdT20QBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PPcCR5CE; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ipylypiv.bounces.google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dd001f821caso1473413276.0 for ; Fri, 01 Mar 2024 16:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709338620; x=1709943420; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jZVgry90rEYwnQ29s3Mz+RKBDNtmCmbKQoUc6PEOd2Y=; b=PPcCR5CEhwa0igG15qOeDKade+YVH33V+GStmueu6YH5qGA3tH4ZqBlo2/XdZ+EJUv WG8rglQlpML/1MyFJXYK1W7r4FeX+GhaGDeAPyHqpNPNjuBTamFp1gzMJWI5YZ8zV0w1 mZ4KJsmXNkuinhEXPO4WmRrHF04fS//fG+ZFHdZpPB0KgyrBM6Vn0W6IUBzRMR5vtuxi DyfiqEKujt3wn1Wua03zsYWpp5weiXFdED7VRifzic0u8GZbni1HD4UTDn3bbUDyEDhp TMwkLekUaYUSyUgF3WMZB8ASjvk4hPTwyz/0jhLOYo1qHNtInjtBHDy8/yp+xqaz/o7l rq/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709338620; x=1709943420; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jZVgry90rEYwnQ29s3Mz+RKBDNtmCmbKQoUc6PEOd2Y=; b=idKTLipGeWe4E4bXYJjzX01KyRZBOvG5OiEk/X4m1GyxuIIafONEODZZH3FXkiQvo8 PBkLT8gXVDoM1lVWhs9QwSFdPxFOODNfAet5SazAPOclcg1PYB/5F5s0rcZ2FkcJ/hag x6eWdjsXsx2EjNrCisiTmBH1vNykb+0DkFpPGoypD8z+4hkkXa1osPVhQBnHvrDiBC2f ASy7a8z0oAHbUI/oT1UMgyQjeYhsbjpTHw2bzlK5qrGa0vbC92r4TKToGWGw7mfIj2tO ++dFj6ZtJBNCrVUKR+xt7Ip8G/qRxIzxj8di5A4J/wvfmzPEcREyaooMU28g6QFbZgdf thSw== X-Forwarded-Encrypted: i=1; AJvYcCV53uk2lA7kD5Z+fSFP1bDSZjD68u5ps8lPdS4WsUa2l/neJX7xDVioK1eIJhIPjoKhaIV+fiKZsgP0zvF+dCsAAapCMWtVBuo9iwEJ X-Gm-Message-State: AOJu0Yz540ogEZS9aCl3DFo/VtgdgPXhralWpCqGug0+dSkZD2m8wx0q 4NPamYQCy3E4TRb6lFZFxCXUCiCbspVCkJA78glJTZKQLLLlI+tRQJSG+Eyfq0OmcGoP1fyVHi1 G6+kruqVCpg== X-Received: from ipylypiv.svl.corp.google.com ([2620:15c:2c5:13:2afe:1a8e:f846:999f]) (user=ipylypiv job=sendgmr) by 2002:a05:6902:505:b0:dc7:4ca0:cbf0 with SMTP id x5-20020a056902050500b00dc74ca0cbf0mr1203600ybs.3.1709338620711; Fri, 01 Mar 2024 16:17:00 -0800 (PST) Date: Fri, 1 Mar 2024 16:16:00 -0800 In-Reply-To: <20240302001603.1012084-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240302001603.1012084-1-ipylypiv@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240302001603.1012084-4-ipylypiv@google.com> Subject: [PATCH v2 3/5] scsi: pm80xx: Add libsas SATA sysfs attributes group From: Igor Pylypiv To: Damien Le Moal , Niklas Cassel , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Jack Wang , Hannes Reinecke Cc: TJ Adams , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Pylypiv X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792371613900825297 X-GMAIL-MSGID: 1792371613900825297 The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Signed-off-by: Igor Pylypiv --- drivers/scsi/pm8001/pm8001_ctl.c | 5 +++++ drivers/scsi/pm8001/pm8001_init.c | 1 + drivers/scsi/pm8001/pm8001_sas.h | 1 + 3 files changed, 7 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 5c26a13ffbd2..9ffe1a868d0f 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -1039,3 +1039,8 @@ const struct attribute_group *pm8001_host_groups[] = { &pm8001_host_attr_group, NULL }; + +const struct attribute_group *pm8001_sdev_groups[] = { + &sas_ata_sdev_attr_group, + NULL +}; diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index ed6b7d954dda..e6b1108f6117 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -134,6 +134,7 @@ static const struct scsi_host_template pm8001_sht = { .compat_ioctl = sas_ioctl, #endif .shost_groups = pm8001_host_groups, + .sdev_groups = pm8001_sdev_groups, .track_queue_depth = 1, .cmd_per_lun = 32, .map_queues = pm8001_map_queues, diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h index 3ccb7371902f..ced6721380a8 100644 --- a/drivers/scsi/pm8001/pm8001_sas.h +++ b/drivers/scsi/pm8001/pm8001_sas.h @@ -717,6 +717,7 @@ int pm80xx_fatal_errors(struct pm8001_hba_info *pm8001_ha); void pm8001_free_dev(struct pm8001_device *pm8001_dev); /* ctl shared API */ extern const struct attribute_group *pm8001_host_groups[]; +extern const struct attribute_group *pm8001_sdev_groups[]; #define PM8001_INVALID_TAG ((u32)-1)