From patchwork Fri Mar 1 18:55:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 209036 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp87982dyc; Fri, 1 Mar 2024 10:58:40 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUwHrXCQb3J77xRNkeFofOBCn9EZ5hO7LN/RoPAbmfniYJcetkjehVkpcw3PrTfS75f7fqw6Z2vYSl1JSuL4613LN551w== X-Google-Smtp-Source: AGHT+IF/oEjmLzvd7wMsmyMRGpKbt6lehOAlX5FdS6/lNwVl6XfcrBBfSljML4OQVC8IVnrgmCSy X-Received: by 2002:a05:622a:386:b0:42e:bbf5:84e7 with SMTP id j6-20020a05622a038600b0042ebbf584e7mr2341852qtx.16.1709319520643; Fri, 01 Mar 2024 10:58:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709319520; cv=pass; d=google.com; s=arc-20160816; b=Zy7VXNtVZOivAUZddNYzAN5y4LdWsK31+yD9fKVe+TkLAM37gsqPY8lMDFPT+9huiM OZ1hHCoOv/i8ES+RsiDXJ8EgSAz8NRHmS1cmfcyzlqBoFliE0ui21B//fsFMbjCMlGNR UZ7h4lkFBVGUt+LaF0F6JSYIBwSMEDEAMU5abKzyIR4ouWvl8FgFdM1v3TLdTwIdNpQj xrVcldmXEGAUhH0p/mcXxGURlQDgN4QfYwn2AZ6ZHTgePE/GRsmgsuDuYF4GP3va7s4/ PVtD+TAq1TLj0XDesZL5cqtYy18JWXKXuXpQCmhFlz43ks/m93XuUgtkWFPAv8FFkm6P lexQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:references:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:in-reply-to:date :dkim-signature; bh=G7yzNIE0K5lHOvKYMdHiv1H80sWzgzKkY1SnsP+lPB0=; fh=Jynj71PI35oieuGoGM/mGe6x0nDFYovmizNBd2giSVw=; b=Dvc5KGdjIOCvOrPYHPTiRjoIzDWqzDE6JilvF2ChE8DSX+9Vrp5phyF5c3nJ18pfr0 T0BBTjtyJ9UyRqPAelI80jEappOL+ol3beZHTOmqAKYCD4hzOMVxWMgl9pCxGITxYj+R AIJPz3VP/zKa+xePZ45chLTxWvL01PH1NPV3qzOblersfLgCJsE/gWcLOex7EX5WMK+Z lVOqtmWkS4QANBUdx9bICXAWGWGwf1RtV2LrwPozhZ8u1rXnA8Gn9nWFu/1KKTVHIm2X GH39rvU7ouUWWZwXSXXUg3C4aPRUz4QCEoJOGr9uQ7oXh/9jhu+aQ/ems1A1i7HVa0NY Qk3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=u6kwWqdY; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-88966-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88966-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d14-20020ac8544e000000b0042e808c4b11si3813010qtq.784.2024.03.01.10.58.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 10:58:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88966-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=u6kwWqdY; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-88966-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88966-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 60D921C23538 for ; Fri, 1 Mar 2024 18:58:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 296BA3D551; Fri, 1 Mar 2024 18:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u6kwWqdY" Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76F253CF72 for ; Fri, 1 Mar 2024 18:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709319395; cv=none; b=ol4jY+ARRFoj7u/TLznzvJM6W4/C+zCIZqQSZEq2GEB8IJNU2QLcJf3xUhQhMVaMnNXuNlvcxP6v44FulAAD55e3ZSSPBYBsEMiSEHJyeWH/XVPtwUx/ub1LjFp5utvOv2iYajCwWhk/THHWNXWQ307s+v/P63HwDb2AfEaprIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709319395; c=relaxed/simple; bh=r4ihq+erhDIJ96eTIi6uun2xGpgFyBqf/JqZ/4nXlRw=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=pzYvgJtKfL+j/DIBvX7UBrqQTYwngtG4i+4yXo4pN94T72tYXn496RAYTnycDTHtKdPZJkUZUh8ThoJkMlsJkTweEMnURvWcpvab+A/ZgsBRKuwkXn0wlg//6/tvfD4CRS7ukp2WRyf7hAvg19smSJwJUNutAhiXsChCPv1J2qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u6kwWqdY; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6b269686aso3612614276.1 for ; Fri, 01 Mar 2024 10:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709319392; x=1709924192; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=G7yzNIE0K5lHOvKYMdHiv1H80sWzgzKkY1SnsP+lPB0=; b=u6kwWqdYUqf5ggYScGevoedifLvbkx3oW50/pWIIElME6tZ/SNYxTL0fQ4EsufPWqB MfBNXd8KpBg72OSx/Mbzy71b/frPpli2FO02pSdH27A305tTgbMCS5qwS9HphZKF+SWA IeB5domtpNlFof9dKUIM1gqsyMePmlYWI3AEkvu1fzba9vOd4wVeSRpfU9CXy25wFWgX qk6nyjoPKqsvHHZlLgBCnUh8Tkt0aCrDjj+ErcNUVxklBFqbESmIm6h62viLNxzKpZKp eaRkRzDyJofvOd6+tyAmVlFHqHcMoqGmNEiiHR6NReBfT0ThJZ/u7IVErKW5BiLRwjPo uXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709319392; x=1709924192; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7yzNIE0K5lHOvKYMdHiv1H80sWzgzKkY1SnsP+lPB0=; b=lQqdKv9WAVCDuysNrJLzDnzABtvEehW5cjKcHHjZ7h85yeq8cO7s3skzv/GznfqyC2 WwHTw7WLfO2UXCtd4NRrsQ45+zJmdf4Endhj+oC2Jcxnpi9ownYDk59oYUyKtUy9Qulh 5OvvdMX6YQdKtwFdA4Za7f4ojso7VzNQhjvkTXTATrm9yaqtEPoYDZfHQZR2c2mPG24i hZ/fVvyFxAEXuBQ4j/QnWMFfpcIZUGExdjub9w209/vI3MqKPXeoT2BAa2U2C39MTU/M 49cPr5Orl0wjxHtWtxTN7SCIUDx7yJhKRslzhjHRvIGhZAoebiNt0qT/my6MQ2veUpTo vZeg== X-Forwarded-Encrypted: i=1; AJvYcCUwMG+0EGGJcveN/F798PFTOcIZfyhELoYib+8yQGw1U6XGKt46+AUY7els4475AZCAZwq3M5fs1b0PCuCNk3SPAEfodxTYLE6RSRzj X-Gm-Message-State: AOJu0YwSPe3tvgSE6uUBmPfED3J2ANf9JfpocQqKEuyKs1c0KGIJj+mn IXcIvuZHkdGYYcDWwgPUMY2x4Rfyl5DX2AATwfCPGoDgnws+OPmlMwKWpbg8LrAzr/K9pQcF05y VTHiejA== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:af4b:7fc1:b7be:fcb7]) (user=irogers job=sendgmr) by 2002:a05:6902:2206:b0:dc2:26f6:fbc8 with SMTP id dm6-20020a056902220600b00dc226f6fbc8mr101587ybb.7.1709319392696; Fri, 01 Mar 2024 10:56:32 -0800 (PST) Date: Fri, 1 Mar 2024 10:55:47 -0800 In-Reply-To: <20240301185559.2661241-1-irogers@google.com> Message-Id: <20240301185559.2661241-9-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240301185559.2661241-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Subject: [PATCH v2 08/20] perf jevents: Add ports metric group giving utilization on Intel From: Ian Rogers To: Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792351425302580353 X-GMAIL-MSGID: 1792351425302580353 The ports metric group contains a metric for each port giving its utilization as a ratio of cycles. The metrics are created by looking for UOPS_DISPATCHED.PORT events. Signed-off-by: Ian Rogers --- tools/perf/pmu-events/intel_metrics.py | 33 ++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events/intel_metrics.py index 6c42c8947652..49b83bc28891 100755 --- a/tools/perf/pmu-events/intel_metrics.py +++ b/tools/perf/pmu-events/intel_metrics.py @@ -1,12 +1,13 @@ #!/usr/bin/env python3 # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) from metric import (d_ratio, has_event, max, CheckPmu, Event, JsonEncodeMetric, - JsonEncodeMetricGroupDescriptions, LoadEvents, Metric, - MetricGroup, MetricRef, Select) + JsonEncodeMetricGroupDescriptions, Literal, LoadEvents, + Metric, MetricGroup, MetricRef, Select) import argparse import json import math import os +import re from typing import Optional parser = argparse.ArgumentParser(description="Intel perf json generator") @@ -18,6 +19,11 @@ directory = f"{os.path.dirname(os.path.realpath(__file__))}/arch/x86/{args.model LoadEvents(directory) interval_sec = Event("duration_time") +core_cycles = Event("CPU_CLK_UNHALTED.THREAD_P_ANY", + "CPU_CLK_UNHALTED.DISTRIBUTED", + "cycles") +# Number of CPU cycles scaled for SMT. +smt_cycles = Select(core_cycles / 2, Literal("#smt_on"), core_cycles) def Idle() -> Metric: cyc = Event("msr/mperf/") @@ -266,6 +272,28 @@ def IntelBr(): description="breakdown of retired branch instructions") +def IntelPorts() -> Optional[MetricGroup]: + pipeline_events = json.load(open(f"{os.path.dirname(os.path.realpath(__file__))}" + f"/arch/x86/{args.model}/pipeline.json")) + + metrics = [] + for x in pipeline_events: + if "EventName" in x and re.search("^UOPS_DISPATCHED.PORT", x["EventName"]): + name = x["EventName"] + port = re.search(r"(PORT_[0-9].*)", name).group(0).lower() + if name.endswith("_CORE"): + cyc = core_cycles + else: + cyc = smt_cycles + metrics.append(Metric(port, f"{port} utilization (higher is better)", + d_ratio(Event(name), cyc), "100%")) + if len(metrics) == 0: + return None + + return MetricGroup("ports", metrics, "functional unit (port) utilization -- " + "fraction of cycles each port is utilized (higher is better)") + + def IntelSwpf() -> Optional[MetricGroup]: ins = Event("instructions") try: @@ -336,6 +364,7 @@ all_metrics = MetricGroup("", [ Smi(), Tsx(), IntelBr(), + IntelPorts(), IntelSwpf(), ])