From patchwork Fri Mar 1 13:42:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 208858 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp1085101dyb; Fri, 1 Mar 2024 05:44:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUZnQb8VArVOqzCNwAJNGI5aA3C16tTfu6hOmjeTkDU+9u8v8CgdFYWbpcn5i/e4txjF9OKlYErRJuUB49RJgSQwGrGRA== X-Google-Smtp-Source: AGHT+IHCx6JQoaibDYydLJI1+Wtm/XB+F1zjADwpUtpDlgJ3KM9M/FZ8n0wU6H+cMLbuNa4Scip5 X-Received: by 2002:a17:907:b01:b0:a44:9260:3190 with SMTP id h1-20020a1709070b0100b00a4492603190mr1156870ejl.0.1709300694144; Fri, 01 Mar 2024 05:44:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709300694; cv=pass; d=google.com; s=arc-20160816; b=rMzvsSGxPAWoQYZu2NTSMHE/8KHKkiYoSItBeGzwcQ+yxCzIcXwsLi8VBY3k8IjrUg Epcwkqb5R7K6Jhk3tr6sohNKN38cgYK5J2tS2yk8mu1fiKNa451Emn207mCk4Zj7NSHN FrXKztlQPrSViuN0DVQKHpcjzt9oL7sga0rn0l2ApjmJNMicpD9Z8B2noXMU3r3OZCG1 00VgKn+XoARGyPZfmfDa+n4ZVtEojxkO6dKDr7k+EnfbBrHI4X4bRCtE6iLqamg5RBly HWvc2Ryhh25hxpDIOgDLSztggwiG9XpEcGwvq3la8X2RtWfPrWS3o4X3iLUVrjOzSYEJ +f/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=9taPaBKehcb4ahcbhUFAwNa2TaUPUJg1amPsCfHtP5k=; fh=K9ttdSQN9MPssgZG+Y0FKjFlz/tSg+FtlQipO15IWdQ=; b=Wa/WELfaHuhXX0SFvWuwXsgmgV4OhmPUMC0/h62Iyz1suY8yVVbb24pvBgQeJg4EHT OAoLD9R/+AEvekCcxUnsJxVD2OQ9DXLxoFtqiyWmWe0+vFFeVuYzC7V+dTNW/v3FjFti yjFFPcNj+NSBkEl/aN4JRTPRivxCDjWOM/D59tOPi0jobCnU5t3sMjI/sTkEu1ES4cyW LWSJXmmwJ5AqDpmFTPi3iLVZNTcAAbPa2rnDyYEfi6YxyoXN1HzbsAcKoH7jOVgnUE6M sTGlou7+DZudIB7qWIs695tG6n3quuOeKVrbW2MmeIsMStLoevRe3Jtufsd//WsgGEOI BsaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-88508-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88508-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id xa9-20020a170907b9c900b00a3ec7482fa7si1502183ejc.915.2024.03.01.05.44.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:44:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88508-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-88508-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88508-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C1AB51F24873 for ; Fri, 1 Mar 2024 13:44:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86D666EB7D; Fri, 1 Mar 2024 13:42:29 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400296EB6A; Fri, 1 Mar 2024 13:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300547; cv=none; b=sVMyC8EFXpLan7KxbWLF5qOd1H04xl8PPV2iARBwBL0Qp4DeMt2RkIHhYAQqiMCvDqKz5paH1IHfzz7M0yIV7CW/9iyqDvuK36gZoTyHENwQm9WwKr7bIBEm60Mn5ynx34blMMcZVVhuVmhZQLN9EObybH2WyNPsHmXd/5uXzBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300547; c=relaxed/simple; bh=WPXkIQwvRLQBSZhlUEDaUobW7M6LNr8BRk9mM4f2BSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qkaMxve4bheHau4yGT12nRw1gdRmNr2pwgShD/NfolngE47miP1h0Rf1m9sqoo323oPzgsJp01fQ52CDpCoF61EMMxLA+vN+9A2AvN7r+R0Vc86lHpn8zMACDFqvC/dNXf2UM5hsN2vTINZ4t6MIGYWXX4IYDPzxLv7zRWdp+ZU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-33e12916565so1025153f8f.1; Fri, 01 Mar 2024 05:42:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709300544; x=1709905344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9taPaBKehcb4ahcbhUFAwNa2TaUPUJg1amPsCfHtP5k=; b=MpIX4non/LMKiLaU66ydg4JilGV7bm5WE+ADT/H1K04Gz+8iuireYOihZvQoiC9iv0 GxaedYG210leRlAm1KBqdw+k7lsqasyBH/gCOW/2MoyhzlvtRpP3eJyx2VwEsXLDSLDC 6y1vRu3IMJ1Q8PPHYrg+58D/oooADk5wYImQqUKctB/PDaJv7WYW/STp+ILnf2HNPu7h X+katRJL6j8VmSnZ/4ogmbbOcDb5C/7u9daYKxWzzS5ffQZ++V7DSkFYRmygcd36nlvw NFCK1v6Gs0skSejy81LAvfegJoTK+wt7fHZgZmfIiJY8rtqM8spAWauHIwvqlNKpTZBk cyzg== X-Forwarded-Encrypted: i=1; AJvYcCVo4gpZEPypHW7kyGSl43SSgxMWecYYXGKASXlEA7MW9MAWSzNRBq5nefyG5CONqfoeAwp/Uqf4JZzZBWa/2GnmmLuwWJlS4N5hA4xw X-Gm-Message-State: AOJu0YyHS3RnB+dsQkK0t6VNqiKydWdonchVM5sS7obMgzpwhqCx58Ch AKpWDpxBzUsq/E3FXi70R3Rg3KZFJCL5QfXss0ZY5HloeeNc60iK X-Received: by 2002:a5d:4152:0:b0:33d:d793:a20f with SMTP id c18-20020a5d4152000000b0033dd793a20fmr2027753wrq.27.1709300544344; Fri, 01 Mar 2024 05:42:24 -0800 (PST) Received: from localhost (fwdproxy-lla-003.fbsv.net. [2a03:2880:30ff:3::face:b00c]) by smtp.gmail.com with ESMTPSA id v6-20020a5d59c6000000b0033d926bf7b5sm4772895wry.76.2024.03.01.05.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:42:23 -0800 (PST) From: Breno Leitao To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, daniel@iogearbox.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, dsahern@kernel.org Subject: [PATCH net-next 2/2] net: nlmon: Simplify nlmon_get_stats64 Date: Fri, 1 Mar 2024 05:42:14 -0800 Message-ID: <20240301134215.1264416-2-leitao@debian.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240301134215.1264416-1-leitao@debian.org> References: <20240301134215.1264416-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792331684572874814 X-GMAIL-MSGID: 1792331684572874814 Do not set rtnl_link_stats64 fields to zero, since they are zeroed before ops->ndo_get_stats64 is called in core dev_get_stats() function. Also, simplify the data collection by removing the temporary variable. Signed-off-by: Breno Leitao Acked-by: Daniel Borkmann --- drivers/net/nlmon.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c index e026bfc83757..e5a0987a263e 100644 --- a/drivers/net/nlmon.c +++ b/drivers/net/nlmon.c @@ -40,15 +40,7 @@ static int nlmon_close(struct net_device *dev) static void nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) { - u64 packets, bytes; - - dev_lstats_read(dev, &packets, &bytes); - - stats->rx_packets = packets; - stats->tx_packets = 0; - - stats->rx_bytes = bytes; - stats->tx_bytes = 0; + dev_lstats_read(dev, &stats->rx_packets, &stats->rx_bytes); } static u32 always_on(struct net_device *dev)