diff mbox series

[net-next,2/2] net: nlmon: Simplify nlmon_get_stats64

Message ID 20240301134215.1264416-2-leitao@debian.org
State New
Headers
Series [net-next,1/2] net: nlmon: Remove init and uninit functions |

Commit Message

Breno Leitao March 1, 2024, 1:42 p.m. UTC 
  Do not set rtnl_link_stats64 fields to zero, since they are zeroed
before ops->ndo_get_stats64 is called in core dev_get_stats() function.

Also, simplify the data collection by removing the temporary variable.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/nlmon.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Daniel Borkmann March 1, 2024, 2:09 p.m. UTC | #1 
On 3/1/24 2:42 PM, Breno Leitao wrote:
> Do not set rtnl_link_stats64 fields to zero, since they are zeroed
> before ops->ndo_get_stats64 is called in core dev_get_stats() function.
> 
> Also, simplify the data collection by removing the temporary variable.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
diff mbox series

Patch

diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c
index e026bfc83757..e5a0987a263e 100644
--- a/drivers/net/nlmon.c
+++ b/drivers/net/nlmon.c
@@ -40,15 +40,7 @@  static int nlmon_close(struct net_device *dev)
 static void
 nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
 {
-	u64 packets, bytes;
-
-	dev_lstats_read(dev, &packets, &bytes);
-
-	stats->rx_packets = packets;
-	stats->tx_packets = 0;
-
-	stats->rx_bytes = bytes;
-	stats->tx_bytes = 0;
+	dev_lstats_read(dev, &stats->rx_packets, &stats->rx_bytes);
 }
 
 static u32 always_on(struct net_device *dev)