[5/5] mailbox: mtk-cmdq: Add support runtime get and set GCE event
Commit Message
ISP drivers need to get and set GCE event in their runtime contorl flow.
So add these functions to support get and set GCE by CPU.
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Change-Id: I494c34ebc5ec26c82213f2bc03d2033d60652523
---
drivers/mailbox/mtk-cmdq-mailbox.c | 37 ++++++++++++++++++++++++
include/linux/mailbox/mtk-cmdq-mailbox.h | 2 ++
2 files changed, 39 insertions(+)
Comments
Il 01/03/24 12:11, Jason-JH.Lin ha scritto:
> ISP drivers need to get and set GCE event in their runtime contorl flow.
> So add these functions to support get and set GCE by CPU.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Change-Id: I494c34ebc5ec26c82213f2bc03d2033d60652523
Change-Id makes no sense upstream. Please drop.
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 37 ++++++++++++++++++++++++
> include/linux/mailbox/mtk-cmdq-mailbox.h | 2 ++
> 2 files changed, 39 insertions(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index ead2200f39ba..d7c08249c898 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -25,7 +25,11 @@
> #define CMDQ_GCE_NUM_MAX (2)
>
> #define CMDQ_CURR_IRQ_STATUS 0x10
> +#define CMDQ_SYNC_TOKEN_ID 0x60
> +#define CMDQ_SYNC_TOKEN_VALUE 0x64
> +#define CMDQ_TOKEN_ID_MASK GENMASK(9, 0)
> #define CMDQ_SYNC_TOKEN_UPDATE 0x68
> +#define CMDQ_TOKEN_UPDATE_VALUE BIT(16)
> #define CMDQ_THR_SLOT_CYCLES 0x30
> #define CMDQ_THR_BASE 0x100
> #define CMDQ_THR_SIZE 0x80
> @@ -83,6 +87,7 @@ struct cmdq {
> struct cmdq_thread *thread;
> struct clk_bulk_data clocks[CMDQ_GCE_NUM_MAX];
> bool suspended;
> + spinlock_t event_lock; /* lock for gce event */
> };
>
> struct gce_plat {
> @@ -113,6 +118,38 @@ u8 cmdq_get_shift_pa(struct mbox_chan *chan)
> }
> EXPORT_SYMBOL(cmdq_get_shift_pa);
>
> +void cmdq_set_event(void *chan, u16 event_id)
> +{
> + struct cmdq *cmdq = container_of(((struct mbox_chan *)chan)->mbox,
> + typeof(*cmdq), mbox);
struct mbox_chan *mbc = chan;
struct cmdq *cmdq = container_of(mbc->mbox, ... etc); (and this fits in one line)
> + unsigned long flags;
> +
> + spin_lock_irqsave(&cmdq->event_lock, flags);
Why do you need irqsave/irqrestore? I think I know, but please explain.
> +
> + writel(CMDQ_TOKEN_UPDATE_VALUE | event_id, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE);
> +
> + spin_unlock_irqrestore(&cmdq->event_lock, flags);
> +}
> +EXPORT_SYMBOL(cmdq_set_event);
> +
> +u32 cmdq_get_event(void *chan, u16 event_id)
> +{
> + struct cmdq *cmdq = container_of(((struct mbox_chan *)chan)->mbox,
> + typeof(*cmdq), mbox);
> + unsigned long flags;
> + u32 value = 0;
> +
> + spin_lock_irqsave(&cmdq->event_lock, flags);
> +
> + writel(CMDQ_TOKEN_ID_MASK & event_id, cmdq->base + CMDQ_SYNC_TOKEN_ID);
> + value = readl(cmdq->base + CMDQ_SYNC_TOKEN_VALUE);
> +
> + spin_unlock_irqrestore(&cmdq->event_lock, flags);
> +
> + return value;
> +}
> +EXPORT_SYMBOL(cmdq_get_event);
> +
> static int cmdq_thread_suspend(struct cmdq *cmdq, struct cmdq_thread *thread)
> {
> u32 status;
> diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h
> index a8f0070c7aa9..f05cabd230da 100644
> --- a/include/linux/mailbox/mtk-cmdq-mailbox.h
> +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h
> @@ -79,5 +79,7 @@ struct cmdq_pkt {
> };
>
> u8 cmdq_get_shift_pa(struct mbox_chan *chan);
> +void cmdq_set_event(void *chan, u16 event_id);
> +u32 cmdq_get_event(void *chan, u16 event_id);
>
> #endif /* __MTK_CMDQ_MAILBOX_H__ */
@@ -25,7 +25,11 @@
#define CMDQ_GCE_NUM_MAX (2)
#define CMDQ_CURR_IRQ_STATUS 0x10
+#define CMDQ_SYNC_TOKEN_ID 0x60
+#define CMDQ_SYNC_TOKEN_VALUE 0x64
+#define CMDQ_TOKEN_ID_MASK GENMASK(9, 0)
#define CMDQ_SYNC_TOKEN_UPDATE 0x68
+#define CMDQ_TOKEN_UPDATE_VALUE BIT(16)
#define CMDQ_THR_SLOT_CYCLES 0x30
#define CMDQ_THR_BASE 0x100
#define CMDQ_THR_SIZE 0x80
@@ -83,6 +87,7 @@ struct cmdq {
struct cmdq_thread *thread;
struct clk_bulk_data clocks[CMDQ_GCE_NUM_MAX];
bool suspended;
+ spinlock_t event_lock; /* lock for gce event */
};
struct gce_plat {
@@ -113,6 +118,38 @@ u8 cmdq_get_shift_pa(struct mbox_chan *chan)
}
EXPORT_SYMBOL(cmdq_get_shift_pa);
+void cmdq_set_event(void *chan, u16 event_id)
+{
+ struct cmdq *cmdq = container_of(((struct mbox_chan *)chan)->mbox,
+ typeof(*cmdq), mbox);
+ unsigned long flags;
+
+ spin_lock_irqsave(&cmdq->event_lock, flags);
+
+ writel(CMDQ_TOKEN_UPDATE_VALUE | event_id, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE);
+
+ spin_unlock_irqrestore(&cmdq->event_lock, flags);
+}
+EXPORT_SYMBOL(cmdq_set_event);
+
+u32 cmdq_get_event(void *chan, u16 event_id)
+{
+ struct cmdq *cmdq = container_of(((struct mbox_chan *)chan)->mbox,
+ typeof(*cmdq), mbox);
+ unsigned long flags;
+ u32 value = 0;
+
+ spin_lock_irqsave(&cmdq->event_lock, flags);
+
+ writel(CMDQ_TOKEN_ID_MASK & event_id, cmdq->base + CMDQ_SYNC_TOKEN_ID);
+ value = readl(cmdq->base + CMDQ_SYNC_TOKEN_VALUE);
+
+ spin_unlock_irqrestore(&cmdq->event_lock, flags);
+
+ return value;
+}
+EXPORT_SYMBOL(cmdq_get_event);
+
static int cmdq_thread_suspend(struct cmdq *cmdq, struct cmdq_thread *thread)
{
u32 status;
@@ -79,5 +79,7 @@ struct cmdq_pkt {
};
u8 cmdq_get_shift_pa(struct mbox_chan *chan);
+void cmdq_set_event(void *chan, u16 event_id);
+u32 cmdq_get_event(void *chan, u16 event_id);
#endif /* __MTK_CMDQ_MAILBOX_H__ */