From patchwork Fri Mar 1 22:58:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 209120 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp202411dyc; Fri, 1 Mar 2024 14:59:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWVdekeUJgslsJ3xPWF9/4Y3aOva+C+AohcEgkAUzrI1t4Jp9+Z96kGu21dVoNacUAbCiNoj4QNJzB7ZCeFqi3U1blMnQ== X-Google-Smtp-Source: AGHT+IGrMWySX6xBVMm8xBp/weKyR5ED5ccoL841WO3Bt4/DCyJM4ABAEbdhrt3Zs14mpzkCSK39 X-Received: by 2002:a05:620a:4690:b0:788:17fd:cbf5 with SMTP id bq16-20020a05620a469000b0078817fdcbf5mr624997qkb.12.1709333976554; Fri, 01 Mar 2024 14:59:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709333976; cv=pass; d=google.com; s=arc-20160816; b=ysP9zAFKu5zfuderpissAlOqKfKky+zPJ2tuSU9hwy3Q0bOikYmfy1Y1EF1cOc54Q5 mSSflEAkn4VlroXrn6o7/s5oFAS/HlV8HSd2sdr3TugkLiByzzuZYiYtXiuh+G+cKjxT o7yCH8eyLw02NkscVaDKdmvUNNSAGFFq8PVBlWgMubdI/8qDqV3kAqhLeikKmPffjNwD QAU9AxZwakyTJKwhFuXfoOcopuKliWOFJt0s3yHB7Q64VifP9NRQc3KvNv3ZR8YAoyrI Ue2jjI3p/RRyn9AhJAWG1OBNoqlGIB24WWx0oBwVgcaOen3Z/JGepKwHe7dq9a9HXk6R rgnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from; bh=k+KL/gACFqb6RmDCsbGM6rHn1/81wsrs55HOC+iSX8Y=; fh=fY3q4WsPAcGDPf0ZQS9NFw3egwkHKwM1oSX66e6BsRQ=; b=C1599xFZtdXtrBxGZdj6p20yiurqSc+42s2s+mA+xfqC7KwIEs5exarnFH8K1z+eWw 7ahAl049AHDm3jfLWQLcu3uTIvwK0AN2D/gmxMfafvjtx644dYfDBHYRCgUUamfZZpRF 8YQtmrVO5aESKMQ6hseVR9ZyF52T4Jqd8nosBQIcWqY0hF3+l6WAq6C+n0lI9EKgSkWg EYwHVTrjLurjgZ1Z2tJxoolGv6+ABTAxz7p1UdiJBfF9r+sYKK7A6+8v2+dCeUN/iteC E+9e+fYehgd0dPJCxrlTB87ZogG0b30Rk8Gr5WyxsX3i9DOhSIJvkC+vbBmOW4RpwkLT EU+g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-89213-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89213-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h3-20020a05620a10a300b00787b488e2e8si4520812qkk.154.2024.03.01.14.59.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 14:59:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89213-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-89213-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89213-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 56D3E1C21ED1 for ; Fri, 1 Mar 2024 22:59:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 914C55F54D; Fri, 1 Mar 2024 22:59:02 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B6F25EE9B; Fri, 1 Mar 2024 22:59:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709333941; cv=none; b=VCoRroxSO+V+eM9pIJfQCQYpuK68kIsE4a+X+EPdON6GYksa+3SSkReBrHforWuwlidlloK5NaEU8uJPIaJCYNZgqr0nUxUpRwJUTmZ+SzefWMxlWHBOEvno9eiixLIK+F++xD8oQmpRIOOcfn7Qr3PiruONBI0fEPPz5Yz1d3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709333941; c=relaxed/simple; bh=JL8wKNHOdoEnADynpbW3pJQDwz790tyACZpDiAY2J+I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PCHAFiyB7u0SWRUhO5ilsORiwf63Vwb7cUc5wiTRFTWIRskEe9cmy8ZYixScOZ64+/xAuth/h68dAjN6w5Ib2rBQ/JqlFjItOYWMn88JlKZQ2xOhDDDh1Stf7Y9Fmn2yBefZhjhT7dNO/e9A1JhTTzwD0kszWFPfTUo4GGwkgvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF543C43399; Fri, 1 Mar 2024 22:58:59 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id C970410633E3; Fri, 1 Mar 2024 23:58:56 +0100 (CET) From: Sebastian Reichel Date: Fri, 01 Mar 2024 23:58:27 +0100 Subject: [PATCH 2/2] power: supply: core: simplify power_supply_class_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240301-psy-class-cleanup-v1-2-aebe8c4b6b08@collabora.com> References: <20240301-psy-class-cleanup-v1-0-aebe8c4b6b08@collabora.com> In-Reply-To: <20240301-psy-class-cleanup-v1-0-aebe8c4b6b08@collabora.com> To: Linus Walleij , "Ricardo B. Marliere" , Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1020; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=JL8wKNHOdoEnADynpbW3pJQDwz790tyACZpDiAY2J+I=; b=owEBbQKS/ZANAwAKAdju1/PIO/qaAcsmYgBl4l2wOC2K0zlJ0WXtxRjoKQH6jaqgh2vg7sb+p 1/KPpzB8dSJAjMEAAEKAB0WIQTvZg0HRj+Lcmp5VBPY7tfzyDv6mgUCZeJdsAAKCRDY7tfzyDv6 miZDD/98H5jw/LKNW4WYCHdko9enIu7PuopK372YXad3d24M8zGqE+aSnlS6So0ltFyHia7XwWY o3bih/n88uDuh4O1Le/a8BkFewDJOeBCWZrYkLd3FmJmWj9jEiuchPzdmAXh9kd6vdZoas4+W3+ XpRNpooBmYjZmEgb4PIupMGvp8Z0LVc8rTqm3oezwIm5yNObky2fRE59kNl1Z6fh+Ni5IuieFEf OoT7ColKRy7aA9KMetWQxIUY7a9n8kQTopu6M2Tlr1yLO7u10t3CqTxv+WOfzelq7a3+08M6LgJ emZyNU6R9aKnYFIgoCfnSe2SiNSZcxcgdIUue618bSb2/el3uw58Q8u7+sIe5usDZ94/500QtlO z3nVl+fi/B7J5jRP3jPl2146Wne/Ue3cTT7W1WXooA2u6YCoV3m4DebtNG11QCRT5iYAfdH6MsS 0hCsn+34torvdqlURPcMRLbK0QsDiAB0Yir9fkMlNQL6VSvhayaAcOmWzK+FaYVCdEZIC/eA1GR qZAd8/DhMdlCxCPedPar5IF/p0XRNA9YoXgHFQ6ouv+0C9BZW4Yfceo2jQ89BL6UcmZQM0t2jem 06QANGMtEWDihNFmSCRgR17KvBF6qjku7EdPjLGVZRBvL4fvaN0agIj3MeHS9AAnHCRov5Ucyyx ZWRLOOflaclaZdg== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792366583457258453 X-GMAIL-MSGID: 1792366583457258453 Technically the sysfs attributes should be initialized before the class is registered, since that will use them. As a nice side effect this nicely simplifies the code, since it allows dropping the helper variable. Signed-off-by: Sebastian Reichel --- drivers/power/supply/power_supply_core.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index 0eb8a57dda70..4daea6ed8f1d 100644 --- a/drivers/power/supply/power_supply_core.c +++ b/drivers/power/supply/power_supply_core.c @@ -1622,15 +1622,8 @@ EXPORT_SYMBOL_GPL(power_supply_get_drvdata); static int __init power_supply_class_init(void) { - int err; - - err = class_register(&power_supply_class); - if (err) - return err; - power_supply_init_attrs(); - - return 0; + return class_register(&power_supply_class); } static void __exit power_supply_class_exit(void)